You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2023/04/11 11:54:13 UTC
[GitHub] [doris] Mryange opened a new pull request, #18565: [feature](function) Modified cast as time to behave more like MySQL
Mryange opened a new pull request, #18565:
URL: https://github.com/apache/doris/pull/18565
# Proposed changes
Because the underlying type of time was float64, select cast("19:22:18" as time) would result in a null value in the past.
Results in the following:
**before**
```
mysql [(none)]>select cast("19:22:18" as time);
+--------------------------+
| CAST('19:22:18' AS TIME) |
+--------------------------+
| NULL |
+--------------------------+
mysql [(none)]>select cast(300 as time);
+-------------------+
| CAST(300 AS TIME) |
+-------------------+
| 00:05:00 |
+-------------------+
mysql [(none)]>select cast(360 as time);
+-------------------+
| CAST(360 AS TIME) |
+-------------------+
| 00:06:00 |
+-------------------+
```
**affter**
```
mysql [(none)]>select cast("19:22:18" as time);
+--------------------------+
| CAST('19:22:18' AS TIME) |
+--------------------------+
| 19:22:18 |
+--------------------------+
mysql [(none)]>select cast(300 as time);
+-------------------+
| CAST(300 AS TIME) |
+-------------------+
| 00:03:00 |
+-------------------+
mysql [(none)]>select cast(360 as time);
+-------------------+
| CAST(360 AS TIME) |
+-------------------+
| NULL |
+-------------------+
```
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1503188627
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1503193380
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1517134947
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1517419729
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514968319
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1504269340
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1516189451
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1512751192
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1517039001
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1512349935
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1512350682
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1512670627
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1510607908
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1503301098
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.47 seconds
stream load tsv: 430 seconds loaded 74807831229 Bytes, about 165 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230411130038_clickbench_pr_127600.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1517733474
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1515649282
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514957352
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1513875046
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514293797
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1510605895
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1508145046
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1512674537
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514287948
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514967198
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1513082132
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1513075477
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #18565:
URL: https://github.com/apache/doris/pull/18565#discussion_r1171066642
##########
be/src/vec/functions/function_cast.h:
##########
@@ -62,7 +65,91 @@ inline UInt32 extract_to_decimal_scale(const ColumnWithTypeAndName& named_column
named_column.column->get(0, field);
return field.get<UInt32>();
}
+/** Cast from string or number to Time.
+ * In Doris, the underlying storage type of the Time class is Float64.
+ */
+struct TimeCast {
+ // Cast from string
+ // Some examples of conversions.
+ // '300' -> 00:03:00 '20:23' -> 20:23:00 '20:23:24' -> 20:23:24
+ template <typename T>
+ static bool try_parse_time(char* s, size_t len, T& x) {
+ char* first_char = s;
+ char* end_char = s + len;
+ int hour = 0, minute = 0, second = 0;
+ auto parse_from_str_to_int = [](char* begin, size_t len, auto& num) {
+ StringParser::ParseResult parse_result = StringParser::PARSE_SUCCESS;
+ auto int_value = StringParser::string_to_unsigned_int<uint64_t>(
+ reinterpret_cast<char*>(begin), len, &parse_result);
+ if (UNLIKELY(parse_result != StringParser::PARSE_SUCCESS)) {
+ return false;
+ }
+ num = int_value;
+ return true;
+ };
+ char *first_colon {nullptr}, *second_colon {nullptr};
+ if ((first_colon = (char*)memchr(first_char, ':', len)) != nullptr) {
+ if ((second_colon = (char*)memchr(first_colon + 1, ':', end_char - first_colon - 1)) !=
+ nullptr) {
+ // find tow colon
+ // parse hour
+ if (!parse_from_str_to_int(first_char, first_colon - first_char, hour)) {
+ // hour failed
+ return false;
+ }
+ // parse minute
+ if (!parse_from_str_to_int(first_colon + 1, second_colon - first_colon - 1,
+ minute)) {
+ return false;
+ }
+ // parse second
+ if (!parse_from_str_to_int(second_colon + 1, end_char - second_colon - 1, second)) {
+ return false;
+ }
+ } else {
+ // find one colon
+ // parse hour
+ if (!parse_from_str_to_int(first_char, first_colon - first_char, hour)) {
+ return false;
+ }
+ // parse minute
+ if (!parse_from_str_to_int(first_colon + 1, end_char - first_colon - 1, minute)) {
+ return false;
+ }
+ }
+ } else {
+ // no colon ,so try to parse as a number
+ size_t from {};
+ if (!parse_from_str_to_int(first_char, len, from)) {
+ return false;
+ }
+ return try_parse_time(from, x);
+ }
+ // minute second must be < 60
+ if (minute >= 60 || second >= 60) {
+ return false;
+ }
+ x = hour * 3600 + minute * 60 + second;
+ return true;
+ }
+ // Cast from number
+ template <typename T, typename S>
+ static bool try_parse_time(T from, S& x) {
+ int64 seconds = from;
+ int64 hour = 0, minute = 0, second = 0;
+ second = seconds % 100;
+ seconds /= 100;
Review Comment:
```
seconds=from/100
second=from-seconds*100
```
Maybe performance will be better this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514957285
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1504272467
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1515651843
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514092366
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #18565:
URL: https://github.com/apache/doris/pull/18565#discussion_r1171071357
##########
be/src/vec/functions/function_cast.h:
##########
@@ -227,11 +314,25 @@ struct ConvertImpl {
}
}
} else {
- for (size_t i = 0; i < size; ++i) {
- vec_to[i] = static_cast<ToFieldType>(vec_from[i]);
+ if constexpr (IsDataTypeNumber<FromDataType> &&
+ std::is_same_v<ToDataType, DataTypeTime>) {
+ // 300 -> 00:03:00 360 will be parse failed , so value maybe null
+ ColumnUInt8::MutablePtr col_null_map_to;
+ ColumnUInt8::Container* vec_null_map_to [[maybe_unused]] = nullptr;
Review Comment:
why have maybe_unused here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1512679375
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514546725
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1517078812
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1508148692
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #18565:
URL: https://github.com/apache/doris/pull/18565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #18565:
URL: https://github.com/apache/doris/pull/18565#discussion_r1169708010
##########
be/src/vec/functions/function_cast.h:
##########
@@ -1805,6 +1921,10 @@ class FunctionCast final : public IFunctionBase {
return false;
};
+ if (to_type->is_time()) {
Review Comment:
use call_index_id to do the work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #18565:
URL: https://github.com/apache/doris/pull/18565#discussion_r1171057112
##########
be/src/vec/functions/function_cast.h:
##########
@@ -62,7 +65,91 @@ inline UInt32 extract_to_decimal_scale(const ColumnWithTypeAndName& named_column
named_column.column->get(0, field);
return field.get<UInt32>();
}
+/** Cast from string or number to Time.
+ * In Doris, the underlying storage type of the Time class is Float64.
+ */
+struct TimeCast {
+ // Cast from string
+ // Some examples of conversions.
+ // '300' -> 00:03:00 '20:23' -> 20:23:00 '20:23:24' -> 20:23:24
+ template <typename T>
+ static bool try_parse_time(char* s, size_t len, T& x) {
+ char* first_char = s;
+ char* end_char = s + len;
+ int hour = 0, minute = 0, second = 0;
+ auto parse_from_str_to_int = [](char* begin, size_t len, auto& num) {
+ StringParser::ParseResult parse_result = StringParser::PARSE_SUCCESS;
+ auto int_value = StringParser::string_to_unsigned_int<uint64_t>(
+ reinterpret_cast<char*>(begin), len, &parse_result);
+ if (UNLIKELY(parse_result != StringParser::PARSE_SUCCESS)) {
+ return false;
+ }
+ num = int_value;
+ return true;
+ };
+ char *first_colon {nullptr}, *second_colon {nullptr};
+ if ((first_colon = (char*)memchr(first_char, ':', len)) != nullptr) {
Review Comment:
better use `If statements with initializer`
if(x=y;x){
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514286420
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #18565:
URL: https://github.com/apache/doris/pull/18565#discussion_r1171062138
##########
be/src/vec/functions/function_cast.h:
##########
@@ -62,7 +65,91 @@ inline UInt32 extract_to_decimal_scale(const ColumnWithTypeAndName& named_column
named_column.column->get(0, field);
return field.get<UInt32>();
}
+/** Cast from string or number to Time.
+ * In Doris, the underlying storage type of the Time class is Float64.
+ */
+struct TimeCast {
+ // Cast from string
+ // Some examples of conversions.
+ // '300' -> 00:03:00 '20:23' -> 20:23:00 '20:23:24' -> 20:23:24
+ template <typename T>
+ static bool try_parse_time(char* s, size_t len, T& x) {
+ char* first_char = s;
+ char* end_char = s + len;
+ int hour = 0, minute = 0, second = 0;
+ auto parse_from_str_to_int = [](char* begin, size_t len, auto& num) {
+ StringParser::ParseResult parse_result = StringParser::PARSE_SUCCESS;
+ auto int_value = StringParser::string_to_unsigned_int<uint64_t>(
+ reinterpret_cast<char*>(begin), len, &parse_result);
+ if (UNLIKELY(parse_result != StringParser::PARSE_SUCCESS)) {
+ return false;
+ }
+ num = int_value;
+ return true;
+ };
+ char *first_colon {nullptr}, *second_colon {nullptr};
+ if ((first_colon = (char*)memchr(first_char, ':', len)) != nullptr) {
+ if ((second_colon = (char*)memchr(first_colon + 1, ':', end_char - first_colon - 1)) !=
+ nullptr) {
+ // find tow colon
Review Comment:
tow->two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1516191675
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1517175455
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1516126053
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1512350839
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1512749066
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514087460
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514983653
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1508796630
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1508800237
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1514551818
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18565: [feature](function) Modified cast as time to behave more like MySQL
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18565:
URL: https://github.com/apache/doris/pull/18565#issuecomment-1517178597
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org