You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by acton393 <gi...@git.apache.org> on 2017/11/07 17:20:30 UTC
[GitHub] incubator-weex pull request #837: [WEEX-98][iOS]bug-fix addEvent lead to gen...
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/837
[WEEX-98][iOS]bug-fix addEvent lead to generate a new view while it as been recycled
In most case , element in cell will be re-use for memory especially in very
long list, but if add event for this element, here will generate a new view for
this element,if it's nil due to a getter method whether it is off-screen.
For instance, image element in cell will re-use if it is disappear in vision area,
loaded again while it back to visual area. In this case , when it disappear, just
add event such as click, touch and so on , it will then create a new view,
and load image again, although it is off-screen.
If the view is not loaded, so won't add gesture or call this view getter to create
any view until the view is loaded, then it will init events according to record in
component.
Bug: 98
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex ios-bugfix-event-leadToView-loaded-again
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #837
----
commit 62677d7cffd2c94abfd4d82e5b3797f65872f91e
Author: acton393 <zh...@gmail.com>
Date: 2017-11-07T17:18:26Z
[WEEX-98][iOS]bug-fix addEvent lead to generate a new view while it has been recycled
In most case , element in cell will be re-use for memory especially in very
long list, but if add event for this element, here will generate a new view for
this element,if it's nil due to a getter method whether it is off-screen.
For instance, image element in cell will re-use if it is disappear in vision area,
loaded again while it back to visual area. In this case , when it disappear, just
add event such as click, touch and so on , it will then create a new view,
and load image again, although it is off-screen.
If the view is not loaded, so won't add gesture or call this view getter to create
any view until the view is loaded, then it will init events according to record in
component.
Bug: 98
----
---
[GitHub] incubator-weex issue #837: [WEEX-98][iOS]bug-fix addEvent lead to generate a...
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on the issue:
https://github.com/apache/incubator-weex/pull/837
LGTM
---
[GitHub] incubator-weex pull request #837: [WEEX-98][iOS]bug-fix addEvent lead to gen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/837
---
[GitHub] incubator-weex issue #837: [WEEX-98][iOS]bug-fix addEvent lead to generate a...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/837
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---