You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by GitBox <gi...@apache.org> on 2018/04/15 13:26:32 UTC

[GitHub] codecov-io commented on issue #129: KYLIN-3339, decoupling SQL keywords set with specify implementation.

codecov-io commented on issue #129: KYLIN-3339, decoupling SQL keywords set with specify implementation.
URL: https://github.com/apache/kylin/pull/129#issuecomment-381406534
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/129?src=pr&el=h1) Report
   > Merging [#129](https://codecov.io/gh/apache/kylin/pull/129?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/2cda6c39f7cbd82eba0aa9518526472deea7c479?src=pr&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/129/graphs/tree.svg?src=pr&token=JawVgbgsVo&width=650&height=150)](https://codecov.io/gh/apache/kylin/pull/129?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #129      +/-   ##
   ===========================================
   - Coverage     21.93%   21.9%   -0.04%     
   + Complexity     3895    3890       -5     
   ===========================================
     Files           993     994       +1     
     Lines         59926   59931       +5     
     Branches       8645    8645              
   ===========================================
   - Hits          13146   13125      -21     
   - Misses        45559   45587      +28     
   + Partials       1221    1219       -2
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/129?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kylin/source/adhocquery/HivePushDownConverter.java](https://codecov.io/gh/apache/kylin/pull/129/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2FkaG9jcXVlcnkvSGl2ZVB1c2hEb3duQ29udmVydGVyLmphdmE=) | `65.51% <100%> (+0.91%)` | `16 <0> (ø)` | :arrow_down: |
   | [...he/kylin/source/adhocquery/IPushDownConverter.java](https://codecov.io/gh/apache/kylin/pull/129/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2FkaG9jcXVlcnkvSVB1c2hEb3duQ29udmVydGVyLmphdmE=) | `100% <100%> (ø)` | `1 <1> (?)` | |
   | [...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/129/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | |
   | [...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/129/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==) | `11.51% <0%> (-5.24%)` | `4% <0%> (-2%)` | |
   | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/129/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `30.67% <0%> (-1.69%)` | `20% <0%> (-1%)` | |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/129/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `14.89% <0%> (-1.23%)` | `35% <0%> (-2%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/129/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
   | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/129/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `55.22% <0%> (-0.5%)` | `21% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/129?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/129?src=pr&el=footer). Last update [2cda6c3...f730588](https://codecov.io/gh/apache/kylin/pull/129?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services