You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/10/10 15:53:02 UTC

[GitHub] drcrallen commented on a change in pull request #6440: Fix avro parser issue while deserializing sketches

drcrallen commented on a change in pull request #6440: Fix avro parser issue while deserializing sketches 
URL: https://github.com/apache/incubator-druid/pull/6440#discussion_r224137980
 
 

 ##########
 File path: extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/AvroFlattenerMaker.java
 ##########
 @@ -105,7 +104,7 @@ private Object transformValue(final Object field)
       if (binaryAsString) {
         return StringUtils.fromUtf8(((ByteBuffer) field).array());
       } else {
-        return Arrays.toString(((ByteBuffer) field).array());
+        return ((ByteBuffer) field).array();
 
 Review comment:
   a byte buffer is not guaranteed to be array backed, but this is not worse than the prior implementation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org