You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/09/02 21:52:10 UTC
[GitHub] [trafficcontrol] rawlinp commented on pull request #6163: t3c check for live service before adding to ramdisk
rawlinp commented on pull request #6163:
URL: https://github.com/apache/trafficcontrol/pull/6163#issuecomment-912083958
I believe this code change is correct in that it prevents topology-based, non-live DSes from getting assigned to the RAM disk, but it looks like the unit tests reinforce the original, incorrect behavior.
For the record, I think we should totally simplify the logic for creating this file and just add a line for every live-type DS origin, irregardless of whether or not the DS is actually assigned to the server (via DSS or topology) and whether or not the DS is a mid or an edge. It's not "ideal" in that it adds lines for DSes that don't use that particular server, but I think the gains in simplicity of this code would be worth it. That, and it probably doesn't hurt ATS to have extra entries in there that don't actually get used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org