You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/01/28 18:57:12 UTC

[GitHub] [accumulo] EdColeman commented on a change in pull request #1453: WIP Update Last Location. Solution for #1169

EdColeman commented on a change in pull request #1453: WIP Update Last Location. Solution for #1169
URL: https://github.com/apache/accumulo/pull/1453#discussion_r371993875
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
 ##########
 @@ -508,6 +508,11 @@
   TSERV_SUMMARY_RETRIEVAL_THREADS("tserver.summary.retrieval.threads", "10", PropertyType.COUNT,
       "The number of threads on each tablet server available to retrieve"
           + " summary data, that is not currently in cache, from RFiles."),
+  TSERV_LASTLOCATION_UPDATE_TIME("tserver.lastlocation.update.time", "1000000", PropertyType.COUNT,
 
 Review comment:
   Without looking at the code (and not being familiar with the particulars) - I find this description / value confusing.  The property is named TIME, but you are using a PropertyType.COUNT.  At first, I wondered why you didn't specify the time as 15m or 900s, or whatever human readable value.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services