You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/10/18 06:53:05 UTC
[jira] [Commented] (SOLR-8114) Grouping.java: sort variable names
confusion
[ https://issues.apache.org/jira/browse/SOLR-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962179#comment-14962179 ]
ASF subversion and git services commented on SOLR-8114:
-------------------------------------------------------
Commit 1709230 from [~cpoerschke] in branch 'dev/trunk'
[ https://svn.apache.org/r1709230 ]
SOLR-8114: in Grouping.java rename groupSort to withinGroupSort
> Grouping.java: sort variable names confusion
> --------------------------------------------
>
> Key: SOLR-8114
> URL: https://issues.apache.org/jira/browse/SOLR-8114
> Project: Solr
> Issue Type: Wish
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-8114-part1of2.patch, SOLR-8114-part2of2.patch
>
>
> The undistributed case i.e. {{solr/Grouping.java}}'s variable names confusingly differ from the names used by lucene (and by the distributed case).
> Specifically the name {{groupSort}} in lucene (and in the distributed case) means between-groups-sort but in the Grouping.java it means within-group-sort.
> lucene:
> {code}
> TermFirstPassGroupingCollector(... Sort groupSort ...)
> TermSecondPassGroupingCollector(... Sort groupSort, Sort withinGroupSort ...)
> {code}
> solr:
> {code}
> SearchGroupsFieldCommand.java: firstPassGroupingCollector = new TermFirstPassGroupingCollector(field.getName(), groupSort, topNGroups);
> TopGroupsFieldCommand.java: secondPassCollector = new TermSecondPassGroupingCollector(... groupSort, sortWithinGroup ...);
> Grouping.java: public Sort groupSort; // the sort of the documents *within* a single group.
> Grouping.java: public Sort sort; // the sort between groups
> Grouping.java: firstPass = new TermFirstPassGroupingCollector(groupBy, sort, actualGroupsToFind);
> Grouping.java: secondPass = new TermSecondPassGroupingCollector(... sort, groupSort ...);
> {code}
> This JIRA proposes to rename the Grouping.java variables to remove the confusion:
> * part 1: in Grouping.java rename groupSort to withinGroupSort
> * part 2: in Grouping.java rename sort to groupSort
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org