You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2021/03/02 05:36:44 UTC
Review Request 73211: ATLAS-4182 : Quick Search: Incorrect aggregation
Metric when less than operator is selected to filter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73211/
-----------------------------------------------------------
Review request for atlas, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4182
https://issues.apache.org/jira/browse/ATLAS-4182
Repository: atlas
Description
-------
**Issue:** The aggregation metrics for POST /api/atlas/v2/search/quick API returned the count of all entities (of a selected type) in case the createTime < '{value}' filter is applied which results in no entities for the given search range.
**Example payload:** {"assetProvider":"ATLAS","excludeDeletedEntities":true,"includeSubClassifications":true,"includeSubTypes":true,"tagFilters":null,"attributes":["qualifiedName","createTime","db","parameters"],"query":"","typeName":"hive_table","entityFilters":{"condition":"AND","criterion":[{"condition":"AND","criterion":[
{"attributeName":"createTime","operator":"lt","attributeValue":"1613973469738"}
]}]},"classification":null,"childClassification":null,"limit":100,"offset":0}
Diffs
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java 5712fd3d0
Diff: https://reviews.apache.org/r/73211/diff/1/
Testing
-------
Manually tested
Thanks,
Pinal Shah
Re: Review Request 73211: ATLAS-4182 : Quick Search: Incorrect
aggregation Metric when less than operator is selected to filter
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73211/#review222647
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 2, 2021, 5:36 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73211/
> -----------------------------------------------------------
>
> (Updated March 2, 2021, 5:36 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4182
> https://issues.apache.org/jira/browse/ATLAS-4182
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Issue:** The aggregation metrics for POST /api/atlas/v2/search/quick API returned the count of all entities (of a selected type) in case the createTime < '{value}' filter is applied which results in no entities for the given search range.
>
> **Example payload:** {"assetProvider":"ATLAS","excludeDeletedEntities":true,"includeSubClassifications":true,"includeSubTypes":true,"tagFilters":null,"attributes":["qualifiedName","createTime","db","parameters"],"query":"","typeName":"hive_table","entityFilters":{"condition":"AND","criterion":[{"condition":"AND","criterion":[
>
> {"attributeName":"createTime","operator":"lt","attributeValue":"1613973469738"}
> ]}]},"classification":null,"childClassification":null,"limit":100,"offset":0}
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasSolrQueryBuilder.java 5712fd3d0
>
>
> Diff: https://reviews.apache.org/r/73211/diff/1/
>
>
> Testing
> -------
>
> Manually tested
>
>
> Thanks,
>
> Pinal Shah
>
>