You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/30 07:57:41 UTC

[GitHub] [flink] curcur edited a comment on pull request #15200: [FLINK-21355] Send changes to the state changelog

curcur edited a comment on pull request #15200:
URL: https://github.com/apache/flink/pull/15200#issuecomment-810002177


   Main issues:
   
   1. Loader seems a bit too hacky, I am not sure whether we can use it this way, need @pnowojski to take a look
   2. Map iterators, have some uncertainties, commented in place
   3. Aggregating State, whether we want to use `update` to simulate `add`. I guess this is not our original intention.
   4. How to differentiate PriorityQueue changes, also commented in place.
   
   Tests are not reviewed yet, I will review tests now.
   
   Additionally, would you please move metadata changes to recovery, I have not reviewed that part as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org