You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/03 22:26:52 UTC

[GitHub] [pulsar] dunglas opened a new pull request #6666: [Issue 6663][helm] Lint the Helm chart in the CI

dunglas opened a new pull request #6666: [Issue 6663][helm] Lint the Helm chart in the CI
URL: https://github.com/apache/pulsar/pull/6666
 
 
   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ### Motivation
   
   Prevent issues such as #6663 by checking the validity of the Helm chart in the CI.
   
   ### Modifications
   
   Add a GitHub Actions workflow checking the chart.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
     - *run `helm lint`*
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] dunglas commented on issue #6666: [Issue 6663][helm] Lint the Helm chart in the CI

Posted by GitBox <gi...@apache.org>.
dunglas commented on issue #6666: [Issue 6663][helm] Lint the Helm chart in the CI
URL: https://github.com/apache/pulsar/pull/6666#issuecomment-608821758
 
 
   Thanks for this great software, and for the quick merge!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #6666: [Issue 6663][helm] Lint the Helm chart in the CI

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6666: [Issue 6663][helm] Lint the Helm chart in the CI
URL: https://github.com/apache/pulsar/pull/6666
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #6666: [Issue 6663][helm] Lint the Helm chart in the CI

Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6666: [Issue 6663][helm] Lint the Helm chart in the CI
URL: https://github.com/apache/pulsar/pull/6666#issuecomment-608820347
 
 
   @dunglas thank you for your contribution! Adding CI to helm chart has been in my to-do list for a while.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services