You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tsudukim <gi...@git.apache.org> on 2016/03/01 10:15:42 UTC
[GitHub] spark pull request: [SPARK-13592][Windows] fix path of spark-submi...
GitHub user tsudukim opened a pull request:
https://github.com/apache/spark/pull/11442
[SPARK-13592][Windows] fix path of spark-submit2.cmd in spark-submit.cmd
## What changes were proposed in this pull request?
This patch fixes the problem that pyspark fails on Windows because pyspark can't find ```spark-submit2.cmd```.
## How was this patch tested?
manual tests:
I runned ```bin\pyspark.cmd``` and checked if pyspark is launched correctly after this patch is applyed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tsudukim/spark feature/SPARK-13592
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11442.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11442
----
commit 5a8ea5b4f2efd9b5b9e3b24640b72a7edec58eee
Author: Masayoshi TSUZUKI <ts...@oss.nttdata.co.jp>
Date: 2016-03-01T09:02:36Z
[SPARK-13592][Windows] fix path of spark-submit2.cmd in spark-submit.cmd.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13592][Windows] fix path of spark-submi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11442#issuecomment-190683647
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13592][Windows] fix path of spark-submi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11442#issuecomment-190683659
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52231/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13592][Windows] fix path of spark-submi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13592][Windows] fix path of spark-submi...
Posted by tsudukim <gi...@git.apache.org>.
Github user tsudukim commented on the pull request:
https://github.com/apache/spark/pull/11442#issuecomment-191007237
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13592][Windows] fix path of spark-submi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11442#issuecomment-190747649
Merged to master. Actually, this was not a problem in earlier branches, and I figured out that https://github.com/apache/spark/commit/2ba9b6a2dfff8eb06b6f93024f5140e784b8be49#diff-fbd7428b349a0b32fcc71e6ea4eb5d98 actually inadvertently reverted the change that your PR restores now. It could well be my fault, messing up a merge somewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13592][Windows] fix path of spark-submi...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11442#issuecomment-190674205
Good catch. This is really like a follow-on to your SPARK-3943 from a long time ago
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13592][Windows] fix path of spark-submi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11442#issuecomment-190682868
**[Test build #52231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52231/consoleFull)** for PR 11442 at commit [`5a8ea5b`](https://github.com/apache/spark/commit/5a8ea5b4f2efd9b5b9e3b24640b72a7edec58eee).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13592][Windows] fix path of spark-submi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11442#issuecomment-190628735
**[Test build #52231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52231/consoleFull)** for PR 11442 at commit [`5a8ea5b`](https://github.com/apache/spark/commit/5a8ea5b4f2efd9b5b9e3b24640b72a7edec58eee).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org