You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/07 14:14:26 UTC
[GitHub] [spark] cloud-fan opened a new pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
cloud-fan opened a new pull request #32807:
URL: https://github.com/apache/spark/pull/32807
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a followup of https://github.com/apache/spark/pull/31964
We should only quote the column name when nested column predicate pushdown is enabled, otherwise the data source side may not have the logic to parse the quoted column name and fail. This is not a problem before #31964 , as we don't quote the column name if there is no dot in the name. But #31964 changed it.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
fix a query failure
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856454137
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139448/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856014378
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43944/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-857862166
cc @maropu for another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856044226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856073939
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-860713262
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856158371
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139423/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856936451
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44015/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32807:
URL: https://github.com/apache/spark/pull/32807#discussion_r648019398
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala
##########
@@ -35,8 +35,9 @@ sealed abstract class Filter {
/**
* List of columns that are referenced by this filter.
*
- * Note that, each element in `references` represents a column; `dots` are used as separators
- * for nested columns. If any part of the names contains `dots`, it is quoted to avoid confusion.
+ * Note that, each element in `references` represents a column. The column name follows ANSI SQL
+ * names and identifiers: dots are used as separators for nested columns, name will be quoted if
+ * it contains special chars.
Review comment:
So it extends the coverage of quoted name (originally it is only for non-separator dots)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32807:
URL: https://github.com/apache/spark/pull/32807#discussion_r648082097
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
Review comment:
Yea I think that's rare. V2 implementations should already be using a decent parser that recognizes dots and backticks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856867027
**[Test build #139491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139491/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-859756215
ping @maropu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-860711827
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139773/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856878761
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856867027
**[Test build #139491 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139491/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856277965
**[Test build #139430 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139430/testReport)** for PR 32807 at commit [`090bed6`](https://github.com/apache/spark/commit/090bed613b039ba94607eba2c2349492cb6979d8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856162820
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43953/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856044190
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43944/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856646706
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139454/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856496277
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32807:
URL: https://github.com/apache/spark/pull/32807#discussion_r647111792
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
Review comment:
cc @dbtsai @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856523390
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856564511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43977/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-860713262
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44299/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-860131607
@cloud-fan, would you mind fixing the PR title to reflect the change itself instead of the issue being fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856278904
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139430/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-861844508
**[Test build #139819 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139819/testReport)** for PR 32807 at commit [`d4d1489`](https://github.com/apache/spark/commit/d4d1489594fb1e6a3c54c4ffc1d92511ed874e36).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-861865123
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139819/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856873073
**[Test build #139491 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139491/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856162794
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43953/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-860131607
@cloud-fan, would you mind fixing the PR title to reflect the change itself instead of the issue being fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-861925416
Thanks, merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856162820
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43953/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-861865123
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139819/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856476375
retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32807:
URL: https://github.com/apache/spark/pull/32807#discussion_r648021556
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
Review comment:
looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-855970733
**[Test build #139422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139422/testReport)** for PR 32807 at commit [`f3e58c5`](https://github.com/apache/spark/commit/f3e58c51acded9516b59564e0f8ec0395789e4e8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856485015
**[Test build #139454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139454/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #32807:
URL: https://github.com/apache/spark/pull/32807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856454137
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139448/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856642285
**[Test build #139454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139454/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
* This patch **fails PySpark pip packaging tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-861671859
**[Test build #139819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139819/testReport)** for PR 32807 at commit [`d4d1489`](https://github.com/apache/spark/commit/d4d1489594fb1e6a3c54c4ffc1d92511ed874e36).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856952523
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44015/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32807:
URL: https://github.com/apache/spark/pull/32807#discussion_r648080461
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala
##########
@@ -35,8 +35,9 @@ sealed abstract class Filter {
/**
* List of columns that are referenced by this filter.
*
- * Note that, each element in `references` represents a column; `dots` are used as separators
- * for nested columns. If any part of the names contains `dots`, it is quoted to avoid confusion.
+ * Note that, each element in `references` represents a column. The column name follows ANSI SQL
+ * names and identifiers: dots are used as separators for nested columns, name will be quoted if
+ * it contains special chars.
Review comment:
yea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856126976
**[Test build #139430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139430/testReport)** for PR 32807 at commit [`090bed6`](https://github.com/apache/spark/commit/090bed613b039ba94607eba2c2349492cb6979d8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856993747
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44019/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856864916
retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856873122
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139491/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856126976
**[Test build #139430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139430/testReport)** for PR 32807 at commit [`090bed6`](https://github.com/apache/spark/commit/090bed613b039ba94607eba2c2349492cb6979d8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856451502
**[Test build #139448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139448/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856158371
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139423/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-855970733
**[Test build #139422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139422/testReport)** for PR 32807 at commit [`f3e58c5`](https://github.com/apache/spark/commit/f3e58c51acded9516b59564e0f8ec0395789e4e8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856099290
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43945/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856454109
**[Test build #139448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139448/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856026464
**[Test build #139423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139423/testReport)** for PR 32807 at commit [`09817fb`](https://github.com/apache/spark/commit/09817fbf80e75646cc9bd9691165348106cf9075).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856117236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-861717089
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856880500
**[Test build #139495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139495/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856646706
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139454/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856880500
**[Test build #139495 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139495/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856405163
Shall we revert https://github.com/apache/spark/pull/31964?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-861671859
**[Test build #139819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139819/testReport)** for PR 32807 at commit [`d4d1489`](https://github.com/apache/spark/commit/d4d1489594fb1e6a3c54c4ffc1d92511ed874e36).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-857099605
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856044226
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43944/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856115307
**[Test build #139422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139422/testReport)** for PR 32807 at commit [`f3e58c5`](https://github.com/apache/spark/commit/f3e58c51acded9516b59564e0f8ec0395789e4e8).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856451502
**[Test build #139448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139448/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-859914275
This looks good. I'll merge this later if no more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-857099605
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856026464
**[Test build #139423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139423/testReport)** for PR 32807 at commit [`09817fb`](https://github.com/apache/spark/commit/09817fbf80e75646cc9bd9691165348106cf9075).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856537000
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43977/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-861712686
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856145272
**[Test build #139423 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139423/testReport)** for PR 32807 at commit [`09817fb`](https://github.com/apache/spark/commit/09817fbf80e75646cc9bd9691165348106cf9075).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856564511
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43977/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856993747
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44019/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856910911
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44015/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856873122
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139491/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856474653
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856485015
**[Test build #139454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139454/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856952523
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44015/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856411972
#31964 is mostly for the display format of queries so we can revert it safely. But even if we revert it, the potential problem is present isn't it?
This problem happens with ```col("`a``b`")``` even before #31964.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-855966874
cc @sarutak @tanelk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856515157
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43977/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856385072
cc @MaxGekk too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32807:
URL: https://github.com/apache/spark/pull/32807#discussion_r650451379
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
+ extractNameAdvanced(e).map(_.quoted)
+ } else {
+ extractNameBasic(e)
}
- helper(e).map(_.quoted)
+ }
+
+ private def extractNameBasic(e: Expression): Option[String] = e match {
+ // Attribute that contains dot "." in name is supported only when nested predicate pushdown
+ // is enabled.
+ case a: Attribute if !a.name.contains(".") => Some(a.name)
+ case _ => None
+ }
+
+ private def extractNameAdvanced(e: Expression): Option[Seq[String]] = e match {
Review comment:
```suggestion
private def extractQualifiedName(e: Expression): Option[Seq[String]] = e match {
```
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
+ extractNameAdvanced(e).map(_.quoted)
+ } else {
+ extractNameBasic(e)
}
- helper(e).map(_.quoted)
+ }
+
+ private def extractNameBasic(e: Expression): Option[String] = e match {
Review comment:
```suggestion
private def extractPlainName(e: Expression): Option[String] = e match {
```
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
+ extractNameAdvanced(e).map(_.quoted)
+ } else {
+ extractNameBasic(e)
Review comment:
```suggestion
extractPlainName(e)
```
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
+ extractNameAdvanced(e).map(_.quoted)
Review comment:
```suggestion
extractQualifiedName(e).map(_.quoted)
```
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
+ extractNameAdvanced(e).map(_.quoted)
+ } else {
+ extractNameBasic(e)
}
- helper(e).map(_.quoted)
+ }
+
+ private def extractNameBasic(e: Expression): Option[String] = e match {
+ // Attribute that contains dot "." in name is supported only when nested predicate pushdown
+ // is enabled.
+ case a: Attribute if !a.name.contains(".") => Some(a.name)
+ case _ => None
+ }
+
+ private def extractNameAdvanced(e: Expression): Option[Seq[String]] = e match {
+ case a: Attribute => Some(Seq(a.name))
+ case s: GetStructField =>
+ extractNameAdvanced(s.child).map(_ :+ s.childSchema(s.ordinal).name)
Review comment:
```suggestion
extractQualifiedName(s.child).map(_ :+ s.childSchema(s.ordinal).name)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-860711827
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139773/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856974012
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44019/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856950048
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44019/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856278904
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139430/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856411972
#31964 is mostly for the display format of queries so we can revert it safely and I don't mind. But even if we revert it, the potential problem is present isn't it?
This problem happens with ```col("`a``b`")``` even before #31964.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-857077534
**[Test build #139495 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139495/testReport)** for PR 32807 at commit [`8e53b88`](https://github.com/apache/spark/commit/8e53b88de26915038a5aa10dddece692eb33efad).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #32807:
URL: https://github.com/apache/spark/pull/32807#discussion_r648022478
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
Review comment:
Only exceptional one might be, if a v2 implementation can only handle quoted "dots", but not other quoted chars, right? I think it should be rare cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #32807:
URL: https://github.com/apache/spark/pull/32807#discussion_r647111703
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -699,20 +699,25 @@ abstract class PushableColumnBase {
def unapply(e: Expression): Option[String] = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
- def helper(e: Expression): Option[Seq[String]] = e match {
- case a: Attribute =>
- // Attribute that contains dot "." in name is supported only when
- // nested predicate pushdown is enabled.
- if (nestedPredicatePushdownEnabled || !a.name.contains(".")) {
- Some(Seq(a.name))
- } else {
- None
- }
- case s: GetStructField if nestedPredicatePushdownEnabled =>
- helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
- case _ => None
+ if (nestedPredicatePushdownEnabled) {
Review comment:
note that:
1. nestedPredicatePushdownEnabled is always enabled for DS v2 (by default)
2. nestedPredicatePushdownEnabled is never enabled for DS v1
3. nestedPredicatePushdownEnabled is only enabled for file source parquet and orc (by default)
After changing the quoting logic:
1. DS v1 is not affected
2. file source is builtin so we are fine
3. DS v2 will be affected if the column name contains special chars.
Personally, I think the new quoting behavior is better (more ANSI SQL), and most v2 implementations won't be affected as they already need to deal with quoted names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32807: [SPARK-35669][SQL] Quote the pushed column name only when nested column predicate pushdown is enabled
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-861717089
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44347/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32807: [SPARK-35669][SQL] Fix special char in CSV header with filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32807:
URL: https://github.com/apache/spark/pull/32807#issuecomment-856523390
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43971/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org