You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "absolute8511 (via GitHub)" <gi...@apache.org> on 2023/05/23 14:01:14 UTC
[GitHub] [rocketmq] absolute8511 opened a new pull request, #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush
absolute8511 opened a new pull request, #6801:
URL: https://github.com/apache/rocketmq/pull/6801
Change-Id: I1ebf4748c26c42efb058c11a8b5084b69213892c
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
Fixes #6800
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] absolute8511 commented on a diff in pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush
Posted by "absolute8511 (via GitHub)" <gi...@apache.org>.
absolute8511 commented on code in PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#discussion_r1204187512
##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
return isEnableBatchPush;
}
- public void setEnableBatchPush(boolean enableBatchPush) {
+ public void setIsEnableBatchPush(boolean enableBatchPush) {
isEnableBatchPush = enableBatchPush;
Review Comment:
If change the var name I think it will break the compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #6801: [ISSUE #6800] fix: change the config variable isEnableBatchPush to enableBatchPush
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#issuecomment-1559519319
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6801?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6801](https://app.codecov.io/gh/apache/rocketmq/pull/6801?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cadac99) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/eef581b464d0144a3ec400a20087196f7eefd764?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (eef581b) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## develop #6801 +/- ##
=============================================
- Coverage 42.93% 42.88% -0.05%
+ Complexity 8995 8987 -8
=============================================
Files 1104 1104
Lines 78380 78380
Branches 10207 10207
=============================================
- Hits 33654 33615 -39
- Misses 40512 40548 +36
- Partials 4214 4217 +3
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6801?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/rocketmq/store/config/MessageStoreConfig.java](https://app.codecov.io/gh/apache/rocketmq/pull/6801?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2NvbmZpZy9NZXNzYWdlU3RvcmVDb25maWcuamF2YQ==) | `58.08% <ø> (+0.31%)` | :arrow_up: |
... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6801/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] absolute8511 commented on a diff in pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush
Posted by "absolute8511 (via GitHub)" <gi...@apache.org>.
absolute8511 commented on code in PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#discussion_r1205564274
##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
return isEnableBatchPush;
}
- public void setEnableBatchPush(boolean enableBatchPush) {
+ public void setIsEnableBatchPush(boolean enableBatchPush) {
isEnableBatchPush = enableBatchPush;
Review Comment:
But getBrokerConfig will use isEnableBatchPush, which is inconsistence. I think maybe we need make it the same as other config name which using the variable name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] absolute8511 commented on a diff in pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush
Posted by "absolute8511 (via GitHub)" <gi...@apache.org>.
absolute8511 commented on code in PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#discussion_r1205564274
##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
return isEnableBatchPush;
}
- public void setEnableBatchPush(boolean enableBatchPush) {
+ public void setIsEnableBatchPush(boolean enableBatchPush) {
isEnableBatchPush = enableBatchPush;
Review Comment:
But getBrokerConfig will use isEnableBatchPush, which is inconsistence. I think maybe we need make it the same as other config name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ferrirW commented on a diff in pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush
Posted by "ferrirW (via GitHub)" <gi...@apache.org>.
ferrirW commented on code in PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#discussion_r1203786328
##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
return isEnableBatchPush;
}
- public void setEnableBatchPush(boolean enableBatchPush) {
+ public void setIsEnableBatchPush(boolean enableBatchPush) {
isEnableBatchPush = enableBatchPush;
Review Comment:
IMO,change the isEnableBatchPush to enableBatchPush is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] absolute8511 commented on a diff in pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush
Posted by "absolute8511 (via GitHub)" <gi...@apache.org>.
absolute8511 commented on code in PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#discussion_r1206168902
##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
return isEnableBatchPush;
}
- public void setEnableBatchPush(boolean enableBatchPush) {
+ public void setIsEnableBatchPush(boolean enableBatchPush) {
isEnableBatchPush = enableBatchPush;
Review Comment:
@cserwen since old isEnableBatchPush is ignored, and I think we can change the variable name `isEnableBatchPush` to `enableBatchPush` without break compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on a diff in pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on code in PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#discussion_r1205243233
##########
store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
##########
@@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
return isEnableBatchPush;
}
- public void setEnableBatchPush(boolean enableBatchPush) {
+ public void setIsEnableBatchPush(boolean enableBatchPush) {
isEnableBatchPush = enableBatchPush;
Review Comment:
Now we can set it in broker.cfg by `enableBatchPush`, so use `enableBatchPush` directly is better. @absolute8511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #6801: [ISSUE #6800] fix: wrong setter for config isEnableBatchPush
Posted by "cserwen (via GitHub)" <gi...@apache.org>.
cserwen commented on PR #6801:
URL: https://github.com/apache/rocketmq/pull/6801#issuecomment-1562970020
我们现在在配置文件中通过 enableBatchPush 来设置这个配置,因此你不能修改set的方法,那样会导致配置项的不兼容,一个更好的方式是修改变量名称为enableBatchPush,并修改isEnableBatchPush() 为enableBatchPush()在 2023年5月25日,21:59,Vincent Lee ***@***.***> 写道:
@absolute8511 commented on this pull request.
In store/src/main/java/org/apache/rocketmq/store/config/MessageStoreConfig.java:
> @@ -1129,7 +1129,7 @@ public boolean isEnableBatchPush() {
return isEnableBatchPush;
}
- public void setEnableBatchPush(boolean enableBatchPush) {
+ public void setIsEnableBatchPush(boolean enableBatchPush) {
isEnableBatchPush = enableBatchPush;
But getBrokerConfig will use isEnableBatchPush, which is inconsistence. I think maybe we need make it the same as other config name
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org