Re: [PR] SortMerge join support for IS NOT DISTINCT FROM. (druid)

["LakshSingla (via GitHub)" <gi...@apache.org>]

LakshSingla commented on code in PR #16003:
URL: https://github.com/apache/druid/pull/16003#discussion_r1526562336


##########
processing/src/main/java/org/apache/druid/frame/key/FrameComparisonWidgetImpl.java:
##########
@@ -138,21 +139,29 @@ public RowKey readKey(int row)
   }
 
   @Override
-  public boolean isCompletelyNonNullKey(int row)
+  public boolean hasNonNullKeyParts(int row, int[] keyParts)
   {
-    if (keyFieldCount == 0) {
+    if (keyParts.length == 0) {
       return true;
     }

Review Comment:
   nit: redundant check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org