You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by cvlchinet <gi...@git.apache.org> on 2014/11/24 23:12:40 UTC
[GitHub] thrift pull request: THRIFT-2853: Remove comments that doesn't app...
GitHub user cvlchinet opened a pull request:
https://github.com/apache/thrift/pull/286
THRIFT-2853: Remove comments that doesn't apply anymore because of THRIFT-2852
THRIFT-2852 changed behavior of iostream_transport.go which made some comments invalid.
This PR removes the remaining comments.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cvlchinet/thrift go-comment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #286
----
commit 11774ee72d962533f1ea8585eddbba558d57eb3e
Author: Chi Vinh Le <cv...@chinet.info>
Date: 2014-11-24T22:07:28Z
Remove comments that doesn't apply anymore.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2853: Remove comments that doesn't app...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/286
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---