You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/13 11:36:28 UTC
[GitHub] [flink] alpinegizmo commented on a diff in pull request #19830: [FLINK-27808][ha] Allow "kubernetes" as HA_MODE
alpinegizmo commented on code in PR #19830:
URL: https://github.com/apache/flink/pull/19830#discussion_r895612253
##########
docs/layouts/shortcodes/generated/high_availability_configuration.html:
##########
@@ -12,7 +12,7 @@
<td><h5>high-availability</h5></td>
<td style="word-wrap: break-word;">"NONE"</td>
<td>String</td>
- <td>Defines high-availability mode used for the cluster execution. To enable high-availability, set this mode to "ZOOKEEPER" or specify FQN of factory class.</td>
+ <td>Defines high-availability mode used for the cluster execution. To enable high-availability, set this mode to "ZOOKEEPER", "KUBERNETES" or specify FQN of factory class.</td>
Review Comment:
```suggestion
<td>Defines high-availability mode used for cluster execution. To enable high-availability, set this mode to "ZOOKEEPER", "KUBERNETES", or the fully qualified name of the factory class.</td>
```
##########
docs/layouts/shortcodes/generated/common_high_availability_section.html:
##########
@@ -12,7 +12,7 @@
<td><h5>high-availability</h5></td>
<td style="word-wrap: break-word;">"NONE"</td>
<td>String</td>
- <td>Defines high-availability mode used for the cluster execution. To enable high-availability, set this mode to "ZOOKEEPER" or specify FQN of factory class.</td>
+ <td>Defines high-availability mode used for the cluster execution. To enable high-availability, set this mode to "ZOOKEEPER", "KUBERNETES" or specify FQN of factory class.</td>
Review Comment:
```suggestion
<td>Defines high-availability mode used for cluster execution. To enable high-availability, set this mode to "ZOOKEEPER", "KUBERNETES", or the fully qualified name of the factory class.</td>
```
##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -33,8 +33,8 @@ public class HighAvailabilityOptions {
/**
* Defines high-availability mode used for the cluster execution. A value of "NONE" signals no
- * highly available setup. To enable high-availability, set this mode to "ZOOKEEPER". Can also
- * be set to FQN of HighAvailability factory class.
+ * highly available setup. To enable high-availability, set this mode to "ZOOKEEPER" or
+ * "KUBERNETES". Can also be set to FQN of HighAvailability factory class.
Review Comment:
```suggestion
* "KUBERNETES". Can also be set to the FQN of the HighAvailability factory class.
```
##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -44,7 +44,7 @@ public class HighAvailabilityOptions {
.withDeprecatedKeys("recovery.mode")
.withDescription(
"Defines high-availability mode used for the cluster execution."
Review Comment:
```suggestion
"Defines high-availability mode used for cluster execution."
```
##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -44,7 +44,7 @@ public class HighAvailabilityOptions {
.withDeprecatedKeys("recovery.mode")
.withDescription(
"Defines high-availability mode used for the cluster execution."
- + " To enable high-availability, set this mode to \"ZOOKEEPER\" or specify FQN of factory class.");
+ + " To enable high-availability, set this mode to \"ZOOKEEPER\", \"KUBERNETES\" or specify FQN of factory class.");
Review Comment:
Sorry, but due to a github-ui issue I couldn't make this a suggestion.
+ " To enable high-availability, set this mode to \"ZOOKEEPER\", \"KUBERNETES\", or specify the fully qualified name of the factory class.");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org