You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/11/19 18:51:46 UTC
[PR] HDDS-13959. Flaky check fails at testPurgeKeysRequestBatching despite passing repeated run [ozone]
adoroszlai opened a new pull request, #9329:
URL: https://github.com/apache/ozone/pull/9329
## What changes were proposed in this pull request?
`testPurgeKeysRequestBatching` is flaky (HDDS-13661) and annotated as such. _integration (flaky)_ repeats the failing test, and it passes on re-run, but the CI check is still reported as failure.
Tests in `TestKeyDeletingService` are in nested classes, except `testPurgeKeysRequestBatching`, which causes this problem.
This is fixed by moving `testPurgeKeysRequestBatching` into its own nested class. The test is still flaky, but successful re-try is no longer reported as failure.
https://issues.apache.org/jira/browse/HDDS-13959
## How was this patch tested?
Before:
```bash
$ ./hadoop-ozone/dev-support/checks/integration.sh -Dtest='TestKeyDeletingService' -Dsurefire.rerunFailingTestsCount=5 -am -pl :ozone-manager
...
[INFO] Running org.apache.hadoop.ozone.om.service.TestKeyDeletingService
[INFO] Running org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Metrics
[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.32 s <<< FAILURE! -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Metrics
[ERROR] org.apache.hadoop.ozone.om.service.TestKeyDeletingService.testPurgeKeysRequestBatching -- Time elapsed: 13.74 s <<< FAILURE!
AssertionFailedError: Total keys purged across all batches should match initial keys deleted. ==> expected: <50> but was: <49>
...
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:563)
at org.apache.hadoop.ozone.om.service.TestKeyDeletingService.testPurgeKeysRequestBatching(TestKeyDeletingService.java:1171)
...
[INFO] Running org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Failing
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.71 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Failing
[INFO] Running org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Normal
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.88 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Normal
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 72.72 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService
[INFO] Running org.apache.hadoop.ozone.om.service.TestKeyDeletingService
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.10 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService
[INFO]
[INFO] Results:
[INFO]
[WARNING] Flakes:
[WARNING] org.apache.hadoop.ozone.om.service.TestKeyDeletingService.testPurgeKeysRequestBatching
[ERROR] Run 1: TestKeyDeletingService.testPurgeKeysRequestBatching:1171 Total keys purged across all batches should match initial keys deleted. ==> expected: <50> but was: <49>
[INFO] Run 2: PASS
[INFO]
[INFO]
[WARNING] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Flakes: 1
...
org.apache.hadoop.ozone.om.service.TestKeyDeletingService$Metrics
$ cat target/integration/failures
1
```
After:
```bash
$ ./hadoop-ozone/dev-support/checks/integration.sh -Dtest='TestKeyDeletingService' -Dsurefire.rerunFailingTestsCount=5 -am -pl :ozone-manager
...
[INFO] Running org.apache.hadoop.ozone.om.service.TestKeyDeletingService
[INFO] Running org.apache.hadoop.ozone.om.service.TestKeyDeletingService$RequestBatching
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.93 s <<< FAILURE! -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$RequestBatching
[ERROR] org.apache.hadoop.ozone.om.service.TestKeyDeletingService$RequestBatching.testPurgeKeysRequestBatching -- Time elapsed: 0.728 s <<< FAILURE!
AssertionFailedError: Total keys purged across all batches should match initial keys deleted. ==> expected: <50> but was: <49>
...
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:563)
at org.apache.hadoop.ozone.om.service.TestKeyDeletingService$RequestBatching.testPurgeKeysRequestBatching(TestKeyDeletingService.java:1190)
...
...
[INFO] Running org.apache.hadoop.ozone.om.service.TestKeyDeletingService
[INFO] Running org.apache.hadoop.ozone.om.service.TestKeyDeletingService$RequestBatching
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.14 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService$RequestBatching
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.15 s -- in org.apache.hadoop.ozone.om.service.TestKeyDeletingService
[INFO]
[INFO] Results:
[INFO]
[WARNING] Flakes:
[WARNING] org.apache.hadoop.ozone.om.service.TestKeyDeletingService$RequestBatching.testPurgeKeysRequestBatching
[ERROR] Run 1: TestKeyDeletingService$RequestBatching.testPurgeKeysRequestBatching:1190 Total keys purged across all batches should match initial keys deleted. ==> expected: <50> but was: <49>
[INFO] Run 2: PASS
[INFO]
[INFO]
[WARNING] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Flakes: 1
...
$ cat target/integration/failures
0
```
CI:
https://github.com/adoroszlai/ozone/actions/runs/19510123069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13959. Flaky check fails at testPurgeKeysRequestBatching despite passing repeated run [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #9329:
URL: https://github.com/apache/ozone/pull/9329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13959. Flaky check fails at testPurgeKeysRequestBatching despite passing repeated run [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9329:
URL: https://github.com/apache/ozone/pull/9329#issuecomment-3556009611
Thanks @aryangupta1998 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org