You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/19 00:31:20 UTC
[GitHub] [hbase] ndimiduk opened a new pull request #1183: HBASE-23767 WIP
do not merge
ndimiduk opened a new pull request #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183
Rebuild our Dockerfile with support for multiple JDK versions. Try to
use it with Github/precommit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592806640
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 0s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --jira-password --jira-user --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 2s | master passed |
| +1 :green_heart: | compile | 6m 19s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 41s | the patch passed |
| +1 :green_heart: | compile | 6m 26s | the patch passed |
| +1 :green_heart: | javac | 6m 26s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 2m 35s | root in the patch failed. |
| | | 37m 16s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac unit compile |
| uname | Linux 00d507b4aea1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a420f0482e |
| Default Java | 2020-01-14 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/testReport/ |
| Max. process+thread count | 483 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592816242
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 40s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 3s | master passed |
| +1 :green_heart: | compile | 3m 4s | master passed |
| +1 :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 53s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 36s | the patch passed |
| +1 :green_heart: | compile | 4m 24s | the patch passed |
| +1 :green_heart: | javac | 4m 24s | the patch passed |
| +1 :green_heart: | hadolint | 0m 1s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 6m 45s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 24m 25s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 4m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 71m 22s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac javadoc shadedjars hadoopcheck xml compile |
| uname | Linux 7d21902110f1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a420f0482e |
| Default Java | 1.8.0_232 |
| Max. process+thread count | 92 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592793291
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 4s | Docker mode activated. |
| -1 :x: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/52/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/52/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592763865
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/47/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593747752
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | hadolint | 0m 1s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 16m 27s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. |
| | | 23m 58s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs hadoopcheck xml |
| uname | Linux 9d3703753634 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c0301e3fdf |
| Max. process+thread count | 76 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594699176
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 21s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 23s | master passed |
| +1 :green_heart: | compile | 3m 52s | master passed |
| +1 :green_heart: | shadedjars | 5m 10s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 20s | root in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 8s | the patch passed |
| +1 :green_heart: | compile | 3m 54s | the patch passed |
| +1 :green_heart: | javac | 3m 54s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 20s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 50s | root in the patch failed. |
| | | 38m 37s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 262daa524b5b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6d9802fc2e |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/testReport/ |
| Max. process+thread count | 458 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1183:
HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#discussion_r387205463
##########
File path: dev-support/jenkins_precommit_github_yetus.sh
##########
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+# place ourselves in the directory containing the hbase and yetus checkouts
+cd "$(dirname "$0")/../.."
+echo "executing from $(pwd)"
+
+if [[ "true" = "${DEBUG}" ]]; then
+ set -x
+ printenv 2>&1 | sort
+fi
+
+declare -i missing_env=0
+declare -a required_envs=(
+ # these ENV variables define the required API with Jenkinsfile_GitHub
+ "ARCHIVE_PATTERN_LIST"
+ "BUILD_URL_ARTIFACTS"
+ "DOCKERFILE"
+ "GITHUB_PASSWORD"
+ "GITHUB_USER"
+ "PATCHDIR"
+ "PLUGINS"
+ "SET_JAVA_HOME"
+ "SOURCEDIR"
+ "TESTS_FILTER"
+ "YETUSDIR"
+)
+# Validate params
+for required_env in "${required_envs[@]}"; do
+ if [ -z "${!required_env}" ]; then
+ echo "[ERROR] Required environment variable '${required_env}' is not set."
+ missing_env=${missing_env}+1
+ fi
+done
+
+if [ ${missing_env} -gt 0 ]; then
+ echo "[ERROR] Please set the required environment variables before invoking. If this error is " \
+ "on Jenkins, then please file a JIRA about the error."
+ exit 1
+fi
+
+# TODO (HBASE-23900): cannot assume test-patch runs directly from sources
+TESTPATCHBIN="${YETUSDIR}/precommit/src/main/shell/test-patch.sh"
+
+# this must be clean for every run
+rm -rf "${PATCHDIR}"
+mkdir -p "${PATCHDIR}"
+
+# Checking on H* machine nonsense
+mkdir "${PATCHDIR}/machine"
+"${SOURCEDIR}/dev-support/gather_machine_environment.sh" "${PATCHDIR}/machine"
+
+# If CHANGE_URL is set (e.g., Github Branch Source plugin), process it.
+# Otherwise exit, because we don't want HBase to do a
+# full build. We wouldn't normally do this check for smaller
+# projects. :)
+if [[ -z "${CHANGE_URL}" ]]; then
+ echo "Full build skipped" > "${PATCHDIR}/report.html"
+ exit 0
+fi
+# enable debug output for yetus
+if [[ "true" = "${DEBUG}" ]]; then
+ YETUS_ARGS+=("--debug")
+fi
+# If we're doing docker, make sure we don't accidentally pollute the image with a host java path
+if [ -n "${JAVA_HOME}" ]; then
+ unset JAVA_HOME
+fi
+YETUS_ARGS+=("--ignore-unknown-options=true")
+YETUS_ARGS+=("--patch-dir=${PATCHDIR}")
+# where the source is located
+YETUS_ARGS+=("--basedir=${SOURCEDIR}")
+# our project defaults come from a personality file
+# which will get loaded automatically by setting the project name
+YETUS_ARGS+=("--project=hbase")
+# lots of different output formats
+YETUS_ARGS+=("--brief-report-file=${PATCHDIR}/brief.txt")
+YETUS_ARGS+=("--console-report-file=${PATCHDIR}/console.txt")
+YETUS_ARGS+=("--html-report-file=${PATCHDIR}/report.html")
+# enable writing back to Github
+YETUS_ARGS+=("--github-password=${GITHUB_PASSWORD}")
+YETUS_ARGS+=("--github-user=${GITHUB_USER}")
+# auto-kill any surefire stragglers during unit test runs
+YETUS_ARGS+=("--reapermode=kill")
+# set relatively high limits for ASF machines
+# changing these to higher values may cause problems
+# with other jobs on systemd-enabled machines
+YETUS_ARGS+=("--proclimit=10000")
+YETUS_ARGS+=("--dockermemlimit=20g")
+# -1 findbugs issues that show up prior to the patch being applied
+YETUS_ARGS+=("--findbugs-strict-precheck")
+# rsync these files back into the archive dir
+YETUS_ARGS+=("--archive-list=${ARCHIVE_PATTERN_LIST}")
+# URL for user-side presentation in reports and such to our artifacts
+YETUS_ARGS+=("--build-url-artifacts=${BUILD_URL_ARTIFACTS}")
+# plugins to enable
+YETUS_ARGS+=("--plugins=${PLUGINS}")
+# run in docker mode and specifically point to our
+# Dockerfile since we don't want to use the auto-pulled version.
+YETUS_ARGS+=("--docker")
+YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
+YETUS_ARGS+=("--mvn-custom-repos")
+YETUS_ARGS+=("--java-home=${SET_JAVA_HOME}")
+YETUS_ARGS+=("--whitespace-eol-ignore-list=.*/generated/.*")
+YETUS_ARGS+=("--whitespace-tabs-ignore-list=.*/generated/.*")
+YETUS_ARGS+=("--tests-filter=${TESTS_FILTER}")
+YETUS_ARGS+=("--personality=${SOURCEDIR}/dev-support/hbase-personality.sh")
Review comment:
we're going to keep getting the personality from the local source checkout instead of current master, looks like. getting this in line with nightly is a part of a follow on I think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593773322
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/59/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 Add JDK11
compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594046942
Alright @busbey @saintstack @Apache9 @jatsakthi this change is ready for review once more. I'll squish everything together before merge. The changes include:
1. rebuild the `Dockerfile` with support multiple JDK versions, with the two supported versions being JDK8 and JDK11, both from the AdoptOpenJDK project. (also more pedantic about the versions of the tools we install.)
1. Rebuild the Jenkinsfile into a multi-stage, parallel workflow. This (1) allows us to run the various batteries of tests in parallel and (2) lets us side-step a bug in yetus reporting of multijdk results.
1. Move the inline yetus invocation from the Jenkinsfile into a separate script. This supports re-use across the stages.
As you may note in the build-bot spam on this PR, with the move to multiple invocations of Yetus, we now get multiple post-backs onto the PR. As future work, I'd like to see these comments be replaced by use of the [Checks API](https://developer.github.com/v3/checks/). Maybe we could hack something up around each invocation of test-patch, but a better experience will require native [support from Yetus](https://issues.apache.org/jira/browse/YETUS-952).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592796320
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/55/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593702187
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | hadolint | 0m 3s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 16m 42s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| | | 24m 4s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs hadoopcheck xml |
| uname | Linux 1a23e1d91a57 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c0301e3fdf |
| Max. process+thread count | 76 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593778414
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593765344
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 37s | master passed |
| +1 :green_heart: | compile | 3m 6s | master passed |
| +1 :green_heart: | shadedjars | 4m 45s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 48s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 6s | the patch passed |
| +1 :green_heart: | compile | 3m 2s | the patch passed |
| +1 :green_heart: | javac | 3m 2s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 44s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 40s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 69m 42s | root in the patch failed. |
| | | 104m 37s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux e47c775ee753 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c0301e3fdf |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/testReport/ |
| Max. process+thread count | 8366 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594758807
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/62/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592792248
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/52/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1183:
HBASE-23767 WIP do not merge
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#discussion_r382363458
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -144,8 +143,9 @@ pipeline {
YETUS_ARGS+=("--docker")
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
YETUS_ARGS+=("--mvn-custom-repos")
- YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
- YETUS_ARGS+=("--findbugs-home=/usr")
+ YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8")
+ YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8")
Review comment:
I dunno about the PR checker, but for the jira handling job this analysis was correct. The branches-1 build relied on the fact that the docker image set Java home to jdk7.
Multijdk support deduplicates the list so having jdk8 for both home and here should result in a single detected jvm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592720997
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/40/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589460742
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/19/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592844090
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --jira-password --jira-user --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 9s | master passed |
| +1 :green_heart: | compile | 3m 4s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 22s | the patch passed |
| +1 :green_heart: | compile | 3m 14s | the patch passed |
| +1 :green_heart: | javac | 3m 14s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 130m 21s | root in the patch failed. |
| | | 148m 53s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac unit compile |
| uname | Linux b1e8ff53f1ff 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a420f0482e |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/testReport/ |
| Max. process+thread count | 9780 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593734072
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 31s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 33s | master passed |
| +1 :green_heart: | compile | 3m 7s | master passed |
| +1 :green_heart: | shadedjars | 4m 52s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 45s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 7s | the patch passed |
| +1 :green_heart: | compile | 3m 2s | the patch passed |
| +1 :green_heart: | javac | 3m 2s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 51s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 47s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 110m 59s | root in the patch failed. |
| | | 147m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux f473beb94ada 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c0301e3fdf |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/testReport/ |
| Max. process+thread count | 9906 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588578437
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 32s | master passed |
| +1 :green_heart: | compile | 3m 3s | master passed |
| +1 :green_heart: | shadedjars | 4m 53s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 58s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 5s | the patch passed |
| +1 :green_heart: | compile | 3m 7s | the patch passed |
| +1 :green_heart: | javac | 3m 7s | the patch passed |
| -1 :x: | hadolint | 0m 3s | The patch generated 23 new + 4 unchanged - 0 fixed = 27 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 43s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 8s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 2m 44s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 77m 4s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 40s | The patch does not generate ASF License warnings. |
| | | 138m 13s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/12/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux c71ed1eed9df 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 3168cf210c |
| Default Java | 1.8.0_232 |
| hadolint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/12/artifact/out/diff-patch-hadolint.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/12/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/12/testReport/ |
| Max. process+thread count | 8730 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/12/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593742257
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588026968
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/5/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592792255
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/52/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589408979
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/17/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1183:
HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#discussion_r385849563
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -47,122 +49,157 @@ pipeline {
}
stages {
- stage ('install yetus') {
+ stage ('scm checkouts') {
steps {
+ echo "scm checkout WORKSPACE: ${WORKSPACE}"
+ dir("${WORKSPACE}/${SOURCEDIR}") {
+ checkout scm
+ }
dir("${WORKSPACE}/${YETUS}") {
checkout([
- $class: 'GitSCM',
- branches: [[name: "${env.YETUS_VERSION}"]],
- userRemoteConfigs: [[ url: 'https://github.com/apache/yetus.git']]]
+ $class: 'GitSCM',
+ branches: [[name: "${env.YETUS_VERSION}"]],
Review comment:
ugh. how have I never noticed this in the github handling.
I'll file a follow-on to stop doing this. we should be consuming the artifacts of other projects not hooking into their git repos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593784431
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 10s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | hadolint | 0m 1s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 16m 25s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. |
| | | 24m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs hadoopcheck xml |
| uname | Linux 07b8571b7e20 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c0301e3fdf |
| Max. process+thread count | 76 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593778440
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 WIP do not
merge
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589884011
Before this can be merged, the other jobs that depend on the Dockerfile will need to be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592798570
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588542634
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/12/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588448002
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 5s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 7s | master passed |
| +1 :green_heart: | compile | 3m 36s | master passed |
| +1 :green_heart: | shadedjars | 4m 54s | branch has no errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 19s | root in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 46s | the patch passed |
| +1 :green_heart: | compile | 3m 37s | the patch passed |
| +1 :green_heart: | javac | 3m 37s | the patch passed |
| -1 :x: | hadolint | 0m 2s | The patch generated 24 new + 2 unchanged - 2 fixed = 26 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 19s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 57s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| -1 :x: | javadoc | 0m 17s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 34s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 58m 57s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.util.TestFutureUtils |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/8/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 1f75729e7b52 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 53afc1dc10 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/8/artifact/out/branch-javadoc-root.txt |
| hadolint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/8/artifact/out/diff-patch-hadolint.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/8/artifact/out/patch-javadoc-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/8/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/8/testReport/ |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/8/console |
| versions | git=2.24.1 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-587984396
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/3/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592707161
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/37/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1183:
HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#discussion_r382868840
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -144,8 +143,9 @@ pipeline {
YETUS_ARGS+=("--docker")
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
YETUS_ARGS+=("--mvn-custom-repos")
- YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
- YETUS_ARGS+=("--findbugs-home=/usr")
+ YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8")
+ YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8")
Review comment:
Okay, this was a bit of learning out loud.
My longer-term goal is to converge the Jenkinsfiles/Dockerfiles across branches. Thus the image will ship with multiple JDKs and the jobs will need to manage `JAVA_HOME` the Jenkinsfile instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589906501
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 2s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 42s | master passed |
| +1 :green_heart: | compile | 3m 48s | master passed with JDK v2020-01-14 |
| +1 :green_heart: | compile | 4m 53s | master passed with JDK v1.8.0_232 |
| +1 :green_heart: | shadedjars | 5m 15s | branch has no errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 22s | root in master failed with JDK v2020-01-14. |
| +1 :green_heart: | javadoc | 3m 1s | master passed with JDK v1.8.0_232 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 31s | the patch passed |
| +1 :green_heart: | compile | 3m 42s | the patch passed with JDK v2020-01-14 |
| +1 :green_heart: | javac | 3m 42s | the patch passed |
| +1 :green_heart: | compile | 3m 3s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 3m 3s | the patch passed |
| +1 :green_heart: | hadolint | 0m 2s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 45s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 8s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| -1 :x: | javadoc | 0m 20s | root in the patch failed with JDK v2020-01-14. |
| +1 :green_heart: | javadoc | 2m 47s | the patch passed with JDK v1.8.0_232 |
||| _ Other Tests _ |
| -1 :x: | unit | 70m 48s | root in the patch failed with JDK v1.8.0_232. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 142m 39s | |
| Reason | Tests |
|-------:|:------|
| JDK v2020-01-14 Failed junit tests | hadoop.hbase.util.TestFutureUtils |
| JDK v1.8.0_232 Failed junit tests | hadoop.hbase.security.token.TestZKSecretWatcher |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 313d2fa800b5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 400b7ce954 |
| Default Java | 1.8.0_232 |
| Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:2020-01-14 /usr/lib/jvm/jdk8u232-b09:1.8.0_232 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/artifact/out/branch-javadoc-root-jdk2020-01-14.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/artifact/out/patch-javadoc-root-jdk2020-01-14.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/artifact/out/patch-unit-root-jdk1.8.0_232.txt |
| JDK v1.8.0_232 Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/testReport/ |
| Max. process+thread count | 8777 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592792253
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/52/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593787225
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 43s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 22s | master passed |
| +1 :green_heart: | compile | 3m 51s | master passed |
| +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 19s | root in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 11s | the patch passed |
| +1 :green_heart: | compile | 3m 53s | the patch passed |
| +1 :green_heart: | javac | 3m 53s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 3s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 19s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 58s | root in the patch failed. |
| | | 35m 3s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4113076af2e0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c0301e3fdf |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/testReport/ |
| Max. process+thread count | 473 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588348901
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/6/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588368865
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/7/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593773323
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/59/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592776432
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/49/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592789172
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/51/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592713894
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/39/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592709015
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/38/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593742254
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-587988837
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/4/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588495221
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| -1 :x: | pre-patch | 0m 0s | JAVA_HOME is not defined. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/11/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux e9a2627bf266 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 53afc1dc10 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/11/console |
| versions | git=2.24.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592787423
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/50/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589410291
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/18/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594759698
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | hadolint | 0m 2s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| | | 2m 0s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/62/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs |
| uname | Linux c06f99579635 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b6eefcaeb7 |
| Max. process+thread count | 47 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/62/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594670417
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589501678
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 11s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 57s | master passed |
| +1 :green_heart: | compile | 4m 0s | master passed with JDK AdoptOpenJDK-11.0.6+10 |
| +1 :green_heart: | compile | 3m 22s | master passed with JDK AdoptOpenJDK-1.8.0_232-b09 |
| +1 :green_heart: | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 20s | root in master failed with JDK AdoptOpenJDK-11.0.6+10. |
| +1 :green_heart: | javadoc | 2m 49s | master passed with JDK AdoptOpenJDK-1.8.0_232-b09 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 39s | the patch passed |
| +1 :green_heart: | compile | 4m 20s | the patch passed with JDK AdoptOpenJDK-11.0.6+10 |
| +1 :green_heart: | javac | 4m 20s | the patch passed |
| +1 :green_heart: | compile | 3m 21s | the patch passed with JDK AdoptOpenJDK-1.8.0_232-b09 |
| +1 :green_heart: | javac | 3m 21s | the patch passed |
| +1 :green_heart: | hadolint | 0m 2s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 32s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| -1 :x: | javadoc | 0m 19s | root in the patch failed with JDK AdoptOpenJDK-11.0.6+10. |
| +1 :green_heart: | javadoc | 2m 51s | the patch passed with JDK AdoptOpenJDK-1.8.0_232-b09 |
||| _ Other Tests _ |
| -1 :x: | unit | 128m 22s | root in the patch failed with JDK AdoptOpenJDK-1.8.0_232-b09. |
| +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. |
| | | 199m 27s | |
| Reason | Tests |
|-------:|:------|
| JDK AdoptOpenJDK-11.0.6+10 Failed junit tests | hadoop.hbase.util.TestFutureUtils |
| JDK AdoptOpenJDK-1.8.0_232-b09 Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotV1NoCluster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/19/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 75c24b58cba0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / fe0d49bc52 |
| Default Java | AdoptOpenJDK-1.8.0_232-b09 |
| Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:AdoptOpenJDK-11.0.6+10 /usr/lib/jvm/jdk8u232-b09:AdoptOpenJDK-1.8.0_232-b09 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/19/artifact/out/branch-javadoc-root-jdkAdoptOpenJDK-11.0.6+10.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/19/artifact/out/patch-javadoc-root-jdkAdoptOpenJDK-11.0.6+10.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/19/artifact/out/patch-unit-root-jdkAdoptOpenJDK-1.8.0_232-b09.txt |
| JDK AdoptOpenJDK-1.8.0_232-b09 Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/19/testReport/ |
| Max. process+thread count | 6613 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/19/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592742859
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/45/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593691239
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588493892
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/11/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-587981510
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/2/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #1183: HBASE-23767 Add JDK11
compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594057336
I think this is the JDK11 build?
```
Default Java | 2020-01-14
-- | --
```
this is YETUS-943 right, so it'll give a JDK 11 version string once that's in place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594758815
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/62/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 Add JDK11
compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594071345
> I think this is the JDK11 build?
>
> ```
> Default Java | 2020-01-14
> -- | --
> ```
>
> this is YETUS-943 right, so it'll give a JDK 11 version string once that's in place?
Correct, without YETUS-943, we get JDK11 reported as it's date. Same for the maven version, in the absence of YETUS-944.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1183:
HBASE-23767 WIP do not merge
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#discussion_r381625962
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -144,8 +143,9 @@ pipeline {
YETUS_ARGS+=("--docker")
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
YETUS_ARGS+=("--mvn-custom-repos")
- YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
- YETUS_ARGS+=("--findbugs-home=/usr")
+ YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8")
+ YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8")
Review comment:
Why do we even specify `--multijdkdirs` ? The different JDK handling is managed at the level of the `Jenkinsfile` pipeline, not within Yetus.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1183:
HBASE-23767 WIP do not merge
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#discussion_r381629704
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -144,8 +143,9 @@ pipeline {
YETUS_ARGS+=("--docker")
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
YETUS_ARGS+=("--mvn-custom-repos")
- YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
- YETUS_ARGS+=("--findbugs-home=/usr")
+ YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8")
+ YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8")
Review comment:
But, for instance, `branch-1` has it's own `Dockerfile` and it's own `Jenkinsfile_GitHub` where it *does* make use of `multijdkdirs`. So that's vestigial.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592787014
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 33s | master passed |
| +1 :green_heart: | compile | 3m 1s | master passed |
| +1 :green_heart: | shadedjars | 4m 43s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 47s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 7s | the patch passed |
| +1 :green_heart: | compile | 3m 4s | the patch passed |
| +1 :green_heart: | javac | 3m 4s | the patch passed |
| +1 :green_heart: | hadolint | 0m 2s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 43s | patch has no errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 8m 10s | The patch causes 7 errors with Hadoop v2.9.2. |
| -1 :x: | hadoopcheck | 8m 43s | The patch causes 7 errors with Hadoop v3.1.2. |
| +1 :green_heart: | javadoc | 3m 25s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 43m 18s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/49/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac javadoc shadedjars hadoopcheck xml compile |
| uname | Linux 5f85f798a989 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a420f0482e |
| Default Java | 1.8.0_232 |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/49/artifact/out/patch-javac-2.9.2.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/49/artifact/out/patch-javac-3.1.2.txt |
| Max. process+thread count | 92 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/49/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592741506
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/44/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594756433
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 21s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 32s | master passed |
| +1 :green_heart: | compile | 3m 6s | master passed |
| +1 :green_heart: | shadedjars | 4m 49s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 48s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 59s | the patch passed |
| +1 :green_heart: | compile | 3m 3s | the patch passed |
| +1 :green_heart: | javac | 3m 3s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 46s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 48s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 73m 55s | root in the patch failed. |
| | | 112m 36s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux ce1ad6ed2c5c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6d9802fc2e |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/testReport/ |
| Max. process+thread count | 9325 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk closed pull request #1183: HBASE-23767 Add JDK11
compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
ndimiduk closed pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 Add JDK11
compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-591718740
@busbey all of your comments on #1195 apply to this PR, so pushed the fixes here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593778441
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588612407
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 39s | master passed |
| +1 :green_heart: | compile | 3m 37s | master passed with JDK v2020-01-14 |
| +1 :green_heart: | compile | 2m 59s | master passed with JDK v1.8.0_232 |
| +1 :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 21s | root in master failed with JDK v2020-01-14. |
| +1 :green_heart: | javadoc | 2m 44s | master passed with JDK v1.8.0_232 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 5s | the patch passed |
| +1 :green_heart: | compile | 3m 40s | the patch passed with JDK v2020-01-14 |
| +1 :green_heart: | javac | 3m 40s | the patch passed |
| +1 :green_heart: | compile | 3m 3s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 3m 3s | the patch passed |
| -1 :x: | hadolint | 0m 1s | The patch generated 23 new + 4 unchanged - 0 fixed = 27 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 44s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 28s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| -1 :x: | javadoc | 0m 18s | root in the patch failed with JDK v2020-01-14. |
| +1 :green_heart: | javadoc | 2m 56s | the patch passed with JDK v1.8.0_232 |
||| _ Other Tests _ |
| -1 :x: | unit | 85m 3s | root in the patch failed with JDK v1.8.0_232. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. |
| | | 154m 34s | |
| Reason | Tests |
|-------:|:------|
| JDK v2020-01-14 Failed junit tests | hadoop.hbase.util.TestFutureUtils |
| JDK v1.8.0_232 Failed junit tests | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
| | hadoop.hbase.tool.TestBulkLoadHFiles |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/13/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 29ba02f6e60b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 3168cf210c |
| Default Java | 1.8.0_232 |
| Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:2020-01-14 /usr/lib/jvm/jdk8u232-b09:1.8.0_232 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/13/artifact/out/branch-javadoc-root-jdk2020-01-14.txt |
| hadolint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/13/artifact/out/diff-patch-hadolint.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/13/artifact/out/patch-javadoc-root-jdk2020-01-14.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/13/artifact/out/patch-unit-root-jdk1.8.0_232.txt |
| JDK v1.8.0_232 Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/13/testReport/ |
| Max. process+thread count | 8914 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/13/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 Add JDK11
compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592798552
@busbey Okay at this point the 3 tests stages are running. I have not yet started into artifact aggregation, so that will come next. I'm also not sure I have selected an appropriate list of plugins for each stage -- some direction there would be appreciated. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] jatsakthi commented on issue #1183: HBASE-23767 Add JDK11
compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
jatsakthi commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589884570
Thanks for taking up this one @ndimiduk the results look great. Will review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1183: HBASE-23767 WIP do not
merge
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589883543
Okay, this patch looks ready. The bit where I tickle the pom.xml will be removed before final commit. For an example of the results, see https://github.com/apache/hbase/pull/1183#issuecomment-589501678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-587977337
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 3m 39s | Docker mode activated. |
| -1 :x: | yetus | 0m 3s | Unprocessed flag(s): --findbugs-strict-precheck --findbugs-home |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/1/console |
| versions | git=2.24.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592798624
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-591778124
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 13s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 8s | master passed |
| +1 :green_heart: | compile | 5m 7s | master passed with JDK v2020-01-14 |
| +1 :green_heart: | compile | 3m 34s | master passed with JDK v1.8.0_232 |
| +1 :green_heart: | shadedjars | 5m 24s | branch has no errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 20s | root in master failed with JDK v2020-01-14. |
| +1 :green_heart: | javadoc | 2m 57s | master passed with JDK v1.8.0_232 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 39s | the patch passed |
| +1 :green_heart: | compile | 4m 51s | the patch passed with JDK v2020-01-14 |
| +1 :green_heart: | javac | 4m 51s | the patch passed |
| +1 :green_heart: | compile | 3m 55s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 3m 55s | the patch passed |
| +1 :green_heart: | hadolint | 0m 1s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 3s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 43s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 20m 10s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| -1 :x: | javadoc | 0m 21s | root in the patch failed with JDK v2020-01-14. |
| +1 :green_heart: | javadoc | 3m 26s | the patch passed with JDK v1.8.0_232 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 152m 9s | root in the patch passed with JDK v1.8.0_232. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 234m 20s | |
| Reason | Tests |
|-------:|:------|
| JDK v2020-01-14 Failed junit tests | hadoop.hbase.util.TestFutureUtils |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/21/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 382a9b973a60 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 3c3aae9a2f |
| Default Java | 1.8.0_232 |
| Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:2020-01-14 /usr/lib/jvm/jdk8u232-b09:1.8.0_232 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/21/artifact/out/branch-javadoc-root-jdk2020-01-14.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/21/artifact/out/patch-javadoc-root-jdk2020-01-14.txt |
| JDK v1.8.0_232 Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/21/testReport/ |
| Max. process+thread count | 6385 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/21/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588413618
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/8/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593817778
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 43s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 7s | master passed |
| +1 :green_heart: | compile | 3m 2s | master passed |
| +1 :green_heart: | shadedjars | 4m 46s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 48s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 7s | the patch passed |
| +1 :green_heart: | compile | 3m 4s | the patch passed |
| +1 :green_heart: | javac | 3m 4s | the patch passed |
| +1 :green_heart: | shadedjars | 4m 47s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 48s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 102m 43s | root in the patch failed. |
| | | 138m 4s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4a56cb63af14 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c0301e3fdf |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/testReport/ |
| Max. process+thread count | 9889 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/60/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1183:
HBASE-23767 WIP do not merge
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#discussion_r381627452
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -144,8 +143,9 @@ pipeline {
YETUS_ARGS+=("--docker")
YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
YETUS_ARGS+=("--mvn-custom-repos")
- YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64")
- YETUS_ARGS+=("--findbugs-home=/usr")
+ YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8")
+ YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8")
Review comment:
Unless the JDK7 builds are silently depending on this? It does look like they install jdk7 and explicitly set `JAVA_HOME` pointed there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589405900
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 2m 33s | Docker failed to build yetus/hbase:1cb4f687c1. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/15/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592749627
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/46/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592730789
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/42/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588026591
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 16s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 56s | master passed |
| +1 :green_heart: | compile | 3m 17s | master passed |
| +1 :green_heart: | shadedjars | 5m 3s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 50s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 30s | the patch passed |
| +1 :green_heart: | compile | 3m 19s | the patch passed |
| +1 :green_heart: | javac | 3m 19s | the patch passed |
| +1 :green_heart: | hadolint | 0m 1s | There were no new hadolint issues. |
| +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 50s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 3m 19s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 106m 2s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. |
| | | 166m 55s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.replication.TestReplicationSmallTestsSync |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux d4b8f5e6a200 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 86e76c2bd9 |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/4/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/4/testReport/ |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/4/console |
| versions | git=2.24.1 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-587982596
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 13s | Docker mode activated. |
| -1 :x: | yetus | 0m 4s | Unprocessed flag(s): --findbugs-strict-precheck --findbugs-home |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/2/console |
| versions | git=2.24.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-587984665
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 9s | Docker mode activated. |
| -1 :x: | yetus | 0m 4s | Unprocessed flag(s): --findbugs-strict-precheck --findbugs-home |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/3/console |
| versions | git=2.24.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588412708
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 53s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 35s | master passed |
| +1 :green_heart: | compile | 5m 43s | master passed |
| +1 :green_heart: | shadedjars | 7m 44s | branch has no errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 27s | root in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 9m 23s | the patch passed |
| +1 :green_heart: | compile | 5m 47s | the patch passed |
| +1 :green_heart: | javac | 5m 47s | the patch passed |
| +1 :green_heart: | hadolint | 0m 3s | There were no new hadolint issues. |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 7m 35s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 27m 31s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| -1 :x: | javadoc | 0m 16s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 35s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 84m 37s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.util.TestFutureUtils |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/7/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux e7f232065d99 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 53afc1dc10 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/7/artifact/out/branch-javadoc-root.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/7/artifact/out/patch-javadoc-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/7/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/7/testReport/ |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/7/console |
| versions | git=2.24.1 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1183:
HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#discussion_r385977964
##########
File path: dev-support/Jenkinsfile_GitHub
##########
@@ -47,122 +49,157 @@ pipeline {
}
stages {
- stage ('install yetus') {
+ stage ('scm checkouts') {
steps {
+ echo "scm checkout WORKSPACE: ${WORKSPACE}"
+ dir("${WORKSPACE}/${SOURCEDIR}") {
+ checkout scm
+ }
dir("${WORKSPACE}/${YETUS}") {
checkout([
- $class: 'GitSCM',
- branches: [[name: "${env.YETUS_VERSION}"]],
- userRemoteConfigs: [[ url: 'https://github.com/apache/yetus.git']]]
+ $class: 'GitSCM',
+ branches: [[name: "${env.YETUS_VERSION}"]],
Review comment:
I'd like to extract the logic for grabbing either a released tarball or building a specified ref into a script that can be shared between the jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594758859
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/62/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592792409
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -1 :x: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/52/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/52/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588055687
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 37s | master passed |
| +1 :green_heart: | compile | 3m 0s | master passed |
| +1 :green_heart: | shadedjars | 4m 35s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 46s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 57s | the patch passed |
| +1 :green_heart: | compile | 3m 7s | the patch passed |
| +1 :green_heart: | javac | 3m 7s | the patch passed |
| +1 :green_heart: | hadolint | 0m 1s | There were no new hadolint issues. |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 35s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 2m 42s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 68m 51s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. |
| | | 123m 53s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.client.TestAsyncTableGetMultiThreaded |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 84f5a00683ba 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 86e76c2bd9 |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/5/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/5/testReport/ |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/5/console |
| versions | git=2.24.1 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1183:
HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#discussion_r387749537
##########
File path: dev-support/jenkins_precommit_github_yetus.sh
##########
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+# place ourselves in the directory containing the hbase and yetus checkouts
+cd "$(dirname "$0")/../.."
+echo "executing from $(pwd)"
+
+if [[ "true" = "${DEBUG}" ]]; then
+ set -x
+ printenv 2>&1 | sort
+fi
+
+declare -i missing_env=0
+declare -a required_envs=(
+ # these ENV variables define the required API with Jenkinsfile_GitHub
+ "ARCHIVE_PATTERN_LIST"
+ "BUILD_URL_ARTIFACTS"
+ "DOCKERFILE"
+ "GITHUB_PASSWORD"
+ "GITHUB_USER"
+ "PATCHDIR"
+ "PLUGINS"
+ "SET_JAVA_HOME"
+ "SOURCEDIR"
+ "TESTS_FILTER"
+ "YETUSDIR"
+)
+# Validate params
+for required_env in "${required_envs[@]}"; do
+ if [ -z "${!required_env}" ]; then
+ echo "[ERROR] Required environment variable '${required_env}' is not set."
+ missing_env=${missing_env}+1
+ fi
+done
+
+if [ ${missing_env} -gt 0 ]; then
+ echo "[ERROR] Please set the required environment variables before invoking. If this error is " \
+ "on Jenkins, then please file a JIRA about the error."
+ exit 1
+fi
+
+# TODO (HBASE-23900): cannot assume test-patch runs directly from sources
+TESTPATCHBIN="${YETUSDIR}/precommit/src/main/shell/test-patch.sh"
+
+# this must be clean for every run
+rm -rf "${PATCHDIR}"
+mkdir -p "${PATCHDIR}"
+
+# Checking on H* machine nonsense
+mkdir "${PATCHDIR}/machine"
+"${SOURCEDIR}/dev-support/gather_machine_environment.sh" "${PATCHDIR}/machine"
+
+# If CHANGE_URL is set (e.g., Github Branch Source plugin), process it.
+# Otherwise exit, because we don't want HBase to do a
+# full build. We wouldn't normally do this check for smaller
+# projects. :)
+if [[ -z "${CHANGE_URL}" ]]; then
+ echo "Full build skipped" > "${PATCHDIR}/report.html"
+ exit 0
+fi
+# enable debug output for yetus
+if [[ "true" = "${DEBUG}" ]]; then
+ YETUS_ARGS+=("--debug")
+fi
+# If we're doing docker, make sure we don't accidentally pollute the image with a host java path
+if [ -n "${JAVA_HOME}" ]; then
+ unset JAVA_HOME
+fi
+YETUS_ARGS+=("--ignore-unknown-options=true")
+YETUS_ARGS+=("--patch-dir=${PATCHDIR}")
+# where the source is located
+YETUS_ARGS+=("--basedir=${SOURCEDIR}")
+# our project defaults come from a personality file
+# which will get loaded automatically by setting the project name
+YETUS_ARGS+=("--project=hbase")
+# lots of different output formats
+YETUS_ARGS+=("--brief-report-file=${PATCHDIR}/brief.txt")
+YETUS_ARGS+=("--console-report-file=${PATCHDIR}/console.txt")
+YETUS_ARGS+=("--html-report-file=${PATCHDIR}/report.html")
+# enable writing back to Github
+YETUS_ARGS+=("--github-password=${GITHUB_PASSWORD}")
+YETUS_ARGS+=("--github-user=${GITHUB_USER}")
+# auto-kill any surefire stragglers during unit test runs
+YETUS_ARGS+=("--reapermode=kill")
+# set relatively high limits for ASF machines
+# changing these to higher values may cause problems
+# with other jobs on systemd-enabled machines
+YETUS_ARGS+=("--proclimit=10000")
+YETUS_ARGS+=("--dockermemlimit=20g")
+# -1 findbugs issues that show up prior to the patch being applied
+YETUS_ARGS+=("--findbugs-strict-precheck")
+# rsync these files back into the archive dir
+YETUS_ARGS+=("--archive-list=${ARCHIVE_PATTERN_LIST}")
+# URL for user-side presentation in reports and such to our artifacts
+YETUS_ARGS+=("--build-url-artifacts=${BUILD_URL_ARTIFACTS}")
+# plugins to enable
+YETUS_ARGS+=("--plugins=${PLUGINS}")
+# run in docker mode and specifically point to our
+# Dockerfile since we don't want to use the auto-pulled version.
+YETUS_ARGS+=("--docker")
+YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
+YETUS_ARGS+=("--mvn-custom-repos")
+YETUS_ARGS+=("--java-home=${SET_JAVA_HOME}")
+YETUS_ARGS+=("--whitespace-eol-ignore-list=.*/generated/.*")
+YETUS_ARGS+=("--whitespace-tabs-ignore-list=.*/generated/.*")
+YETUS_ARGS+=("--tests-filter=${TESTS_FILTER}")
+YETUS_ARGS+=("--personality=${SOURCEDIR}/dev-support/hbase-personality.sh")
Review comment:
> It's probably worth a heads up to dev@ about this landing soon since it'll significantly change what the QA bot chatter on PRs looks like.
Yes, I will send a heads-up to the dev list. My plan is to land this one and HBASE-23876/#1195 simultaneously, since they depend on the same Dockerfiles changes. Now that the dust has settled over here, I will take one more look at the Jira PreCommit job, see if its worth retaining.
> we're going to keep getting the personality from the local source checkout instead of current master, looks like. getting this in line with nightly is a part of a follow on I think?
This is the behavior that was here when I arrived. There's a couple features from the nightlies job that we probably want to do here as well
1. pull personality from master
2. ability to pull Yetus from an arbitrary repo or arbitrary ref
3. run ErrorProne
For (1), I'm not sure if it's better to always use the script from master or always keep things branch-specific. For (2), I think we want it here so that we can easily test our Yetus patches and kick the tires on new Yetus release candidates. For (3), I think Duo disabled this but I'm not clear on why. It still runs in nightly, so I assume it's not broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589884666
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/20/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588350304
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 6s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch |
| +1 :green_heart: | hadolint | 0m 1s | There were no new hadolint issues. |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 3m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/6/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint |
| uname | Linux f826632bf62f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / 53afc1dc10 |
| modules | C: U: |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/6/console |
| versions | git=2.24.1 maven=2018-06-17T18:33:14Z) shellcheck=0.7.0 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-588578884
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/13/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592702049
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/36/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593773312
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/59/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594687994
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | hadolint | 0m 1s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 16m 18s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. |
| | | 23m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense hadolint shellcheck shelldocs hadoopcheck xml |
| uname | Linux 59976bb1ca8f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6d9802fc2e |
| Max. process+thread count | 76 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592730236
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 3m 52s | Docker failed to build run-specific yetus/hbase:tp-16943}. |
| Subsystem | Report/Notes |
|----------:|:-------------|
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/41/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592798577
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/56/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589460392
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 37s | master passed |
| +1 :green_heart: | compile | 3m 37s | master passed with JDK AdoptOpenJDK 11.0.6+10 |
| +1 :green_heart: | compile | 3m 3s | master passed with JDK AdoptOpenJDK 1.8.0_232-b09 |
| +1 :green_heart: | shadedjars | 4m 43s | branch has no errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 23s | root in master failed with JDK vAdoptOpenJDK 11.0.6+10. |
| +1 :green_heart: | javadoc | 2m 49s | master passed with JDK AdoptOpenJDK 1.8.0_232-b09 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 5s | the patch passed |
| +1 :green_heart: | compile | 3m 37s | the patch passed with JDK AdoptOpenJDK 11.0.6+10 |
| +1 :green_heart: | javac | 3m 37s | the patch passed |
| +1 :green_heart: | compile | 3m 5s | the patch passed with JDK AdoptOpenJDK 1.8.0_232-b09 |
| +1 :green_heart: | javac | 3m 5s | the patch passed |
| +1 :green_heart: | hadolint | 0m 2s | The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 4m 50s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 16m 2s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| -1 :x: | javadoc | 0m 21s | root in the patch failed with JDK vAdoptOpenJDK 11.0.6+10. |
| +1 :green_heart: | javadoc | 2m 47s | the patch passed with JDK AdoptOpenJDK 1.8.0_232-b09 |
||| _ Other Tests _ |
| -1 :x: | unit | 71m 52s | root in the patch failed with JDK vAdoptOpenJDK 1.8.0_232-b09. |
| +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. |
| | | 137m 11s | |
| Reason | Tests |
|-------:|:------|
| JDK vAdoptOpenJDK 11.0.6+10 Failed junit tests | hadoop.hbase.util.TestFutureUtils |
| JDK vAdoptOpenJDK 1.8.0_232-b09 Failed junit tests | hadoop.hbase.replication.TestReplicationKillMasterRS |
| | hadoop.hbase.replication.TestSyncReplicationRemoveRemoteWAL |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/18/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 3f40963685df 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / fe0d49bc52 |
| Default Java | AdoptOpenJDK 1.8.0_232-b09 |
| Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:AdoptOpenJDK 11.0.6+10 /usr/lib/jvm/jdk8u232-b09:AdoptOpenJDK 1.8.0_232-b09 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/18/artifact/out/branch-javadoc-root-jdkAdoptOpenJDK11.0.6+10.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/18/artifact/out/patch-javadoc-root-jdkAdoptOpenJDK11.0.6+10.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/18/artifact/out/patch-unit-root-jdkAdoptOpenJDK1.8.0_232-b09.txt |
| JDK vAdoptOpenJDK 1.8.0_232-b09 Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/18/testReport/ |
| Max. process+thread count | 9858 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/18/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593742362
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592728568
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/41/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592796322
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/55/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589406585
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/16/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594759453
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 1m 43s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/62/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | |
| uname | Linux 5dee692368f8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b6eefcaeb7 |
| Max. process+thread count | 55 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/62/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593691238
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593705711
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 57s | master passed |
| +1 :green_heart: | compile | 4m 1s | master passed |
| +1 :green_heart: | shadedjars | 5m 27s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 23s | root in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 23s | the patch passed |
| +1 :green_heart: | compile | 4m 4s | the patch passed |
| +1 :green_heart: | javac | 4m 4s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 19s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 59s | root in the patch failed. |
| | | 37m 33s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 6a4fdc0799cd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c0301e3fdf |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/branch-javadoc-root.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/patch-javadoc-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/artifact/out/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/testReport/ |
| Max. process+thread count | 460 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589404955
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/15/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589274880
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 4s | master passed |
| +1 :green_heart: | compile | 4m 7s | master passed with JDK v2020-01-14 |
| +1 :green_heart: | compile | 3m 26s | master passed with JDK v1.8.0_232 |
| +1 :green_heart: | shadedjars | 5m 4s | branch has no errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 20s | root in master failed with JDK v2020-01-14. |
| +1 :green_heart: | javadoc | 2m 50s | master passed with JDK v1.8.0_232 |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 26s | the patch passed |
| +1 :green_heart: | compile | 4m 20s | the patch passed with JDK v2020-01-14 |
| +1 :green_heart: | javac | 4m 20s | the patch passed |
| +1 :green_heart: | compile | 3m 50s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 3m 50s | the patch passed |
| -1 :x: | hadolint | 0m 1s | The patch generated 23 new + 4 unchanged - 0 fixed = 27 total (was 4) |
| +1 :green_heart: | shellcheck | 0m 1s | There were no new shellcheck issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedjars | 5m 40s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 18m 2s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| -1 :x: | javadoc | 0m 19s | root in the patch failed with JDK v2020-01-14. |
| +1 :green_heart: | javadoc | 2m 50s | the patch passed with JDK v1.8.0_232 |
||| _ Other Tests _ |
| -1 :x: | unit | 128m 10s | root in the patch failed with JDK v1.8.0_232. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 207m 14s | |
| Reason | Tests |
|-------:|:------|
| JDK v2020-01-14 Failed junit tests | hadoop.hbase.util.TestFutureUtils |
| JDK v1.8.0_232 Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotV2NoCluster |
| | hadoop.hbase.snapshot.TestExportSnapshotV1NoCluster |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/14/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile |
| uname | Linux 3daac9f434f2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1183/out/precommit/personality/provided.sh |
| git revision | master / fe0d49bc52 |
| Default Java | 1.8.0_232 |
| Multi-JDK versions | /usr/lib/jvm/jdk-11.0.6+10:2020-01-14 /usr/lib/jvm/jdk8u232-b09:1.8.0_232 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/14/artifact/out/branch-javadoc-root-jdk2020-01-14.txt |
| hadolint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/14/artifact/out/diff-patch-hadolint.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/14/artifact/out/patch-javadoc-root-jdk2020-01-14.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/14/artifact/out/patch-unit-root-jdk1.8.0_232.txt |
| JDK v1.8.0_232 Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/14/testReport/ |
| Max. process+thread count | 6699 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/14/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 hadolint=1.17.5-0-g443423c |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-592796345
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/55/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-589163883
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/14/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1183:
HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#discussion_r387203387
##########
File path: dev-support/jenkins_precommit_github_yetus.sh
##########
@@ -0,0 +1,144 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+# place ourselves in the directory containing the hbase and yetus checkouts
+cd "$(dirname "$0")/../.."
+echo "executing from $(pwd)"
+
+if [[ "true" = "${DEBUG}" ]]; then
+ set -x
+ printenv 2>&1 | sort
+fi
+
+declare -i missing_env=0
+declare -a required_envs=(
+ # these ENV variables define the required API with Jenkinsfile_GitHub
+ "ARCHIVE_PATTERN_LIST"
+ "BUILD_URL_ARTIFACTS"
+ "DOCKERFILE"
+ "GITHUB_PASSWORD"
+ "GITHUB_USER"
+ "PATCHDIR"
+ "PLUGINS"
+ "SET_JAVA_HOME"
+ "SOURCEDIR"
+ "TESTS_FILTER"
+ "YETUSDIR"
+)
+# Validate params
+for required_env in "${required_envs[@]}"; do
+ if [ -z "${!required_env}" ]; then
+ echo "[ERROR] Required environment variable '${required_env}' is not set."
+ missing_env=${missing_env}+1
+ fi
+done
+
+if [ ${missing_env} -gt 0 ]; then
+ echo "[ERROR] Please set the required environment variables before invoking. If this error is " \
+ "on Jenkins, then please file a JIRA about the error."
+ exit 1
+fi
+
+# TODO (HBASE-23900): cannot assume test-patch runs directly from sources
+TESTPATCHBIN="${YETUSDIR}/precommit/src/main/shell/test-patch.sh"
+
+# this must be clean for every run
+rm -rf "${PATCHDIR}"
+mkdir -p "${PATCHDIR}"
+
+# Checking on H* machine nonsense
+mkdir "${PATCHDIR}/machine"
+"${SOURCEDIR}/dev-support/gather_machine_environment.sh" "${PATCHDIR}/machine"
Review comment:
nice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1183:
HBASE-23767 WIP do not merge
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#discussion_r382352284
##########
File path: dev-support/docker/Dockerfile
##########
@@ -14,47 +14,173 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for installing the necessary dependencies for building Hadoop.
-# See BUILDING.txt.
-
-FROM maven:3.5-jdk-8
-
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- git \
- bats \
- findbugs \
- libperl-critic-perl \
- pylint \
- python-dateutil \
- rsync \
- make \
- gcc \
- libc6-dev \
- ruby \
- ruby-dev \
- wget \
- && \
- gem install --no-document rake rubocop ruby-lint
-
-ENV FINDBUGS_HOME /usr
-
-####
-# Install shellcheck
-###
-RUN mkdir -p /opt/shellcheck && \
- curl -L -s -S \
- https://storage.googleapis.com/shellcheck/shellcheck-stable.linux.x86_64.tar.xz \
- -o /opt/shellcheck.tar.xz && \
- tar xJf /opt/shellcheck.tar.xz --strip-components 1 -C /opt/shellcheck && \
- ln -s /opt/shellcheck/shellcheck /usr/bin/shellcheck && \
- rm -f /opt/shellcheck.tar.xz
+#
+# Dockerfile used as the build and test environment for Yetus.
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
-###
-# Avoid out of memory errors in builds
-###
-ENV MAVEN_OPTS -Xmx3g
+# start with a minimal image into which we can download remote tarballs
+FROM ubuntu:18.04 AS BASE_IMAGE
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3009
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ ca-certificates=20180409 \
+ curl=7.58.0-2ubuntu3.8 \
+ locales=2.27-3ubuntu1
+
+RUN locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM BASE_IMAGE AS FINDBUGS_DOWNLOAD_IMAGE
+ENV FINDBUGS_VERSION '3.0.1'
+ENV FINDBUGS_URL "https://downloads.sourceforge.net/project/findbugs/findbugs/${FINDBUGS_VERSION}/findbugs-${FINDBUGS_VERSION}.tar.gz"
+ENV FINDBUGS_SHA256 'e80e0da0c213a27504ef3188ef25f107651700ffc66433eac6a7454bbe336419'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/findbugs.tar.gz "${FINDBUGS_URL}" && \
+ echo "${FINDBUGS_SHA256} */tmp/findbugs.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS HADOLINT_DOWNLOAD_IMAGE
+ENV HADOLINT_VERSION '1.17.5'
+ENV HADOLINT_URL "https://github.com/hadolint/hadolint/releases/download/v${HADOLINT_VERSION}/hadolint-Linux-x86_64"
+ENV HADOLINT_SHA256 '20dd38bc0602040f19268adc14c3d1aae11af27b463af43f3122076baf827a35'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/hadolint "${HADOLINT_URL}" && \
+ echo "${HADOLINT_SHA256} */tmp/hadolint" | sha256sum -c -
+
+FROM BASE_IMAGE AS MAVEN_DOWNLOAD_IMAGE
+ENV MAVEN_VERSION='3.5.4'
+ENV MAVEN_URL "https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz"
+ENV MAVEN_SHA256 'ce50b1c91364cb77efe3776f756a6d92b76d9038b0a0782f7d53acf1e997a14d'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/maven.tar.gz "${MAVEN_URL}" && \
+ echo "${MAVEN_SHA256} */tmp/maven.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS ZULU7_DOWNLOAD_IMAGE
+ENV ZULU7_URL 'https://cdn.azul.com/zulu/bin/zulu7.36.0.5-ca-jdk7.0.252-linux_x64.tar.gz'
+ENV ZULU7_SHA256 'e0f34c242e6d456dac3e2c8a9eaeacfa8ea75c4dfc3e8818190bf0326e839d82'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/zulujdk7.tar.gz "${ZULU7_URL}" && \
+ echo "${ZULU7_SHA256} */tmp/zulujdk7.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS OPENJDK8_DOWNLOAD_IMAGE
+ENV OPENJDK8_URL 'https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_x64_linux_hotspot_8u232b09.tar.gz'
+ENV OPENJDK8_SHA256 '7b7884f2eb2ba2d47f4c0bf3bb1a2a95b73a3a7734bd47ebf9798483a7bcc423'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS OPENJDK11_DOWNLOAD_IMAGE
+ENV OPENJDK11_URL 'https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.6%2B10/OpenJDK11U-jdk_x64_linux_hotspot_11.0.6_10.tar.gz'
+ENV OPENJDK11_SHA256 '330d19a2eaa07ed02757d7a785a77bab49f5ee710ea03b4ee2fa220ddd0feffc'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/adoptopenjdk11.tar.gz "${OPENJDK11_URL}" && \
+ echo "${OPENJDK11_SHA256} */tmp/adoptopenjdk11.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM BASE_IMAGE
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# install dependencies from system packages. the first set brings the Ubuntu
+# distro into conformance with Yetus's expectations of what a Unix looks like.
+# the second set are dependencies required to enable various precommit
+# checks/features.
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ bash=4.4.18-2ubuntu1.2 \
+ build-essential=12.4ubuntu1 \
+ curl=7.58.0-2ubuntu3.8 \
+ diffutils=1:3.6-1 \
+ git=1:2.17.1-1ubuntu0.5 \
+ rsync=3.1.2-2.1ubuntu1 \
+ tar=1.29b-2ubuntu0.1 \
+ wget=1.19.4-1ubuntu2.2
+
+# be careful not to install any system packages (i.e., findbugs) that will
+# pull in the default-jre.
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ bats=0.4.0-1.1 \
+ libperl-critic-perl=1.130-1 \
+ python3=3.6.7-1~18.04 \
+ python3-pip=9.0.1-2.3~ubuntu1.18.04.1 \
+ python3-setuptools=39.0.1-2 \
+ ruby=1:2.5.1 \
+ ruby-dev=1:2.5.1 \
+ shellcheck=0.4.6-1 \
+ && \
+ apt-get clean && \
+ rm -rf /var/lib/apt/lists/*
+
+RUN python3 -mpip install --upgrade pip && \
+ python3 -mpip install pylint==2.4.4
+
+RUN gem install --no-document \
+ rake:13.0.1 \
+ rubocop:0.80.0 \
+ ruby-lint:2.3.1
+
+# hadolint ignore=DL3010
+COPY --from=FINDBUGS_DOWNLOAD_IMAGE /tmp/findbugs.tar.gz /tmp/findbugs.tar.gz
+RUN tar xzf /tmp/findbugs.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/findbugs.tar.gz | head -n1)")" /opt/findbugs && \
+ rm /tmp/findbugs.tar.gz
+
+COPY --from=HADOLINT_DOWNLOAD_IMAGE /tmp/hadolint /tmp/hadolint
+RUN mv /tmp/hadolint /usr/local/bin && \
+ chmod a+x /usr/local/bin/hadolint
+
+# hadolint ignore=DL3010
+COPY --from=MAVEN_DOWNLOAD_IMAGE /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven && \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=ZULU7_DOWNLOAD_IMAGE /tmp/zulujdk7.tar.gz /tmp/zulujdk7.tar.gz
Review comment:
why jdk7? is the goal a single docker image for all the branches?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593691235
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/57/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-593752996
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 6m 23s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 31s | master passed |
| +1 :green_heart: | compile | 5m 1s | master passed |
| +1 :green_heart: | shadedjars | 7m 4s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 26s | root in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 5s | the patch passed |
| +1 :green_heart: | compile | 4m 18s | the patch passed |
| +1 :green_heart: | javac | 4m 18s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 37s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 19s | root in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 2m 0s | root in the patch failed. |
| | | 47m 51s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux fbc3ef9d9426 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / c0301e3fdf |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/testReport/ |
| Max. process+thread count | 418 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/58/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 WIP do
not merge
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#issuecomment-587976414
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/1/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594759477
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 38s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
||| _ Other Tests _ |
| | | 1m 43s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/62/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1183 |
| Optional Tests | |
| uname | Linux b046d4ff6548 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b6eefcaeb7 |
| Max. process+thread count | 46 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/62/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-591720170
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/21/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1183:
HBASE-23767 WIP do not merge
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1183: HBASE-23767 WIP do not merge
URL: https://github.com/apache/hbase/pull/1183#discussion_r382845753
##########
File path: dev-support/docker/Dockerfile
##########
@@ -14,47 +14,173 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Dockerfile for installing the necessary dependencies for building Hadoop.
-# See BUILDING.txt.
-
-FROM maven:3.5-jdk-8
-
-RUN apt-get -q update && apt-get -q install --no-install-recommends -y \
- git \
- bats \
- findbugs \
- libperl-critic-perl \
- pylint \
- python-dateutil \
- rsync \
- make \
- gcc \
- libc6-dev \
- ruby \
- ruby-dev \
- wget \
- && \
- gem install --no-document rake rubocop ruby-lint
-
-ENV FINDBUGS_HOME /usr
-
-####
-# Install shellcheck
-###
-RUN mkdir -p /opt/shellcheck && \
- curl -L -s -S \
- https://storage.googleapis.com/shellcheck/shellcheck-stable.linux.x86_64.tar.xz \
- -o /opt/shellcheck.tar.xz && \
- tar xJf /opt/shellcheck.tar.xz --strip-components 1 -C /opt/shellcheck && \
- ln -s /opt/shellcheck/shellcheck /usr/bin/shellcheck && \
- rm -f /opt/shellcheck.tar.xz
+#
+# Dockerfile used as the build and test environment for Yetus.
+#
+# Built in multiple stages so as to avoid re-downloading large binaries when
+# tweaking unrelated aspects of the image.
-###
-# Avoid out of memory errors in builds
-###
-ENV MAVEN_OPTS -Xmx3g
+# start with a minimal image into which we can download remote tarballs
+FROM ubuntu:18.04 AS BASE_IMAGE
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# hadolint ignore=DL3009
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq update && \
+ DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ ca-certificates=20180409 \
+ curl=7.58.0-2ubuntu3.8 \
+ locales=2.27-3ubuntu1
+
+RUN locale-gen en_US.UTF-8
+ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
+
+##
+# download sundry dependencies
+#
+
+FROM BASE_IMAGE AS FINDBUGS_DOWNLOAD_IMAGE
+ENV FINDBUGS_VERSION '3.0.1'
+ENV FINDBUGS_URL "https://downloads.sourceforge.net/project/findbugs/findbugs/${FINDBUGS_VERSION}/findbugs-${FINDBUGS_VERSION}.tar.gz"
+ENV FINDBUGS_SHA256 'e80e0da0c213a27504ef3188ef25f107651700ffc66433eac6a7454bbe336419'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/findbugs.tar.gz "${FINDBUGS_URL}" && \
+ echo "${FINDBUGS_SHA256} */tmp/findbugs.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS HADOLINT_DOWNLOAD_IMAGE
+ENV HADOLINT_VERSION '1.17.5'
+ENV HADOLINT_URL "https://github.com/hadolint/hadolint/releases/download/v${HADOLINT_VERSION}/hadolint-Linux-x86_64"
+ENV HADOLINT_SHA256 '20dd38bc0602040f19268adc14c3d1aae11af27b463af43f3122076baf827a35'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/hadolint "${HADOLINT_URL}" && \
+ echo "${HADOLINT_SHA256} */tmp/hadolint" | sha256sum -c -
+
+FROM BASE_IMAGE AS MAVEN_DOWNLOAD_IMAGE
+ENV MAVEN_VERSION='3.5.4'
+ENV MAVEN_URL "https://archive.apache.org/dist/maven/maven-3/${MAVEN_VERSION}/binaries/apache-maven-${MAVEN_VERSION}-bin.tar.gz"
+ENV MAVEN_SHA256 'ce50b1c91364cb77efe3776f756a6d92b76d9038b0a0782f7d53acf1e997a14d'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/maven.tar.gz "${MAVEN_URL}" && \
+ echo "${MAVEN_SHA256} */tmp/maven.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS ZULU7_DOWNLOAD_IMAGE
+ENV ZULU7_URL 'https://cdn.azul.com/zulu/bin/zulu7.36.0.5-ca-jdk7.0.252-linux_x64.tar.gz'
+ENV ZULU7_SHA256 'e0f34c242e6d456dac3e2c8a9eaeacfa8ea75c4dfc3e8818190bf0326e839d82'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/zulujdk7.tar.gz "${ZULU7_URL}" && \
+ echo "${ZULU7_SHA256} */tmp/zulujdk7.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS OPENJDK8_DOWNLOAD_IMAGE
+ENV OPENJDK8_URL 'https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_x64_linux_hotspot_8u232b09.tar.gz'
+ENV OPENJDK8_SHA256 '7b7884f2eb2ba2d47f4c0bf3bb1a2a95b73a3a7734bd47ebf9798483a7bcc423'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/adoptopenjdk8.tar.gz "${OPENJDK8_URL}" && \
+ echo "${OPENJDK8_SHA256} */tmp/adoptopenjdk8.tar.gz" | sha256sum -c -
+
+FROM BASE_IMAGE AS OPENJDK11_DOWNLOAD_IMAGE
+ENV OPENJDK11_URL 'https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.6%2B10/OpenJDK11U-jdk_x64_linux_hotspot_11.0.6_10.tar.gz'
+ENV OPENJDK11_SHA256 '330d19a2eaa07ed02757d7a785a77bab49f5ee710ea03b4ee2fa220ddd0feffc'
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+RUN curl -LfsSo /tmp/adoptopenjdk11.tar.gz "${OPENJDK11_URL}" && \
+ echo "${OPENJDK11_SHA256} */tmp/adoptopenjdk11.tar.gz" | sha256sum -c -
+
+##
+# build the final image
+#
+
+FROM BASE_IMAGE
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
+
+# install dependencies from system packages. the first set brings the Ubuntu
+# distro into conformance with Yetus's expectations of what a Unix looks like.
+# the second set are dependencies required to enable various precommit
+# checks/features.
+
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ bash=4.4.18-2ubuntu1.2 \
+ build-essential=12.4ubuntu1 \
+ curl=7.58.0-2ubuntu3.8 \
+ diffutils=1:3.6-1 \
+ git=1:2.17.1-1ubuntu0.5 \
+ rsync=3.1.2-2.1ubuntu1 \
+ tar=1.29b-2ubuntu0.1 \
+ wget=1.19.4-1ubuntu2.2
+
+# be careful not to install any system packages (i.e., findbugs) that will
+# pull in the default-jre.
+RUN DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y \
+ bats=0.4.0-1.1 \
+ libperl-critic-perl=1.130-1 \
+ python3=3.6.7-1~18.04 \
+ python3-pip=9.0.1-2.3~ubuntu1.18.04.1 \
+ python3-setuptools=39.0.1-2 \
+ ruby=1:2.5.1 \
+ ruby-dev=1:2.5.1 \
+ shellcheck=0.4.6-1 \
+ && \
+ apt-get clean && \
+ rm -rf /var/lib/apt/lists/*
+
+RUN python3 -mpip install --upgrade pip && \
+ python3 -mpip install pylint==2.4.4
+
+RUN gem install --no-document \
+ rake:13.0.1 \
+ rubocop:0.80.0 \
+ ruby-lint:2.3.1
+
+# hadolint ignore=DL3010
+COPY --from=FINDBUGS_DOWNLOAD_IMAGE /tmp/findbugs.tar.gz /tmp/findbugs.tar.gz
+RUN tar xzf /tmp/findbugs.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/findbugs.tar.gz | head -n1)")" /opt/findbugs && \
+ rm /tmp/findbugs.tar.gz
+
+COPY --from=HADOLINT_DOWNLOAD_IMAGE /tmp/hadolint /tmp/hadolint
+RUN mv /tmp/hadolint /usr/local/bin && \
+ chmod a+x /usr/local/bin/hadolint
+
+# hadolint ignore=DL3010
+COPY --from=MAVEN_DOWNLOAD_IMAGE /tmp/maven.tar.gz /tmp/maven.tar.gz
+RUN tar xzf /tmp/maven.tar.gz -C /opt && \
+ ln -s "/opt/$(dirname "$(tar -tf /tmp/maven.tar.gz | head -n1)")" /opt/maven && \
+ rm /tmp/maven.tar.gz
+
+##
+# ensure JVMs are available under `/usr/lib/jvm` and prefix each installation
+# as `java-` so as to conform with Yetus's assumptions.
+#
+
+# hadolint ignore=DL3010
+COPY --from=ZULU7_DOWNLOAD_IMAGE /tmp/zulujdk7.tar.gz /tmp/zulujdk7.tar.gz
Review comment:
Yeah, eventually. After spending more time in here, I think that objective is out of scope for now. Let me drop this stage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594670420
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1183: HBASE-23767 Add
JDK11 compilation and unit test support to Github precommit
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1183: HBASE-23767 Add JDK11 compilation and unit test support to Github precommit
URL: https://github.com/apache/hbase/pull/1183#issuecomment-594670393
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1183/61/console in case of problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services