You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nitiraj Rathore <ni...@gmail.com> on 2015/09/23 15:13:20 UTC
Review Request 38674: Ambari Pig View -> Explain PigScript -> Script
Details - Shows the pig command instead of pig script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38674/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-13203
https://issues.apache.org/jira/browse/AMBARI-13203
Repository: ambari
Description
-------
Earlier :
On the Ambari Pig View if we write some pig script and do explain then in the "Script Details" block it was showing the "execute" script command instead of the script code.
In the patch :
The patch fetches the source.pig from the server as it is not directly available in the store.
In the controller scriptJob.js the property scriptContents is changed to return the /source.pig contents instead of /script.pig if the jobType is "explain"
After the Patch : the script code appears fine in the "Script Details" tag
Diffs
-----
contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/scriptJob.js d868823
Diff: https://reviews.apache.org/r/38674/diff/
Testing
-------
Manual testing and checking the data of the fetched /source.pig done. Seems to be working as expected.
Thanks,
Nitiraj Rathore
Re: Review Request 38674: Ambari Pig View -> Explain PigScript ->
Script Details - Shows the pig command instead of pig script
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38674/#review100484
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Sept. 23, 2015, 1:13 p.m., Nitiraj Rathore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38674/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 1:13 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-13203
> https://issues.apache.org/jira/browse/AMBARI-13203
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Earlier :
> On the Ambari Pig View if we write some pig script and do explain then in the "Script Details" block it was showing the "execute" script command instead of the script code.
>
> In the patch :
> The patch fetches the source.pig from the server as it is not directly available in the store.
> In the controller scriptJob.js the property scriptContents is changed to return the /source.pig contents instead of /script.pig if the jobType is "explain"
> After the Patch : the script code appears fine in the "Script Details" tag
>
>
> Diffs
> -----
>
> contrib/views/pig/src/main/resources/ui/pig-web/app/controllers/scriptJob.js d868823
>
> Diff: https://reviews.apache.org/r/38674/diff/
>
>
> Testing
> -------
>
> Manual testing and checking the data of the fetched /source.pig done. Seems to be working as expected.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>