[GitHub] [jena] afs commented on a change in pull request #1189: JENA-2273: Fix ASK in ResultSetWriterCSV and -TSV

[GitBox <gi...@apache.org>]

afs commented on a change in pull request #1189:
URL: https://github.com/apache/jena/pull/1189#discussion_r800199583



##########
File path: jena-arq/src/test/java/org/apache/jena/riot/resultset/rw/TestResultSetWriterTSV.java
##########
@@ -0,0 +1,30 @@
+package org.apache.jena.riot.resultset.rw;
+
+import static java.nio.charset.StandardCharsets.UTF_8;
+import static org.hamcrest.CoreMatchers.containsString;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertNotNull;
+
+import java.io.ByteArrayOutputStream;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.resultset.ResultSetWriter;
+import org.junit.Test;
+
+public class TestResultSetWriterTSV {
+
+	@Test

Review comment:
       Another tabbed file.

##########
File path: jena-arq/src/test/java/org/apache/jena/riot/resultset/rw/TestResultSetWriterCSV.java
##########
@@ -0,0 +1,30 @@
+package org.apache.jena.riot.resultset.rw;
+
+import static java.nio.charset.StandardCharsets.UTF_8;
+import static org.hamcrest.CoreMatchers.containsString;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertNotNull;
+
+import java.io.ByteArrayOutputStream;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.resultset.ResultSetWriter;
+import org.junit.Test;
+
+public class TestResultSetWriterCSV {
+
+	@Test

Review comment:
       Could you replace tabs with space please?

##########
File path: jena-arq/src/main/java/org/apache/jena/riot/resultset/rw/ResultSetWriterCSV.java
##########
@@ -69,6 +69,7 @@ private static void output(AWriter out, boolean booleanResult) {
         else
             out.write(noBytes);
         out.write(NL);
+        out.flush();

Review comment:
       Style: Ideally, enclose the operations in `try{ ... } finally { out.flush(); }` like `output(,ResultSet)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org