[GitHub] [flink] twalthr commented on a change in pull request #8661: [FLINK-12711][table] Separate function implementation and definition

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #8661:  [FLINK-12711][table] Separate function implementation and definition
URL: https://github.com/apache/flink/pull/8661#discussion_r294339911
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionLookup.java
 ##########
 @@ -16,19 +16,44 @@
  * limitations under the License.
  */
 
-package org.apache.flink.table.expressions.catalog;
+package org.apache.flink.table.catalog;
 
 import org.apache.flink.annotation.Internal;
 import org.apache.flink.table.functions.FunctionDefinition;
 
+import java.util.Optional;
+
 /**
- * Catalog of functions that can resolve the name of a function to a {@link FunctionDefinition}.
+ * Catalog of functions that can resolve the name of a function to a {@link FunctionLookup.Result}.
  */
 @Internal
-public interface FunctionDefinitionCatalog {
+public interface FunctionLookup {
 
 Review comment:
   Yes, but we also return the object identifier. So it is more than just the definition. The catalog is also called `FunctionCatalog` and not `FunctionDefinitionCatalog`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services