You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "smaheshwar-pltr (via GitHub)" <gi...@apache.org> on 2026/09/24 19:45:06 UTC
[PR] ci: replace MinIO with RustFS in integration tests [iceberg-go]
smaheshwar-pltr opened a new pull request, #2055:
URL: https://github.com/apache/iceberg-go/pull/2055
Replace the MinIO integration-test fixture with RustFS 1.0.0, following https://github.com/apache/iceberg/pull/18247 and https://github.com/apache/iceberg/issues/18246. This removes the MinIO images and client from the shared Spark, REST catalog, S3 IO, and Hadoop test setup.
The `object-store` service retains virtual-host addressing. Bucket setup uses a pinned AWS CLI image, waits for RustFS readiness, and completes before either REST catalog starts. The setup commands and test names now match the new fixture.
Validated `make test` and `make lint` with Go 1.26.1, compilation of the affected integration tests, Compose configuration, and workflow syntax. Runtime integration tests have not been run locally.
AI disclosure: Assisted by Codex (GPT-6). Human review pending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci: replace MinIO with RustFS in integration tests [iceberg-go]
Posted by "smaheshwar-pltr (via GitHub)" <gi...@apache.org>.
smaheshwar-pltr commented on PR #2055:
URL: https://github.com/apache/iceberg-go/pull/2055#issuecomment-5821915332
The failing job is `TestSqlCatalog`/`TestConcurrentTableViewCollisionReturnsCatalogSentinel` failing with `SQLITE_BUSY`, so I think this is a flake - could a maintainer rerun please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci: replace MinIO with RustFS in integration tests [iceberg-go]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #2055:
URL: https://github.com/apache/iceberg-go/pull/2055#discussion_r4099220361
##########
internal/recipe/Dockerfile:
##########
@@ -19,6 +19,7 @@ RUN pip3 install -q ipython
RUN pip3 install pyiceberg[s3fs,hive]
RUN pip3 install pyarrow
+COPY spark-defaults.conf ${SPARK_HOME}/conf/spark-defaults.conf
Review Comment:
no need for
```
RUN sed -i 's|http://minio:9000|http://object-store:9000|g' ${SPARK_HOME}/conf/spark-defaults.conf
```
follow spark 4 dockerfile convention
https://github.com/apache/iceberg-go/blob/85121cbde006091263c8035b90bd76a34b3d7460/internal/recipe/Dockerfile.spark4#L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci: replace MinIO with RustFS in integration tests [iceberg-go]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #2055:
URL: https://github.com/apache/iceberg-go/pull/2055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] ci: replace MinIO with RustFS in integration tests [iceberg-go]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2055:
URL: https://github.com/apache/iceberg-go/pull/2055#issuecomment-5823449569
thank you @smaheshwar-pltr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org