You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Allen Wittenauer (Jira)" <ji...@apache.org> on 2020/10/17 05:11:00 UTC
[jira] [Updated] (YETUS-995) vote table should have access to the
log filename
[ https://issues.apache.org/jira/browse/YETUS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Wittenauer updated YETUS-995:
-----------------------------------
Release Note:
<!-- markdown -->
Users:
The log files for tests have been popped up into the voting table for many of the generated reports.
Developers:
This is a breaking change. It reworks how tests should be registering the logfiles that they present to users and how bugsystem reporting engines should retrieve the filenames for those logfiles:
* add_vote_table() has been deprecated and replaced with add_vote_table_v2() that now takes an additional parameter. Code that uses add_vote_table()/add_footer_table() combo will NOT have their log file entries reported with some bugsystem reporting engines.
* The TP_VOTE_TABLE has been re-arranged a bit to add in the log filename. Custom reporting engines will need to modified.
was:
<!-- markdown -->
Developers:
This is a breaking change. It reworks how tests should be registering the logfiles that they present to users and how bugsystem reporting engines should retrieve the filenames for those logfiles:
* add_vote_table() has been deprecated and replaced with add_vote_table_v2() that now takes an additional parameter. Code that uses add_vote_table()/add_footer_table() combo will NOT have their log file entries reported with some bugsystem reporting engines.
* The TP_VOTE_TABLE has been re-arranged a bit to add in the log filename. Custom reporting engines will need to modified.
> vote table should have access to the log filename
> -------------------------------------------------
>
> Key: YETUS-995
> URL: https://issues.apache.org/jira/browse/YETUS-995
> Project: Yetus
> Issue Type: Improvement
> Components: Precommit
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Major
> Fix For: 0.13.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> A big design from early on in test-patch history was that the log entry was separate from the vote. This setup was likely done for a variety of aesthetic and practical reasons for JIRA. However, that design is flawed in that it is letting display dictate internals. With GitHub Status (YETUS-994), this flaw is now very very obvious.
> Fixing this flaw is going to be a MAJOR compatibility break with no particularly easy way to make existing code work. Details below.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)