You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/27 22:11:34 UTC
[GitHub] [airflow] mik-laj commented on a change in pull request #20509: Fix for #20032
mik-laj commented on a change in pull request #20509:
URL: https://github.com/apache/airflow/pull/20509#discussion_r775658597
##########
File path: tests/providers/snowflake/hooks/test_snowflake.py
##########
@@ -388,3 +388,38 @@ def test_connection_failure(self, mock_run):
assert status is False
assert msg == 'Connection Errors'
mock_run.assert_called_once_with(sql='select 1')
+
+ @mock.patch('airflow.providers.snowflake.hooks.snowflake.SnowflakeHook.run')
+ def test_connection_without_region(self, mock_run):
Review comment:
Can you add this case to the existing parameterized method?
https://github.com/apache/airflow/blob/e0552c7b4cf53757242c913fdb419ee55c70c459/tests/providers/snowflake/hooks/test_snowflake.py#L75-L203
##########
File path: tests/providers/snowflake/hooks/test_snowflake.py
##########
@@ -388,3 +388,38 @@ def test_connection_failure(self, mock_run):
assert status is False
assert msg == 'Connection Errors'
mock_run.assert_called_once_with(sql='select 1')
+
+ @mock.patch('airflow.providers.snowflake.hooks.snowflake.SnowflakeHook.run')
+ def test_connection_without_region(self, mock_run):
Review comment:
Can we add this case to the existing parameterized method?
https://github.com/apache/airflow/blob/e0552c7b4cf53757242c913fdb419ee55c70c459/tests/providers/snowflake/hooks/test_snowflake.py#L75-L203
##########
File path: tests/providers/snowflake/hooks/test_snowflake.py
##########
@@ -388,3 +388,38 @@ def test_connection_failure(self, mock_run):
assert status is False
assert msg == 'Connection Errors'
mock_run.assert_called_once_with(sql='select 1')
+
+ @mock.patch('airflow.providers.snowflake.hooks.snowflake.SnowflakeHook.run')
Review comment:
Is it needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org