[jira] [Commented] (HADOOP-12312) Findbugs HTML report link shows 0 warnings despite errors

["Kengo Seki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728490#comment-14728490 ] 

Kengo Seki commented on HADOOP-12312:
-------------------------------------

This code:

{code}
315     #shellcheck disable=SC2016
316     new_findbugs_warnings=$("${FINDBUGS_HOME}/bin/filterBugs" -first patch \
317         "${combined_xml}" "${newbugsbase}.xml" | ${AWK} '{print $1}')
318     if [[ $? != 0 ]]; then
319       popd >/dev/null
320       module_status ${i} -1 "" "${module} cannot run filterBugs (#1) from findbugs"
321       ((result=result+1))
322       savestop=$(stop_clock)
323       MODULE_STATUS_TIMER[${i}]=${savestop}
324       ((i=i+1))
325       continue
326     fi
327 
328     #shellcheck disable=SC2016
329     new_findbugs_fixed_warnings=$("${FINDBUGS_HOME}/bin/filterBugs" -fixed patch \
330         "${combined_xml}" "${newbugsbase}.xml" | ${AWK} '{print $1}')
331     if [[ $? != 0 ]]; then
332       popd >/dev/null
333       module_status ${i} -1 "" "${module} cannot run filterBugs (#2) from findbugs"
334       ((result=result+1))
335       savestop=$(stop_clock)
336       MODULE_STATUS_TIMER[${i}]=${savestop}
337       ((i=i+1))
338       continue
339     fi
{code}

writes to $\{newbugsbase}.xml twice, so new warnings will be removed.

> Findbugs HTML report link shows 0 warnings despite errors
> ---------------------------------------------------------
>
>                 Key: HADOOP-12312
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12312
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Varun Saxena
>         Attachments: hadoop-reproduciable.git2c4208f.patch
>
>
> Refer to Hadoop QA report below :
> https://issues.apache.org/jira/browse/YARN-3232?focusedCommentId=14679146&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14679146
> The report shows -1 for findbugs because there have been 7 findbugs warnings introduced. But the HTML report in link is showing 0 findbugs warnings.
> I verified locally and the warnings did indeed exist.
> So there must be some problem in findbugs HTML report generation in test-patch.sh
> This inconsistency between -1 for findbugs and HTML report lead to these findbugs warnings being leaked to trunk.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)