You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/17 15:57:31 UTC
[GitHub] [maven-archetypes] JurrianFahner opened a new pull request #5: Fix merge conflicts of PR 3
JurrianFahner opened a new pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5
@behrangsa has done nice work, the pull request #3 was stale since more than a year ago.
I fixed the merge conflicts of that PR.
Is it now possible to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] eolivelli commented on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-721230988
try again
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-archetypes/job/MARCHETYPES-70/2/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] JurrianFahner edited a comment on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
JurrianFahner edited a comment on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-723431812
@rfscholte I saw your name mentioned in jenkins, so I assumed you know how the jenkins build server has been configured. I don't have access to the build properties, is there a repo so I can look why the JAVA_HOME couldn't be resolved (on the branch for windows-jdk15)? See here for more information: https://ci-builds.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven-archetypes/detail/MARCHETYPES-70/3/pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] eolivelli commented on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-729531405
thank you very much for your contribution @JurrianFahner and also for your patience.
next step is to make a release.
can you please ask on dev@maven.apache.org if someone can cut a release for maven-archetypes.
I am sorry but I cannot do it in the short term, I am busy with other priorities
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] JurrianFahner commented on pull request #5: Fix merge conflicts of PR #3
Posted by GitBox <gi...@apache.org>.
JurrianFahner commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-719002625
@eolivelli Could you review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] JurrianFahner commented on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
JurrianFahner commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-729253886
@eolivelli How are we going to proceed? We now know the cause of the build failure. But how are we able to fix it? I believe I don't have access to the build procedure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] JurrianFahner edited a comment on pull request #5: Fix merge conflicts of PR #3
Posted by GitBox <gi...@apache.org>.
JurrianFahner edited a comment on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-719002625
@eolivelli Gentle ping... Could you review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] JurrianFahner commented on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
JurrianFahner commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-721354455
@eolivelli The build fails with the following message:
```
----- withMaven Wrapper script -----
The JAVA_HOME environment variable is not defined correctly
This environment variable is needed to run this program
NB: JAVA_HOME should point to a JDK not a JRE
script returned exit code 1
```
I believe the JAVA_HOME should be set properly, that's why the build fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] JurrianFahner edited a comment on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
JurrianFahner edited a comment on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-722595832
@eolivelli I've dived into the logs, and my conclusion is the same. The buildserver seems to be broken on the branch build. In some weird way the JAVA_HOME is not set, this env property is vital to run maven anyway.
I've also verified the build on my windows machine with java 15, it was running fine.
How can I dive in the build specifics to understand why this JAVA_HOME is not set (the other stages were build fine)?
I'm puzzled, because I can't explain it based on this pull request. It is must be the build server that has a different build definition on branches instead of the master, that would be my conclusion (based on what I understand of the build (and that's a little unfortunately)).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] eolivelli commented on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-721569524
It looks like the build passes on master branch
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-archetypes/job/master/
We should compare the logs.
Do you have time to debug @JurrianFahner ?
I will rerun the pipiline, in order to see if it was a transient error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] eolivelli commented on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-720593352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] eolivelli commented on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-729529986
it looks like we have a green build !
https://ci-builds.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven-archetypes/detail/MARCHETYPES-70/4/pipeline
merging this change now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] JurrianFahner commented on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
JurrianFahner commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-722595832
@eolivelli I've dived into the logs, and my conclusion is the same. The buildserver seems to be broken on the branch build. In some weird way the JAVA_HOME is not set, this env property is vital to run maven anyway.
I've also verified the build on my windows machine with java 15, it was running fine.
How can I dive in the build specifics to understand why this JAVA_HOME is not set (the other stages were build fine)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] JurrianFahner commented on pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
JurrianFahner commented on pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5#issuecomment-723431812
@rfscholte I saw your name mentioned in jenkins, so I assumed you know how the jenkins build server has been configured. I don't have access to the build properties, is there a repo so I can look why the JAVA_HOME couldn't be resolved on the branch for the test on windows-jdk15? See here for more information: https://ci-builds.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven-archetypes/detail/MARCHETYPES-70/3/pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] eolivelli merged pull request #5: [MARCHETYPES-70] enable generating Java 9+ projects and add support for JUnit 5.x
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #5:
URL: https://github.com/apache/maven-archetypes/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org