You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/25 21:54:49 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18278: Updating miscellaneous provider DAGs to use TaskFlow API where applicable

ephraimbuddy commented on a change in pull request #18278:
URL: https://github.com/apache/airflow/pull/18278#discussion_r716102559



##########
File path: airflow/providers/sqlite/example_dags/example_sqlite.py
##########
@@ -55,6 +54,7 @@
 # [END howto_operator_sqlite]
 
 
+@dag.task(task_id="insert_sqlite_task")
 def insert_sqlite_hook():
     sqlite_hook = SqliteHook("sqlite_default")

Review comment:
       Since we are using this hook, I think we should remove the `default_args` because it won't be passed to this hook.
   
   Also, this example didn't work when I ran it. Since this is SQLite and it's easy to set up the connection, I would suggest we make it work




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org