You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@hotmail.com> on 2013/08/06 22:25:34 UTC
Review Request 13346: [HELIX-194] ZNRecord has too many constructors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13346/
-----------------------------------------------------------
Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
Bugs: HELIX-194
Repository: helix-git
Description
-------
Fix for HELIX-194. Adding support for customizable payloads added to the number of constructors for ZNRecord. We decided to remove the optional ones and make the fields accessible with setters.
The diffs are attached to this request because the normal diff upload technique isn't currently working (tracked by INFRA-6640).
Diffs
-----
Diff: https://reviews.apache.org/r/13346/diff/
Testing
-------
Unit tests pass locally.
File Attachments
----------------
DIffs
https://reviews.apache.org/media/uploaded/files/2013/08/06/0001-HELIX-194-ZNRecord-has-too-many-constructors.patch
Thanks,
Kanak Biscuitwala
Re: Review Request 13346: [HELIX-194] ZNRecord has too many constructors
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13346/#review24742
-----------------------------------------------------------
Ship it!
Ship It!
- Zhen Zhang
On Aug. 6, 2013, 8:25 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13346/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2013, 8:25 p.m.)
>
>
> Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
>
>
> Bugs: HELIX-194
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> Fix for HELIX-194. Adding support for customizable payloads added to the number of constructors for ZNRecord. We decided to remove the optional ones and make the fields accessible with setters.
>
> The diffs are attached to this request because the normal diff upload technique isn't currently working (tracked by INFRA-6640).
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/13346/diff/
>
>
> Testing
> -------
>
> Unit tests pass locally.
>
>
> File Attachments
> ----------------
>
> DIffs
> https://reviews.apache.org/media/uploaded/files/2013/08/06/0001-HELIX-194-ZNRecord-has-too-many-constructors.patch
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 13346: [HELIX-194] ZNRecord has too many constructors
Posted by Kanak Biscuitwala <ka...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13346/
-----------------------------------------------------------
(Updated Aug. 6, 2013, 8:25 p.m.)
Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu.
Bugs: HELIX-194
Repository: helix-git
Description
-------
Fix for HELIX-194. Adding support for customizable payloads added to the number of constructors for ZNRecord. We decided to remove the optional ones and make the fields accessible with setters.
The diffs are attached to this request because the normal diff upload technique isn't currently working (tracked by INFRA-6640).
Diffs
-----
Diff: https://reviews.apache.org/r/13346/diff/
Testing
-------
Unit tests pass locally.
File Attachments
----------------
DIffs
https://reviews.apache.org/media/uploaded/files/2013/08/06/0001-HELIX-194-ZNRecord-has-too-many-constructors.patch
Thanks,
Kanak Biscuitwala