You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "tarraschk (via GitHub)" <gi...@apache.org> on 2025/03/16 19:09:41 UTC
[PR] feat(country-map): fix France Regions IDF region code - Fixes #32627 [superset]
tarraschk opened a new pull request, #32695:
URL: https://github.com/apache/superset/pull/32695
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This change fixes the tabulation in the IDF region code ( Fixes #32627 )
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
Run the `Country Map GeoJSON Generator.ipynb` Jupyter Notebook
### ADDITIONAL INFORMATION
- [X] Has associated issue: Fixes #32627
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(country-map): fix France Regions IDF region code - Fixes #32627 [superset]
Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 commented on PR #32695:
URL: https://github.com/apache/superset/pull/32695#issuecomment-3102598211
Although the correction has been present since 2025-04-22T02:15:27Z, I have the issue with version 5.0.0 (which was built later: 2025-06-23T16:09:21Z)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(country-map): fix France Regions IDF region code - Fixes #32627 [superset]
Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 commented on PR #32695:
URL: https://github.com/apache/superset/pull/32695#issuecomment-3102599171
<img width="1144" height="593" alt="image" src="https://github.com/user-attachments/assets/9e25ae4a-04fd-4845-af0b-7b0323ce46f0" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(country-map): fix France Regions IDF region code - Fixes #32627 [superset]
Posted by "tarraschk (via GitHub)" <gi...@apache.org>.
tarraschk commented on PR #32695:
URL: https://github.com/apache/superset/pull/32695#issuecomment-3356934631
@xavier-GitHub76 : we can see here https://github.com/apache/superset/blob/5.0.0/superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/france_regions.geojson?short_path=6786037#L15 that the fix is not included in v5.0.0 but available in master https://github.com/apache/superset/blob/master/superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/france_regions.geojson?short_path=6786037#L15 and 6.0.0rc2 https://github.com/apache/superset/blob/6.0.0rc2/superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries/france_regions.geojson?short_path=6786037#L15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(country-map): fix France Regions IDF region code - Fixes #32627 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #32695:
URL: https://github.com/apache/superset/pull/32695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(country-map): fix France Regions IDF region code - Fixes #32627 [superset]
Posted by "xavier-GitHub76 (via GitHub)" <gi...@apache.org>.
xavier-GitHub76 commented on PR #32695:
URL: https://github.com/apache/superset/pull/32695#issuecomment-3415297328
@rusackas Is a 5.0.1 version planned to include this fix ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org