[jira] [Comment Edited] (FLINK-29906) Address tabs/spaces in checkstyle/spotless

["Chesnay Schepler (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-29906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638209#comment-17638209 ] 

Chesnay Schepler edited comment on FLINK-29906 at 11/24/22 9:15 AM:
--------------------------------------------------------------------

FYI the .editorconfig that other connector repos contain setup formatting for the xml files. It's not being verified though.


was (Author: zentol):
FYI the .editorconfig that all other connector repos contain due setup formatting for the xml files. It's not being verified though.

> Address tabs/spaces in checkstyle/spotless
> ------------------------------------------
>
>                 Key: FLINK-29906
>                 URL: https://issues.apache.org/jira/browse/FLINK-29906
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / AWS
>            Reporter: Danny Cranmer
>            Assignee: Daren Wong
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: aws-connector-2.0.0
>
>
> The DynamoDB connector has a mix of tabs and spaces, the quality config does not seem to be enforcing anything. The code style guide says we should [use spaces|https://flink.apache.org/contributing/code-style-and-quality-formatting.html#whitespaces].
> - Update code to use spaces
> - Fix quality plugin to reject tabs



--
This message was sent by Atlassian Jira
(v8.20.10#820010)