You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by njtman <gi...@git.apache.org> on 2015/08/17 21:10:27 UTC
[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...
GitHub user njtman opened a pull request:
https://github.com/apache/cordova-ios/pull/152
CB-9500 Added no sign argument to iOS build
As of Cordova iOS 3.9.0, Xcode signing is automatically added to the build
step when compiling for device. An argument has been added to skip
the signing step (xcrun command) when building for an iOS device.
Simply supply:
--noSign
argument when running the compile / build command to skip iOS app signing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/njtman/cordova-ios CB-9500-iOS-Build-No-Sign-Arg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit 5bfb1eefc15a81096ae9106f87c893716d1f9cd0
Author: Jon Tancer <ta...@gmail.com>
Date: 2015-08-17T19:08:31Z
CB-9500 Added no sign argument to iOS build
As of Cordova iOS 3.9.0, Xcode signing is automatically added to build
step when compiling for device. An argument has been added to skip
this step of signing when building for an iOS device. Simply supply
the —noSign argument when running the compile / build command.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/152#issuecomment-132024453
Another option is to use 'xcode' node module to parse the `productname` which corresponds with the .app name and find it .app file to sign. Alternative, shell.ls can be used to find the .app file and create an ipa.
I want to question why would you have a different name for the .xcodeproj and the app name? I noticed, we allow changing the name in config.xml and thereafter being able to update .xcodeproj name and the product name - does that not work for you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...
Posted by njtman <gi...@git.apache.org>.
Github user njtman commented on the pull request:
https://github.com/apache/cordova-ios/pull/152#issuecomment-132258001
@nikhilkh
I am aware of the name attribute in the config.xml.
We are setting the productname in the xcode build file because we have run into issues where setting a name with spaces or special characters, doesn't play nicely with xcode project names.
In our use case, we set the cordova project name to a very simple name - one with no spaces or special characters. We can then change the app's display name for ios or android (sometimes slightly different between the platforms due to name wrapping on Android) to almost anything we want, without having to worry about xcode or gradle project incompatibilities.
I like the idea that you suggested about using the xcode node module to parse the project name. The no wrap option is not ideal, but it was the simplest and easiest to implement, as our custom build environment already signs our applications for us.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/152#issuecomment-147599790
Hi @njtman I couldn't find your name (from the patch's From: field) in the Apache CLA list: http://people.apache.org/committer-index.html
Once you have filed one, I can proceed with merging this in. Instructions here: https://www.apache.org/licenses/icla.txt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/152#issuecomment-147592877
This looks good. Let's get it in!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/152#issuecomment-147590435
@nikhilkh any objections to this getting pulled in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9500 Added no sign argument to iOS bu...
Posted by njtman <gi...@git.apache.org>.
Github user njtman commented on the pull request:
https://github.com/apache/cordova-ios/pull/152#issuecomment-148380772
@shazron I have signed and submitted my icla to secretary@apache.org.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org