You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "OmniaGM (via GitHub)" <gi...@apache.org> on 2024/01/01 23:29:21 UTC

[PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

OmniaGM opened a new pull request, #15103:
URL: https://github.com/apache/kafka/pull/15103

   still - WIP
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #15103:
URL: https://github.com/apache/kafka/pull/15103#issuecomment-2317670245

   I am closing this pr as we have been breaking KafkaConfig slowly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #15103:
URL: https://github.com/apache/kafka/pull/15103#issuecomment-1883204174

   > Hello @OmniaGM .
   > 
   > As a first step to reduce changes I suggest move `Defaults` object to java code. This seems pretty simple and reviewable change.
   > 
   > I can prepare PR with those changes.
   > 
   > What do you think?
   > 
   > @mimaison @ijuma Can you, please, share your opinion, also.
   
   first pr is here #15158, I'll push couple of other prs soon as well 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

Posted by "nizhikov (via GitHub)" <gi...@apache.org>.
nizhikov commented on PR #15103:
URL: https://github.com/apache/kafka/pull/15103#issuecomment-1882865241

   Hello @OmniaGM .
   
   As a first step to reduce changes I suggest move `Defaults` object to java code.
   This seems pretty simple and reviewable change.
   
   I can prepare PR with those changes.
   
   What do you think?
   
   @mimaison @ijuma Can you, please, share your opinion, also.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #15103:
URL: https://github.com/apache/kafka/pull/15103#issuecomment-1880865673

   Thanks for the PR. 
   It's really big, is there a way to split this into smaller PRs? For example we have https://github.com/apache/kafka/pull/15075 in progress to move the ZooKeeper configs. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #15103:
URL: https://github.com/apache/kafka/pull/15103#issuecomment-1996761545

   I published another PR to move only the properties and their docs out of core #15501 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #15103:
URL: https://github.com/apache/kafka/pull/15103#issuecomment-1882890787

   Am preparing this already will push it soon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #15103:
URL: https://github.com/apache/kafka/pull/15103#issuecomment-1881108764

   > Thanks for the PR. It's really big, is there a way to split this into smaller PRs? For example we have #15075 in progress to move the ZooKeeper configs.
   
   I can try to break it down, I think some interfaces can move out in separate pr. The problem is that KafkaConfig is imported in many places and depends on too many other classes in core and outside of core. Let me see what I can do. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM closed pull request #15103: KAFKA-15853: Move KafkaConfig to server module
URL: https://github.com/apache/kafka/pull/15103


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

Posted by "OmniaGM (via GitHub)" <gi...@apache.org>.
OmniaGM commented on PR #15103:
URL: https://github.com/apache/kafka/pull/15103#issuecomment-1883437923

   I raise the following prs #15158, #15161, #15160 and #15159.
   And soon will raise 
   1. few PRs move the new interfaces to reduce moving dependencies out of core and reduce the changes in this pr
      - ReconfigurableServer to avoid depending on Broker and Controller
      - DynamicBrokerConfigManager and DynamicBrokerConfigBaseManager to avoid depending directly on DynamicBrokerConfig
      - KafkaZKClient to avoid any depend ices on KafaZKClient
    2. few prs to Move some deps like `Session`, `SocketServer`, `AuthorizerUtils`, `KafkaRaftServer`, and `PasswordEncoder` 
    3. After this depends on how big is the remaining changes I can move KafkaConfig object companion first. then keep this pr to only move KafkaConfig class


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org