You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/16 15:30:37 UTC
[GitHub] [netbeans] sdedic opened a new pull request #2465: Reducing LSP server messages on startup.
sdedic opened a new pull request #2465:
URL: https://github.com/apache/netbeans/pull/2465
* The debugging messages suppressed by default, added `Verbose Console` option that enables it back.
* Merged the outputs `Java` and `Java Language Server` - OK, @JaroslavTulach, @dbalek ?
* Start/ready messages short-displayed in the status bar
Will mark with approriate milestone & ask Coordinator for approval after this is functionally approved first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2465: Reducing LSP server messages on startup.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2465:
URL: https://github.com/apache/netbeans/pull/2465#issuecomment-714683461
rebased on latest `delivery`; squashed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2465: Reducing LSP server messages on startup.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2465:
URL: https://github.com/apache/netbeans/pull/2465#issuecomment-714678337
Well, I guess there are some conflict wioth your lates t work. Please resolve them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi edited a comment on pull request #2465: Reducing LSP server messages on startup.
Posted by GitBox <gi...@apache.org>.
lkishalmi edited a comment on pull request #2465:
URL: https://github.com/apache/netbeans/pull/2465#issuecomment-714678337
Well, I guess there are some conflict with your latest work. Please resolve them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2465: Reducing LSP server messages on startup.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2465:
URL: https://github.com/apache/netbeans/pull/2465#discussion_r506824235
##########
File path: java/java.lsp.server/vscode/src/extension.ts
##########
@@ -205,7 +207,7 @@ export function activate(context: ExtensionContext) {
let debugDescriptionFactory = new NetBeansDebugAdapterDescriptionFactory();
context.subscriptions.push(vscode.debug.registerDebugAdapterDescriptorFactory('java-polyglot', debugDescriptionFactory));
- window.showInformationMessage('Java Polyglot Debug Adapter ready.');
+ window.setStatusBarMessage('Java Polyglot Debug Adapter ready.', 5000);
Review comment:
We don't really need this message at all. It is a heritage from the early attempts to make the Debug Adapter Protocol work.
##########
File path: java/java.lsp.server/vscode/src/extension.ts
##########
@@ -85,9 +88,8 @@ export function activate(context: ExtensionContext) {
}
});
- let log = vscode.window.createOutputChannel("Java Language Server");
log.appendLine("Launching Java Language Server");
- vscode.window.showInformationMessage("Launching Java Language Server");
+ vscode.window.setStatusBarMessage("Launching Java Language Server", 2000);
Review comment:
Great. I wasn't aware of this method. Probably added in newer version of VSCode.
##########
File path: java/java.lsp.server/vscode/package.json
##########
@@ -35,7 +35,12 @@
],
"default": null,
"description": "Specifies the JDK on which the Java language server should be run"
- }
+ },
+ "netbeans.verboseConsole": {
Review comment:
Let's do `netbeans.verbose` only or `netbeans.loglevel`, or `netbeans.debug`. CCing @jisedlac
##########
File path: java/java.lsp.server/vscode/package.json
##########
@@ -35,7 +35,12 @@
],
"default": null,
"description": "Specifies the JDK on which the Java language server should be run"
- }
+ },
+ "netbeans.verboseConsole": {
+ "type": "boolean",
+ "default": false,
+ "description": "Enables verbose messages from the Java Lanuage server on the console"
Review comment:
Re. "on the console" - I don't think this makes sense from the point of view of VSCode user. The user sees no "console" as far as I can say. "Enables debug messages from the Java Language Server" (in the output tab).
Btw. typo "Lanuage".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2465: Reducing LSP server messages on startup.
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2465:
URL: https://github.com/apache/netbeans/pull/2465
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists