[GitHub] [lucenenet] NightOwl888 opened a new pull request #531: Reverted WeakDictionary change to back with ConcurrentDictionary

[GitBox <gi...@apache.org>]

NightOwl888 opened a new pull request #531:
URL: https://github.com/apache/lucenenet/pull/531


   This reverts commit ddfb7b2108f0d72fd03c563c4bfc2f3479cdf91f.
   
   This was causing occasional test failures of `Lucene.Net.Support.TestWeakDictionary::C_TestMemLeakage()`, so we are rolling back to a state where we know the exception doesn't occur. This only affects .NET Standard 2.0 and .NET Framework.
   
   Maybe we can revisit this, but the ideal fix would be to finish #256 so we can use `ConditionalWeakTable<TKey, TValue>` on all platforms and remove `WeakDictionary<TKey, TValue>` and its flakey tests from the project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [lucenenet] NightOwl888 merged pull request #531: Reverted WeakDictionary change to back with ConcurrentDictionary

[GitBox <gi...@apache.org>]

NightOwl888 merged pull request #531:
URL: https://github.com/apache/lucenenet/pull/531


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org