[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2128: Issue #2127: Allow user override default SASL service name bookkeeper

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #2128: Issue #2127: Allow user override default SASL service name bookkeeper
URL: https://github.com/apache/bookkeeper/pull/2128#discussion_r305443332
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/sasl/SaslClientState.java
 ##########
 @@ -50,7 +50,9 @@
     private String password;
 
     public SaslClientState(String serverHostname, Subject subject) throws SaslException {
-        String serverPrincipal = SaslConstants.SASL_BOOKKEEPER_PROTOCOL + "/" + serverHostname;
+        String saslServiceName = System.getProperty("bookkeeper.sasl.servicename",
 
 Review comment:
   This should be configurable in Client Configuration and in ServerConfiguration.
   
   We should add tests as well, you can check existing tests and start from them
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services