[GitHub] justinedelson commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?

[GitBox <gi...@apache.org>]

justinedelson commented on a change in pull request #1: SLING-5668 - Leverage ServletRequestListener.requestDestroyed for cal?
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/1#discussion_r155641644
 
 

 ##########
 File path: src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java
 ##########
 @@ -1046,11 +1075,22 @@ protected ThreadInvocationCounter initialValue() {
 
         this.configPrinterRegistration = bundleContext.registerService(Object.class.getName(),
                 new ModelConfigurationPrinter(this, bundleContext, adapterImplementations), printerProps);
+
+        Hashtable<Object, Object> listenerProps = new Hashtable<>();
 
 Review comment:
   The problem with DS in this case (which is already true of the `ConfigurationPrinter` right above this) is that it needs access to internal data structures of the `ModelAdapterFactory`, so I'd rather keep that all internal and manage the lifecycle manually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services