You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Sergiy Matusevych <se...@gmail.com> on 2016/10/04 00:22:37 UTC
REEFJava build fails on Windows?
Hi REEF devs,
Can someone try to build current master from scratch? I am getting the
following error:
[exec]
C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-wake\wake/../../../../lang/common/proto/RemoteProtocol.proto:
File does not reside within any path specified using --proto_path (or -I).
You must specify a --proto_path which encompasses this file. Note that the
proto_path must be an exact prefix of the .proto file names -- protoc is
too dumb to figure out when two paths (e.g. absolute and relative) are
equivalent (it's harder than you think).
and eventually it complains that java files that should be generated from
proto are not there. :(
I've removed ~/.m2 and cloned the whole repo anew but I am still getting
this error. Am I the only one getting this error? Any ideas on how to fix
it?
Thanks,
Sergiy.
RE: REEFJava build fails on Windows?
Posted by Mariia Mykhailova <ma...@microsoft.com>.
I've tried to build current master on my machine, and the build succeeds. Travis CI also builds successfully.
-Mariia
-----Original Message-----
From: Sergiy Matusevych [mailto:sergiy.matusevych@gmail.com]
Sent: Monday, October 3, 2016 5:23 PM
To: dev@reef.apache.org
Subject: REEFJava build fails on Windows?
Hi REEF devs,
Can someone try to build current master from scratch? I am getting the following error:
[exec]
C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-wake\wake/../../../../lang/common/proto/RemoteProtocol.proto:
File does not reside within any path specified using --proto_path (or -I).
You must specify a --proto_path which encompasses this file. Note that the proto_path must be an exact prefix of the .proto file names -- protoc is too dumb to figure out when two paths (e.g. absolute and relative) are equivalent (it's harder than you think).
and eventually it complains that java files that should be generated from proto are not there. :(
I've removed ~/.m2 and cloned the whole repo anew but I am still getting this error. Am I the only one getting this error? Any ideas on how to fix it?
Thanks,
Sergiy.
Re: REEFJava build fails on Windows?
Posted by Douglas Service <ds...@gmail.com>.
Are you cleaning from powershell or from visual studio?
Doug
On Mon, Oct 3, 2016 at 5:49 PM, Mariia Mykhailova <ma...@microsoft.com>
wrote:
> Interesting, I did get some failures after syncing to this commit, but for
> me it was sufficient to do a regular .NET clean for everything to start
> working again.
>
> function Clean-REEF-NET{
> Invoke-Expression 'msbuild $REEFSourcePath\lang\cs\Org.Apache.REEF.sln
> /p:Configuration="Debug" /p:Platform="x64" /t:Clean /m /nr:false'
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter obj
> | Remove-Item -Recurse
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter bin
> | Remove-Item -Recurse
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter target
> | Remove-Item -Recurse
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter
> REEF_LOCAL_RUNTIME | Remove-Item -Recurse
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter
> TestResults | Remove-Item -Recurse
> }
>
> -Mariia
>
> -----Original Message-----
> From: Douglas Service [mailto:dsopsrc@gmail.com]
> Sent: Monday, October 3, 2016 5:44 PM
> To: dev@reef.apache.org
> Subject: Re: REEFJava build fails on Windows?
>
> I just synced to Apache reef master and it builds. Your problem is
> probably from the commit below. I put a warning in the commit message since
> I had a very similar problem where I was getting test errors. To fix the
> problem, I ended up pushing all of my branches to github deleting my
> enlistment and then cloning my copy of REEF on github. You could probably
> also do a clean, roll back to the commit just before this one, do a clean,
> and then pull the latestest. I verified the problem only occurs if you do
> not do a clean in Visual Studio and Maven before syncing to the commit.
> There was some discussion on the dev list, but we probably need a better
> way to let every know about these kinds of issues.
>
> Doug
>
> [REEF-1611] Move Java .proto files to common directory
>
> This change moves the Java .proto files to lang/common/proto so the C#
> side can use the same proto files.
>
> WARNING: Before pulling this change you should clean both the Java and C#
> builds; otherwise, you will have artifacts this version cannot remove that
> cause test failures on the C# side.
>
> JIRA:
> [REEF-1611](https://na01.safelinks.protection.outlook.
> com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%
> 2FREEF-1611&data=01%7C01%7Cmamykhai%40microsoft.com%
> 7Cd3ccbd8898604b4fc16c08d3ebef9bd0%7C72f988bf86f141af91ab2d7cd011
> db47%7C1&sdata=%2B93eDf2dKPIbgXr%2FVLPmBqFUNm65EFxpMPcNMde2tsI%
> 3D&reserved=0)
>
> Pull Request:
> This closes #1142 <https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fgithub.com%2Fapache%2Freef%2Fpull%2F1142&
> data=01%7C01%7Cmamykhai%40microsoft.com%7Cd3ccbd8898604b4fc16c08d3ebef
> 9bd0%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=HpdqNGdwXs%
> 2F9gR%2BBx%2FOXhlGQi%2FZRTFGnGCCs%2BKgn8MA%3D&reserved=0>
>
>
> On Mon, Oct 3, 2016 at 5:22 PM, Sergiy Matusevych <
> sergiy.matusevych@gmail.com> wrote:
>
> > Hi REEF devs,
> >
> > Can someone try to build current master from scratch? I am getting the
> > following error:
> >
> > [exec]
> > C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-
> > wake\wake/../../../../lang/common/proto/RemoteProtocol.proto:
> > File does not reside within any path specified using --proto_path (or
> -I).
> > You must specify a --proto_path which encompasses this file. Note
> > that the proto_path must be an exact prefix of the .proto file names
> > -- protoc is too dumb to figure out when two paths (e.g. absolute and
> > relative) are equivalent (it's harder than you think).
> >
> > and eventually it complains that java files that should be generated
> > from proto are not there. :(
> >
> > I've removed ~/.m2 and cloned the whole repo anew but I am still
> > getting this error. Am I the only one getting this error? Any ideas on
> > how to fix it?
> >
> > Thanks,
> > Sergiy.
> >
>
--
On Mon, Oct 3, 2016 at 5:50 PM, Markus Weimer <ma...@weimo.de> wrote:
On Mon, Oct 3, 2016 at 4:55 PM, Douglas Service <ds...@gmail.com> wrote:
> Questions:
> 1) If the extra messages are not used by both sides they should probably
> not be in this file. Will these messages be shared in the futur
Re: REEFJava build fails on Windows?
Posted by Sergiy Matusevych <se...@gmail.com>.
Hi Doug,
I think I've fixed it. It turned out the problem was on my side. I was
using protoc from cygwin, and it chokes on windows paths. I've replaced it
with the static exe from google and everything works now.
Sorry for the false alarm,
Sergiy.
On Mon, Oct 3, 2016 at 7:33 PM, Douglas Service <ds...@gmail.com> wrote:
> I am able to build the java build on Windows and protoc runs with no
> problems. An example of the internal maven paths is below which are all
> Unix style and work fine on windows. Are you modifying the proto files?
>
> Doug
>
> <properties>
> <rootPath>${basedir}/../../..</rootPath>
> <protoPath>${rootPath}/lang/common/proto</protoPath>
> </properties>
>
>
> <exec executable="protoc">
> <arg value="--proto_path=${protoPath}"/>
> <arg value="--java_out=target/generated-sources/proto"/>
> <arg value="${protoPath}/reef_service_protos.proto"/>
> <arg value="${protoPath}/evaluator_runtime.proto"/>
> <arg value="${protoPath}/client_runtime.proto"/>
> <arg value="${protoPath}/reef_protocol.proto"/>
> </exec>
>
>
>
> On Mon, Oct 3, 2016 at 6:58 PM, Sergiy Matusevych <
> sergiy.matusevych@gmail.com> wrote:
>
> > Hi guys,
> >
> > I think I've figured out what's going on. protoc chokes on Windows-style
> > paths. I've just ran mvn -X, and the command it executes on my PC is:
> >
> > cd C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-wake\wake
> >
> > protoc --proto_path=C:\Users\sergiym.REDMOND\devel\reef\lang\java\
> > reef-wake\wake/../../../../lang/common/proto
> > --java_out=target/generated-sources/proto
> > C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-
> > wake\wake/../../../../lang/common/proto/RemoteProtocol.proto
> >
> > and it fails. When I replace the path with unix-style relative path,
> > everything works, i.e.
> >
> > protoc --proto_path=../../../common/proto
> > --java_out=target/generated-sources/proto
> > ../../../common/proto/RemoteProtocol.proto
> >
> > For now, I will just compile the proto files by hand, but I guess
> > eventually we will need to fix the pom.xml
> >
> > Thanks for your help!
> > Sergiy.
> >
> >
> > On Mon, Oct 3, 2016 at 5:49 PM, Mariia Mykhailova <
> mamykhai@microsoft.com>
> > wrote:
> >
> > > Interesting, I did get some failures after syncing to this commit, but
> > for
> > > me it was sufficient to do a regular .NET clean for everything to start
> > > working again.
> > >
> > > function Clean-REEF-NET{
> > > Invoke-Expression 'msbuild $REEFSourcePath\lang\cs\Org.
> > Apache.REEF.sln
> > > /p:Configuration="Debug" /p:Platform="x64" /t:Clean /m /nr:false'
> > > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter obj
> > > | Remove-Item -Recurse
> > > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter bin
> > > | Remove-Item -Recurse
> > > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter
> target
> > > | Remove-Item -Recurse
> > > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter
> > > REEF_LOCAL_RUNTIME | Remove-Item -Recurse
> > > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter
> > > TestResults | Remove-Item -Recurse
> > > }
> > >
> > > -Mariia
> > >
> > > -----Original Message-----
> > > From: Douglas Service [mailto:dsopsrc@gmail.com]
> > > Sent: Monday, October 3, 2016 5:44 PM
> > > To: dev@reef.apache.org
> > > Subject: Re: REEFJava build fails on Windows?
> > >
> > > I just synced to Apache reef master and it builds. Your problem is
> > > probably from the commit below. I put a warning in the commit message
> > since
> > > I had a very similar problem where I was getting test errors. To fix
> the
> > > problem, I ended up pushing all of my branches to github deleting my
> > > enlistment and then cloning my copy of REEF on github. You could
> probably
> > > also do a clean, roll back to the commit just before this one, do a
> > clean,
> > > and then pull the latestest. I verified the problem only occurs if you
> do
> > > not do a clean in Visual Studio and Maven before syncing to the commit.
> > > There was some discussion on the dev list, but we probably need a
> better
> > > way to let every know about these kinds of issues.
> > >
> > > Doug
> > >
> > > [REEF-1611] Move Java .proto files to common directory
> > >
> > > This change moves the Java .proto files to lang/common/proto so the C#
> > > side can use the same proto files.
> > >
> > > WARNING: Before pulling this change you should clean both the Java and
> C#
> > > builds; otherwise, you will have artifacts this version cannot remove
> > that
> > > cause test failures on the C# side.
> > >
> > > JIRA:
> > > [REEF-1611](https://na01.safelinks.protection.outlook.com/?
> > > url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FREEF-
> > > 1611&data=01%7C01%7Cmamykhai%40microsoft.com%7Cd3ccbd889860
> > > 4b4fc16c08d3ebef9bd0%7C72f988bf86f141af91ab2d7cd011db47%7C1&
> > > sdata=%2B93eDf2dKPIbgXr%2FVLPmBqFUNm65EFxpMPcNMde2tsI%3D&reserved=0)
> > >
> > > Pull Request:
> > > This closes #1142 <https://na01.safelinks.protec
> > > tion.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%
> > > 2Freef%2Fpull%2F1142&data=01%7C01%7Cmamykhai%40microsoft.
> > > com%7Cd3ccbd8898604b4fc16c08d3ebef9bd0%7C72f988bf86f141af91a
> > > b2d7cd011db47%7C1&sdata=HpdqNGdwXs%2F9gR%2BBx%2FOXhlGQi%2FZRTFGnGCCs%
> > > 2BKgn8MA%3D&reserved=0>
> > >
> > >
> > > On Mon, Oct 3, 2016 at 5:22 PM, Sergiy Matusevych <
> > > sergiy.matusevych@gmail.com> wrote:
> > >
> > > > Hi REEF devs,
> > > >
> > > > Can someone try to build current master from scratch? I am getting
> the
> > > > following error:
> > > >
> > > > [exec]
> > > > C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-
> > > > wake\wake/../../../../lang/common/proto/RemoteProtocol.proto:
> > > > File does not reside within any path specified using --proto_path (or
> > > -I).
> > > > You must specify a --proto_path which encompasses this file. Note
> > > > that the proto_path must be an exact prefix of the .proto file names
> > > > -- protoc is too dumb to figure out when two paths (e.g. absolute and
> > > > relative) are equivalent (it's harder than you think).
> > > >
> > > > and eventually it complains that java files that should be generated
> > > > from proto are not there. :(
> > > >
> > > > I've removed ~/.m2 and cloned the whole repo anew but I am still
> > > > getting this error. Am I the only one getting this error? Any ideas
> on
> > > > how to fix it?
> > > >
> > > > Thanks,
> > > > Sergiy.
> > > >
> > >
> >
>
>
>
> --
>
> On Mon, Oct 3, 2016 at 5:50 PM, Markus Weimer <ma...@weimo.de> wrote:
> On Mon, Oct 3, 2016 at 4:55 PM, Douglas Service <ds...@gmail.com> wrote:
> > Questions:
> > 1) If the extra messages are not used by both sides they should probably
> > not be in this file. Will these messages be shared in the futur
>
Re: REEFJava build fails on Windows?
Posted by Douglas Service <ds...@gmail.com>.
I am able to build the java build on Windows and protoc runs with no
problems. An example of the internal maven paths is below which are all
Unix style and work fine on windows. Are you modifying the proto files?
Doug
<properties>
<rootPath>${basedir}/../../..</rootPath>
<protoPath>${rootPath}/lang/common/proto</protoPath>
</properties>
<exec executable="protoc">
<arg value="--proto_path=${protoPath}"/>
<arg value="--java_out=target/generated-sources/proto"/>
<arg value="${protoPath}/reef_service_protos.proto"/>
<arg value="${protoPath}/evaluator_runtime.proto"/>
<arg value="${protoPath}/client_runtime.proto"/>
<arg value="${protoPath}/reef_protocol.proto"/>
</exec>
On Mon, Oct 3, 2016 at 6:58 PM, Sergiy Matusevych <
sergiy.matusevych@gmail.com> wrote:
> Hi guys,
>
> I think I've figured out what's going on. protoc chokes on Windows-style
> paths. I've just ran mvn -X, and the command it executes on my PC is:
>
> cd C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-wake\wake
>
> protoc --proto_path=C:\Users\sergiym.REDMOND\devel\reef\lang\java\
> reef-wake\wake/../../../../lang/common/proto
> --java_out=target/generated-sources/proto
> C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-
> wake\wake/../../../../lang/common/proto/RemoteProtocol.proto
>
> and it fails. When I replace the path with unix-style relative path,
> everything works, i.e.
>
> protoc --proto_path=../../../common/proto
> --java_out=target/generated-sources/proto
> ../../../common/proto/RemoteProtocol.proto
>
> For now, I will just compile the proto files by hand, but I guess
> eventually we will need to fix the pom.xml
>
> Thanks for your help!
> Sergiy.
>
>
> On Mon, Oct 3, 2016 at 5:49 PM, Mariia Mykhailova <ma...@microsoft.com>
> wrote:
>
> > Interesting, I did get some failures after syncing to this commit, but
> for
> > me it was sufficient to do a regular .NET clean for everything to start
> > working again.
> >
> > function Clean-REEF-NET{
> > Invoke-Expression 'msbuild $REEFSourcePath\lang\cs\Org.
> Apache.REEF.sln
> > /p:Configuration="Debug" /p:Platform="x64" /t:Clean /m /nr:false'
> > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter obj
> > | Remove-Item -Recurse
> > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter bin
> > | Remove-Item -Recurse
> > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter target
> > | Remove-Item -Recurse
> > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter
> > REEF_LOCAL_RUNTIME | Remove-Item -Recurse
> > Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter
> > TestResults | Remove-Item -Recurse
> > }
> >
> > -Mariia
> >
> > -----Original Message-----
> > From: Douglas Service [mailto:dsopsrc@gmail.com]
> > Sent: Monday, October 3, 2016 5:44 PM
> > To: dev@reef.apache.org
> > Subject: Re: REEFJava build fails on Windows?
> >
> > I just synced to Apache reef master and it builds. Your problem is
> > probably from the commit below. I put a warning in the commit message
> since
> > I had a very similar problem where I was getting test errors. To fix the
> > problem, I ended up pushing all of my branches to github deleting my
> > enlistment and then cloning my copy of REEF on github. You could probably
> > also do a clean, roll back to the commit just before this one, do a
> clean,
> > and then pull the latestest. I verified the problem only occurs if you do
> > not do a clean in Visual Studio and Maven before syncing to the commit.
> > There was some discussion on the dev list, but we probably need a better
> > way to let every know about these kinds of issues.
> >
> > Doug
> >
> > [REEF-1611] Move Java .proto files to common directory
> >
> > This change moves the Java .proto files to lang/common/proto so the C#
> > side can use the same proto files.
> >
> > WARNING: Before pulling this change you should clean both the Java and C#
> > builds; otherwise, you will have artifacts this version cannot remove
> that
> > cause test failures on the C# side.
> >
> > JIRA:
> > [REEF-1611](https://na01.safelinks.protection.outlook.com/?
> > url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FREEF-
> > 1611&data=01%7C01%7Cmamykhai%40microsoft.com%7Cd3ccbd889860
> > 4b4fc16c08d3ebef9bd0%7C72f988bf86f141af91ab2d7cd011db47%7C1&
> > sdata=%2B93eDf2dKPIbgXr%2FVLPmBqFUNm65EFxpMPcNMde2tsI%3D&reserved=0)
> >
> > Pull Request:
> > This closes #1142 <https://na01.safelinks.protec
> > tion.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%
> > 2Freef%2Fpull%2F1142&data=01%7C01%7Cmamykhai%40microsoft.
> > com%7Cd3ccbd8898604b4fc16c08d3ebef9bd0%7C72f988bf86f141af91a
> > b2d7cd011db47%7C1&sdata=HpdqNGdwXs%2F9gR%2BBx%2FOXhlGQi%2FZRTFGnGCCs%
> > 2BKgn8MA%3D&reserved=0>
> >
> >
> > On Mon, Oct 3, 2016 at 5:22 PM, Sergiy Matusevych <
> > sergiy.matusevych@gmail.com> wrote:
> >
> > > Hi REEF devs,
> > >
> > > Can someone try to build current master from scratch? I am getting the
> > > following error:
> > >
> > > [exec]
> > > C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-
> > > wake\wake/../../../../lang/common/proto/RemoteProtocol.proto:
> > > File does not reside within any path specified using --proto_path (or
> > -I).
> > > You must specify a --proto_path which encompasses this file. Note
> > > that the proto_path must be an exact prefix of the .proto file names
> > > -- protoc is too dumb to figure out when two paths (e.g. absolute and
> > > relative) are equivalent (it's harder than you think).
> > >
> > > and eventually it complains that java files that should be generated
> > > from proto are not there. :(
> > >
> > > I've removed ~/.m2 and cloned the whole repo anew but I am still
> > > getting this error. Am I the only one getting this error? Any ideas on
> > > how to fix it?
> > >
> > > Thanks,
> > > Sergiy.
> > >
> >
>
--
On Mon, Oct 3, 2016 at 5:50 PM, Markus Weimer <ma...@weimo.de> wrote:
On Mon, Oct 3, 2016 at 4:55 PM, Douglas Service <ds...@gmail.com> wrote:
> Questions:
> 1) If the extra messages are not used by both sides they should probably
> not be in this file. Will these messages be shared in the futur
Re: REEFJava build fails on Windows?
Posted by Sergiy Matusevych <se...@gmail.com>.
Hi guys,
I think I've figured out what's going on. protoc chokes on Windows-style
paths. I've just ran mvn -X, and the command it executes on my PC is:
cd C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-wake\wake
protoc --proto_path=C:\Users\sergiym.REDMOND\devel\reef\lang\java\
reef-wake\wake/../../../../lang/common/proto
--java_out=target/generated-sources/proto
C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-
wake\wake/../../../../lang/common/proto/RemoteProtocol.proto
and it fails. When I replace the path with unix-style relative path,
everything works, i.e.
protoc --proto_path=../../../common/proto
--java_out=target/generated-sources/proto
../../../common/proto/RemoteProtocol.proto
For now, I will just compile the proto files by hand, but I guess
eventually we will need to fix the pom.xml
Thanks for your help!
Sergiy.
On Mon, Oct 3, 2016 at 5:49 PM, Mariia Mykhailova <ma...@microsoft.com>
wrote:
> Interesting, I did get some failures after syncing to this commit, but for
> me it was sufficient to do a regular .NET clean for everything to start
> working again.
>
> function Clean-REEF-NET{
> Invoke-Expression 'msbuild $REEFSourcePath\lang\cs\Org.Apache.REEF.sln
> /p:Configuration="Debug" /p:Platform="x64" /t:Clean /m /nr:false'
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter obj
> | Remove-Item -Recurse
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter bin
> | Remove-Item -Recurse
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter target
> | Remove-Item -Recurse
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter
> REEF_LOCAL_RUNTIME | Remove-Item -Recurse
> Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter
> TestResults | Remove-Item -Recurse
> }
>
> -Mariia
>
> -----Original Message-----
> From: Douglas Service [mailto:dsopsrc@gmail.com]
> Sent: Monday, October 3, 2016 5:44 PM
> To: dev@reef.apache.org
> Subject: Re: REEFJava build fails on Windows?
>
> I just synced to Apache reef master and it builds. Your problem is
> probably from the commit below. I put a warning in the commit message since
> I had a very similar problem where I was getting test errors. To fix the
> problem, I ended up pushing all of my branches to github deleting my
> enlistment and then cloning my copy of REEF on github. You could probably
> also do a clean, roll back to the commit just before this one, do a clean,
> and then pull the latestest. I verified the problem only occurs if you do
> not do a clean in Visual Studio and Maven before syncing to the commit.
> There was some discussion on the dev list, but we probably need a better
> way to let every know about these kinds of issues.
>
> Doug
>
> [REEF-1611] Move Java .proto files to common directory
>
> This change moves the Java .proto files to lang/common/proto so the C#
> side can use the same proto files.
>
> WARNING: Before pulling this change you should clean both the Java and C#
> builds; otherwise, you will have artifacts this version cannot remove that
> cause test failures on the C# side.
>
> JIRA:
> [REEF-1611](https://na01.safelinks.protection.outlook.com/?
> url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FREEF-
> 1611&data=01%7C01%7Cmamykhai%40microsoft.com%7Cd3ccbd889860
> 4b4fc16c08d3ebef9bd0%7C72f988bf86f141af91ab2d7cd011db47%7C1&
> sdata=%2B93eDf2dKPIbgXr%2FVLPmBqFUNm65EFxpMPcNMde2tsI%3D&reserved=0)
>
> Pull Request:
> This closes #1142 <https://na01.safelinks.protec
> tion.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%
> 2Freef%2Fpull%2F1142&data=01%7C01%7Cmamykhai%40microsoft.
> com%7Cd3ccbd8898604b4fc16c08d3ebef9bd0%7C72f988bf86f141af91a
> b2d7cd011db47%7C1&sdata=HpdqNGdwXs%2F9gR%2BBx%2FOXhlGQi%2FZRTFGnGCCs%
> 2BKgn8MA%3D&reserved=0>
>
>
> On Mon, Oct 3, 2016 at 5:22 PM, Sergiy Matusevych <
> sergiy.matusevych@gmail.com> wrote:
>
> > Hi REEF devs,
> >
> > Can someone try to build current master from scratch? I am getting the
> > following error:
> >
> > [exec]
> > C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-
> > wake\wake/../../../../lang/common/proto/RemoteProtocol.proto:
> > File does not reside within any path specified using --proto_path (or
> -I).
> > You must specify a --proto_path which encompasses this file. Note
> > that the proto_path must be an exact prefix of the .proto file names
> > -- protoc is too dumb to figure out when two paths (e.g. absolute and
> > relative) are equivalent (it's harder than you think).
> >
> > and eventually it complains that java files that should be generated
> > from proto are not there. :(
> >
> > I've removed ~/.m2 and cloned the whole repo anew but I am still
> > getting this error. Am I the only one getting this error? Any ideas on
> > how to fix it?
> >
> > Thanks,
> > Sergiy.
> >
>
RE: REEFJava build fails on Windows?
Posted by Mariia Mykhailova <ma...@microsoft.com>.
Interesting, I did get some failures after syncing to this commit, but for me it was sufficient to do a regular .NET clean for everything to start working again.
function Clean-REEF-NET{
Invoke-Expression 'msbuild $REEFSourcePath\lang\cs\Org.Apache.REEF.sln /p:Configuration="Debug" /p:Platform="x64" /t:Clean /m /nr:false'
Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter obj | Remove-Item -Recurse
Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter bin | Remove-Item -Recurse
Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter target | Remove-Item -Recurse
Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter REEF_LOCAL_RUNTIME | Remove-Item -Recurse
Get-ChildItem -Path $REEFSourcePath\lang\cs\ -Recurse -Filter TestResults | Remove-Item -Recurse
}
-Mariia
-----Original Message-----
From: Douglas Service [mailto:dsopsrc@gmail.com]
Sent: Monday, October 3, 2016 5:44 PM
To: dev@reef.apache.org
Subject: Re: REEFJava build fails on Windows?
I just synced to Apache reef master and it builds. Your problem is probably from the commit below. I put a warning in the commit message since I had a very similar problem where I was getting test errors. To fix the problem, I ended up pushing all of my branches to github deleting my enlistment and then cloning my copy of REEF on github. You could probably also do a clean, roll back to the commit just before this one, do a clean, and then pull the latestest. I verified the problem only occurs if you do not do a clean in Visual Studio and Maven before syncing to the commit. There was some discussion on the dev list, but we probably need a better way to let every know about these kinds of issues.
Doug
[REEF-1611] Move Java .proto files to common directory
This change moves the Java .proto files to lang/common/proto so the C# side can use the same proto files.
WARNING: Before pulling this change you should clean both the Java and C# builds; otherwise, you will have artifacts this version cannot remove that cause test failures on the C# side.
JIRA:
[REEF-1611](https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FREEF-1611&data=01%7C01%7Cmamykhai%40microsoft.com%7Cd3ccbd8898604b4fc16c08d3ebef9bd0%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=%2B93eDf2dKPIbgXr%2FVLPmBqFUNm65EFxpMPcNMde2tsI%3D&reserved=0)
Pull Request:
This closes #1142 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Freef%2Fpull%2F1142&data=01%7C01%7Cmamykhai%40microsoft.com%7Cd3ccbd8898604b4fc16c08d3ebef9bd0%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=HpdqNGdwXs%2F9gR%2BBx%2FOXhlGQi%2FZRTFGnGCCs%2BKgn8MA%3D&reserved=0>
On Mon, Oct 3, 2016 at 5:22 PM, Sergiy Matusevych < sergiy.matusevych@gmail.com> wrote:
> Hi REEF devs,
>
> Can someone try to build current master from scratch? I am getting the
> following error:
>
> [exec]
> C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-
> wake\wake/../../../../lang/common/proto/RemoteProtocol.proto:
> File does not reside within any path specified using --proto_path (or -I).
> You must specify a --proto_path which encompasses this file. Note
> that the proto_path must be an exact prefix of the .proto file names
> -- protoc is too dumb to figure out when two paths (e.g. absolute and
> relative) are equivalent (it's harder than you think).
>
> and eventually it complains that java files that should be generated
> from proto are not there. :(
>
> I've removed ~/.m2 and cloned the whole repo anew but I am still
> getting this error. Am I the only one getting this error? Any ideas on
> how to fix it?
>
> Thanks,
> Sergiy.
>
Re: REEFJava build fails on Windows?
Posted by Douglas Service <ds...@gmail.com>.
I just synced to Apache reef master and it builds. Your problem is probably
from the commit below. I put a warning in the commit message since I had a
very similar problem where I was getting test errors. To fix the problem, I
ended up pushing all of my branches to github deleting my enlistment and
then cloning my copy of REEF on github. You could probably also do a clean,
roll back to the commit just before this one, do a clean, and then pull the
latestest. I verified the problem only occurs if you do not do a clean in
Visual Studio and Maven before syncing to the commit. There was some
discussion on the dev list, but we probably need a better way to let every
know about these kinds of issues.
Doug
[REEF-1611] Move Java .proto files to common directory
This change moves the Java .proto files to lang/common/proto so
the C# side can use the same proto files.
WARNING: Before pulling this change you should clean both the
Java and C# builds; otherwise, you will have artifacts this
version cannot remove that cause test failures on the C# side.
JIRA:
[REEF-1611](https://issues.apache.org/jira/browse/REEF-1611)
Pull Request:
This closes #1142 <https://github.com/apache/reef/pull/1142>
On Mon, Oct 3, 2016 at 5:22 PM, Sergiy Matusevych <
sergiy.matusevych@gmail.com> wrote:
> Hi REEF devs,
>
> Can someone try to build current master from scratch? I am getting the
> following error:
>
> [exec]
> C:\Users\sergiym.REDMOND\devel\reef\lang\java\reef-
> wake\wake/../../../../lang/common/proto/RemoteProtocol.proto:
> File does not reside within any path specified using --proto_path (or -I).
> You must specify a --proto_path which encompasses this file. Note that the
> proto_path must be an exact prefix of the .proto file names -- protoc is
> too dumb to figure out when two paths (e.g. absolute and relative) are
> equivalent (it's harder than you think).
>
> and eventually it complains that java files that should be generated from
> proto are not there. :(
>
> I've removed ~/.m2 and cloned the whole repo anew but I am still getting
> this error. Am I the only one getting this error? Any ideas on how to fix
> it?
>
> Thanks,
> Sergiy.
>