[GitHub] [gobblin] phet commented on a diff in pull request #3627: Specifically name each Hikari connection pool created, for traceability

["phet (via GitHub)" <gi...@apache.org>]

phet commented on code in PR #3627:
URL: https://github.com/apache/gobblin/pull/3627#discussion_r1083143470


##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -74,7 +74,7 @@ public class ConfigurationKeys {
   public static final boolean DEFAULT_STATE_STORE_COMPRESSED_VALUES = true;
   // DB state store configuration
   public static final String STATE_STORE_DB_JDBC_DRIVER_KEY = "state.store.db.jdbc.driver";
-  public static final String DEFAULT_STATE_STORE_DB_JDBC_DRIVER = "com.mysql.jdbc.Driver";

Review Comment:
   sorry those may have landed while this was under development... now fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org