You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Carl-Eric Menzel (JIRA)" <ji...@apache.org> on 2012/05/07 15:00:51 UTC
[jira] [Created] (WICKET-4537) Add Generics to TabbedPanel:
Carl-Eric Menzel created WICKET-4537:
----------------------------------------
Summary: Add Generics to TabbedPanel: <T extends ITab>
Key: WICKET-4537
URL: https://issues.apache.org/jira/browse/WICKET-4537
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 6.0.0-beta1, 1.5.6
Reporter: Carl-Eric Menzel
Assignee: Carl-Eric Menzel
In 1.5, TabbedPanel#tabs has a wildcard signature: List<? extends ITab>. This makes it impossible to add tabs to that list, even though adding panels is one of the stated purposes of the #getTabs() method.
On #wicket, dashorst suggested giving TabbedPanel a type parameter <T extends ITab>, which I think is a good idea. It should definitely be added in 6.0.
What about 1.5.x? This would be a source-level break, but I *think* binaries should still work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4537) Add Generics to TabbedPanel:
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4537:
------------------------------------
Fix Version/s: 6.0.0
> Add Generics to TabbedPanel: <T extends ITab>
> ---------------------------------------------
>
> Key: WICKET-4537
> URL: https://issues.apache.org/jira/browse/WICKET-4537
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: Carl-Eric Menzel
> Assignee: Carl-Eric Menzel
> Fix For: 6.0.0
>
>
> In 1.5, TabbedPanel#tabs has a wildcard signature: List<? extends ITab>. This makes it impossible to add tabs to that list, even though adding panels is one of the stated purposes of the #getTabs() method.
> On #wicket, dashorst suggested giving TabbedPanel a type parameter <T extends ITab>, which I think is a good idea. It should definitely be added in 6.0.
> What about 1.5.x? This would be a source-level break, but I *think* binaries should still work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4537) Add Generics to TabbedPanel:
Posted by "Carl-Eric Menzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl-Eric Menzel resolved WICKET-4537.
--------------------------------------
Resolution: Fixed
Pushed to master and wicket-1.5.x.
clirr didn't complain, so I'm assuming this is not breaking anything, at least not in binaries. It can easily be reverted in case of problems.
> Add Generics to TabbedPanel: <T extends ITab>
> ---------------------------------------------
>
> Key: WICKET-4537
> URL: https://issues.apache.org/jira/browse/WICKET-4537
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: Carl-Eric Menzel
> Assignee: Carl-Eric Menzel
> Fix For: 1.5.7, 6.0.0
>
>
> In 1.5, TabbedPanel#tabs has a wildcard signature: List<? extends ITab>. This makes it impossible to add tabs to that list, even though adding panels is one of the stated purposes of the #getTabs() method.
> On #wicket, dashorst suggested giving TabbedPanel a type parameter <T extends ITab>, which I think is a good idea. It should definitely be added in 6.0.
> What about 1.5.x? This would be a source-level break, but I *think* binaries should still work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4537) Add Generics to TabbedPanel:
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4537:
------------------------------------
Fix Version/s: (was: 6.0.0)
6.0.0-beta2
> Add Generics to TabbedPanel: <T extends ITab>
> ---------------------------------------------
>
> Key: WICKET-4537
> URL: https://issues.apache.org/jira/browse/WICKET-4537
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: Carl-Eric Menzel
> Assignee: Carl-Eric Menzel
> Fix For: 6.0.0-beta2, 1.5.7
>
>
> In 1.5, TabbedPanel#tabs has a wildcard signature: List<? extends ITab>. This makes it impossible to add tabs to that list, even though adding panels is one of the stated purposes of the #getTabs() method.
> On #wicket, dashorst suggested giving TabbedPanel a type parameter <T extends ITab>, which I think is a good idea. It should definitely be added in 6.0.
> What about 1.5.x? This would be a source-level break, but I *think* binaries should still work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4537) Add Generics to TabbedPanel:
Posted by "Carl-Eric Menzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278730#comment-13278730 ]
Carl-Eric Menzel commented on WICKET-4537:
------------------------------------------
I have it locally in master now, but I'm going to add some test cases before committing it. As far as I can tell, TabbedPannel has *no* testcases so far.
I'd still like an opinion whether this would be an acceptable change for 1.5. Right now, getTabs() does not do what its javadoc claims it does, since the type signature prevents user code from adding tabs.
> Add Generics to TabbedPanel: <T extends ITab>
> ---------------------------------------------
>
> Key: WICKET-4537
> URL: https://issues.apache.org/jira/browse/WICKET-4537
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: Carl-Eric Menzel
> Assignee: Carl-Eric Menzel
> Fix For: 6.0.0
>
>
> In 1.5, TabbedPanel#tabs has a wildcard signature: List<? extends ITab>. This makes it impossible to add tabs to that list, even though adding panels is one of the stated purposes of the #getTabs() method.
> On #wicket, dashorst suggested giving TabbedPanel a type parameter <T extends ITab>, which I think is a good idea. It should definitely be added in 6.0.
> What about 1.5.x? This would be a source-level break, but I *think* binaries should still work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4537) Add Generics to TabbedPanel:
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278731#comment-13278731 ]
Martin Grigorov commented on WICKET-4537:
-----------------------------------------
clirr-maven-plugin is configured in pom.xml.
You can run it and see whether it reports problems after the change.
> Add Generics to TabbedPanel: <T extends ITab>
> ---------------------------------------------
>
> Key: WICKET-4537
> URL: https://issues.apache.org/jira/browse/WICKET-4537
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: Carl-Eric Menzel
> Assignee: Carl-Eric Menzel
> Fix For: 6.0.0
>
>
> In 1.5, TabbedPanel#tabs has a wildcard signature: List<? extends ITab>. This makes it impossible to add tabs to that list, even though adding panels is one of the stated purposes of the #getTabs() method.
> On #wicket, dashorst suggested giving TabbedPanel a type parameter <T extends ITab>, which I think is a good idea. It should definitely be added in 6.0.
> What about 1.5.x? This would be a source-level break, but I *think* binaries should still work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4537) Add Generics to TabbedPanel:
Posted by "Carl-Eric Menzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl-Eric Menzel updated WICKET-4537:
-------------------------------------
Fix Version/s: 1.5.7
> Add Generics to TabbedPanel: <T extends ITab>
> ---------------------------------------------
>
> Key: WICKET-4537
> URL: https://issues.apache.org/jira/browse/WICKET-4537
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: Carl-Eric Menzel
> Assignee: Carl-Eric Menzel
> Fix For: 1.5.7, 6.0.0
>
>
> In 1.5, TabbedPanel#tabs has a wildcard signature: List<? extends ITab>. This makes it impossible to add tabs to that list, even though adding panels is one of the stated purposes of the #getTabs() method.
> On #wicket, dashorst suggested giving TabbedPanel a type parameter <T extends ITab>, which I think is a good idea. It should definitely be added in 6.0.
> What about 1.5.x? This would be a source-level break, but I *think* binaries should still work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira