You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/23 13:08:21 UTC

[GitHub] [spark] srowen commented on pull request #35630: [SPARK-38287][BUILD][SQL] Upgrade `h2` from 2.0.204 to 2.1.210 in /sql/core

srowen commented on pull request #35630:
URL: https://github.com/apache/spark/pull/35630#issuecomment-1048763930


   Looking OK though you may have to run `./dev/test-dependencies.sh --replace_manifest` to update the files we use to detect dependency changes.
   
   But it's a test-only dependency, so this doesn't actually affect Spark at runtime, and may not show up.
   
   I think it's OK to update but Spark wouldn't be susceptible to any CVE if it does not use h2 itself. Is the security scanner flagging test-only dependencies or marking them as such? if not it should; if it does, you can generally not worry about them as an end user. But if they're trivial to update, sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org