You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/05/29 23:39:47 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41357: [SPARK-43790][PYTHON][CONNECT][ML] Add `copyFromLocalToFS` API

HyukjinKwon commented on code in PR #41357:
URL: https://github.com/apache/spark/pull/41357#discussion_r1209592404


##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -1240,6 +1240,9 @@ def _handle_rpc_error(self, rpc_error: grpc.RpcError) -> NoReturn:
     def add_artifacts(self, *path: str, pyfile: bool, archive: bool) -> None:
         self._artifact_manager.add_artifacts(*path, pyfile=pyfile, archive=archive)
 
+    def copy_from_local_to_FS(self, local_path: str, dest_path: str) -> None:

Review Comment:
   `copy_from_local_to_FS` -> `copy_from_local_to_fs`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org