You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@brightroll.com> on 2015/10/14 01:13:19 UTC

Review Request 39296: SQOOP-1732

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39296/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1732
    https://issues.apache.org/jira/browse/SQOOP-1732


Repository: sqoop-sqoop2


Description
-------

Sqoop2: Add version to connector upgrade API


Diffs
-----

  connector/connector-ftp/src/main/java/org/apache/sqoop/connector/ftp/FtpConnector.java ffef1bf 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java c233ed5 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 2d5ba58 
  connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnector.java e3eafe8 
  connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java 5f58a90 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java bfd5f23 
  connector/connector-sftp/src/main/java/org/apache/sqoop/connector/sftp/SftpConnector.java c2ce8da 
  core/src/main/java/org/apache/sqoop/driver/Driver.java cff2bef 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 055ccc4 
  core/src/main/java/org/apache/sqoop/repository/Repository.java cc29e39 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 1d630a9 
  docs/src/site/sphinx/ConnectorDevelopment.rst 60dae3f 
  test/src/test/resources/TestConnector/TestConnector.java d58a824 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 244683d 

Diff: https://reviews.apache.org/r/39296/diff/


Testing
-------

yes


Thanks,

Abraham Fine


Re: Review Request 39296: SQOOP-1732

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39296/#review102708
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Oct. 14, 2015, 7:41 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39296/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 7:41 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1732
>     https://issues.apache.org/jira/browse/SQOOP-1732
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: Add version to connector upgrade API
> 
> 
> Diffs
> -----
> 
>   connector/connector-ftp/src/main/java/org/apache/sqoop/connector/ftp/FtpConnector.java ffef1bf 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java c233ed5 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 2d5ba58 
>   connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnector.java e3eafe8 
>   connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java 5f58a90 
>   connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java bfd5f23 
>   connector/connector-sftp/src/main/java/org/apache/sqoop/connector/sftp/SftpConnector.java c2ce8da 
>   core/src/main/java/org/apache/sqoop/driver/Driver.java c4f84d6 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 055ccc4 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 144e419 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 78728f6 
>   docs/src/site/sphinx/ConnectorDevelopment.rst 60dae3f 
>   test/src/test/resources/TestConnector/TestConnector.java d58a824 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 2ac8ce8 
> 
> Diff: https://reviews.apache.org/r/39296/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>


Re: Review Request 39296: SQOOP-1732

Posted by Abraham Fine <ab...@brightroll.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39296/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 7:41 p.m.)


Review request for Sqoop.


Bugs: SQOOP-1732
    https://issues.apache.org/jira/browse/SQOOP-1732


Repository: sqoop-sqoop2


Description
-------

Sqoop2: Add version to connector upgrade API


Diffs (updated)
-----

  connector/connector-ftp/src/main/java/org/apache/sqoop/connector/ftp/FtpConnector.java ffef1bf 
  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java c233ed5 
  connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConnector.java 2d5ba58 
  connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnector.java e3eafe8 
  connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnector.java 5f58a90 
  connector/connector-sdk/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java bfd5f23 
  connector/connector-sftp/src/main/java/org/apache/sqoop/connector/sftp/SftpConnector.java c2ce8da 
  core/src/main/java/org/apache/sqoop/driver/Driver.java c4f84d6 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 055ccc4 
  core/src/main/java/org/apache/sqoop/repository/Repository.java 144e419 
  core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java 78728f6 
  docs/src/site/sphinx/ConnectorDevelopment.rst 60dae3f 
  test/src/test/resources/TestConnector/TestConnector.java d58a824 
  tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 2ac8ce8 

Diff: https://reviews.apache.org/r/39296/diff/


Testing
-------

yes


Thanks,

Abraham Fine