Re: [PR] CASSANDRA-19201: Refactor cqlshmain global constants [cassandra]

["smiklosovic (via GitHub)" <gi...@apache.org>]

smiklosovic commented on code in PR #3003:
URL: https://github.com/apache/cassandra/pull/3003#discussion_r1489047599


##########
pylib/cqlshlib/cqlshmain.py:
##########
@@ -2206,30 +2126,15 @@ def read_options(cmdlineargs, environment=os.environ):
         parser.error('%r is not a valid port number.' % port)
     return options, hostname, port
 
-
-def setup_cqlruleset():
-    global cqlruleset
-    cqlruleset = cql3handling.CqlRuleSet
-    cqlruleset.append_rules(cqlshhandling.cqlsh_extra_syntax_rules)
-    for rulename, termname, func in cqlshhandling.cqlsh_syntax_completers:
-        cqlruleset.completer_for(rulename, termname)(func)
-    cqlruleset.commands_end_with_newline.update(cqlshhandling.my_commands_ending_with_newline)
-
-
-def setup_docspath(path):
-    global CASSANDRA_CQL_HTML
-    CASSANDRA_CQL_HTML_FALLBACK = 'https://cassandra.apache.org/doc/latest/cassandra/cql/cql_singlefile.html'

Review Comment:
   @bschoening where did this go?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org