You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by as...@apache.org on 2020/04/21 08:15:34 UTC

[mesos] 01/02: Fixed composing authorization callback path on Windows.

This is an automated email from the ASF dual-hosted git repository.

asekretenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git

commit 6e0a686eb88524f000dab6cae5de5a582d3e2ded
Author: Andrei Sekretenko <as...@apache.org>
AuthorDate: Mon Apr 20 12:54:10 2020 +0200

    Fixed composing authorization callback path on Windows.
    
    Review: https://reviews.apache.org/r/72389
---
 3rdparty/libprocess/src/process.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/3rdparty/libprocess/src/process.cpp b/3rdparty/libprocess/src/process.cpp
index 4ae5de3..88f04f2 100644
--- a/3rdparty/libprocess/src/process.cpp
+++ b/3rdparty/libprocess/src/process.cpp
@@ -3842,7 +3842,11 @@ Future<Response> ProcessBase::_consume(
       Future<bool> authorization = true;
 
       if (authorization_callbacks.load() != nullptr) {
-        const string callback_path = path::join("/" + pid.id, name);
+        // Pass the "/" separator to avoid the windows "\" separator
+        // getting implicitly used on windows (we don't want that to
+        // happen for this http request path!)
+        const string callback_path =
+          path::join("/" + pid.id, name, os::POSIX_PATH_SEPARATOR);
 
         synchronized (authorization_callbacks_mutex) {
           AuthorizationCallbacks* callbacks = authorization_callbacks.load();