[GitHub] [incubator-superset] mistercrunch opened a new pull request #8215: chore: fix flaky SQL Lab test with .focus().blur()

[GitBox <gi...@apache.org>]

mistercrunch opened a new pull request #8215: chore: fix flaky SQL Lab test with .focus().blur()
URL: https://github.com/apache/incubator-superset/pull/8215
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [x] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Second attempt at fixing the flaky cypress SQL Lab test. My intuition is that `.focus().blur()` is needed to insure that the store gets updated. With redux getting save to local storage onChange, it takes some millisecs to save that payload, so we prevent updating the store as it makes typing SQL laggy, and only commit to the store on blur.
   
   Guessing there's a timing issue where blur may not occur in time, so trying to be explicit about it. For reference, other tests were doing this more explicitly before, so extending the approach to all tests touching Ace editor.
   
   🤞 🤞 🤞 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org