You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stephen Connolly (JIRA)" <ji...@apache.org> on 2010/12/13 14:50:19 UTC

[jira] Created: (CASSANDRA-1850) When the ANTLR code generation fails the build continues and ignores the failure

When the ANTLR code generation fails the build continues and ignores the failure
--------------------------------------------------------------------------------

                 Key: CASSANDRA-1850
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1850
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 0.7.0
            Reporter: Stephen Connolly
            Priority: Trivial
         Attachments: fail-build-if-codegen-fails.patch

When trying to tweak the build, I broke the ANTLR code generation tasks, but as I was not doing a full clean build the generated code was still present, so I missed the fact that the code generation was broken. It would be nice if the antlr tasks had failonerror="true"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1850) When the ANTLR code generation fails the build continues and ignores the failure

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970994#action_12970994 ] 

Eric Evans commented on CASSANDRA-1850:
---------------------------------------

committed; thanks.

> When the ANTLR code generation fails the build continues and ignores the failure
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1850
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Stephen Connolly
>            Assignee: Stephen Connolly
>            Priority: Trivial
>             Fix For: 0.7.0
>
>         Attachments: fail-build-if-codegen-fails.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When trying to tweak the build, I broke the ANTLR code generation tasks, but as I was not doing a full clean build the generated code was still present, so I missed the fact that the code generation was broken. It would be nice if the antlr tasks had failonerror="true"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1850) When the ANTLR code generation fails the build continues and ignores the failure

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Evans updated CASSANDRA-1850:
----------------------------------

    Reviewer: urandom

> When the ANTLR code generation fails the build continues and ignores the failure
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1850
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Stephen Connolly
>            Priority: Trivial
>         Attachments: fail-build-if-codegen-fails.patch
>
>
> When trying to tweak the build, I broke the ANTLR code generation tasks, but as I was not doing a full clean build the generated code was still present, so I missed the fact that the code generation was broken. It would be nice if the antlr tasks had failonerror="true"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1850) When the ANTLR code generation fails the build continues and ignores the failure

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Evans updated CASSANDRA-1850:
----------------------------------

         Fix Version/s: 0.7.0
              Assignee: Stephen Connolly
    Remaining Estimate: 0h
     Original Estimate: 0h

> When the ANTLR code generation fails the build continues and ignores the failure
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1850
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Stephen Connolly
>            Assignee: Stephen Connolly
>            Priority: Trivial
>             Fix For: 0.7.0
>
>         Attachments: fail-build-if-codegen-fails.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When trying to tweak the build, I broke the ANTLR code generation tasks, but as I was not doing a full clean build the generated code was still present, so I missed the fact that the code generation was broken. It would be nice if the antlr tasks had failonerror="true"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1850) When the ANTLR code generation fails the build continues and ignores the failure

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971013#action_12971013 ] 

Hudson commented on CASSANDRA-1850:
-----------------------------------

Integrated in Cassandra #625 (See [https://hudson.apache.org/hudson/job/Cassandra/625/])
    failonerror for Cql and Cli antlr generation targets

Patch by Stephen Connolly; reviewed by eevans for CASSANDRA-1850


> When the ANTLR code generation fails the build continues and ignores the failure
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1850
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Stephen Connolly
>            Assignee: Stephen Connolly
>            Priority: Trivial
>             Fix For: 0.7.0
>
>         Attachments: fail-build-if-codegen-fails.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When trying to tweak the build, I broke the ANTLR code generation tasks, but as I was not doing a full clean build the generated code was still present, so I missed the fact that the code generation was broken. It would be nice if the antlr tasks had failonerror="true"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1850) When the ANTLR code generation fails the build continues and ignores the failure

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971009#action_12971009 ] 

Hudson commented on CASSANDRA-1850:
-----------------------------------

Integrated in Cassandra-0.7 #74 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/74/])
    failonerror for Cli antlr generation target

Patch by Stephen Connolly; reviewed by eevans for CASSANDRA-1850


> When the ANTLR code generation fails the build continues and ignores the failure
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1850
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Stephen Connolly
>            Assignee: Stephen Connolly
>            Priority: Trivial
>             Fix For: 0.7.0
>
>         Attachments: fail-build-if-codegen-fails.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When trying to tweak the build, I broke the ANTLR code generation tasks, but as I was not doing a full clean build the generated code was still present, so I missed the fact that the code generation was broken. It would be nice if the antlr tasks had failonerror="true"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1850) When the ANTLR code generation fails the build continues and ignores the failure

Posted by "Stephen Connolly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Connolly updated CASSANDRA-1850:
----------------------------------------

    Attachment: fail-build-if-codegen-fails.patch

patch to fix this issue

> When the ANTLR code generation fails the build continues and ignores the failure
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1850
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Stephen Connolly
>            Priority: Trivial
>         Attachments: fail-build-if-codegen-fails.patch
>
>
> When trying to tweak the build, I broke the ANTLR code generation tasks, but as I was not doing a full clean build the generated code was still present, so I missed the fact that the code generation was broken. It would be nice if the antlr tasks had failonerror="true"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-1850) When the ANTLR code generation fails the build continues and ignores the failure

Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Evans resolved CASSANDRA-1850.
-----------------------------------

    Resolution: Fixed

> When the ANTLR code generation fails the build continues and ignores the failure
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1850
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1850
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Stephen Connolly
>            Assignee: Stephen Connolly
>            Priority: Trivial
>             Fix For: 0.7.0
>
>         Attachments: fail-build-if-codegen-fails.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When trying to tweak the build, I broke the ANTLR code generation tasks, but as I was not doing a full clean build the generated code was still present, so I missed the fact that the code generation was broken. It would be nice if the antlr tasks had failonerror="true"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.