You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by an...@apache.org on 2014/03/07 16:29:23 UTC
svn commit: r1575292 -
/jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java
Author: angela
Date: Fri Mar 7 15:29:23 2014
New Revision: 1575292
URL: http://svn.apache.org/r1575292
Log:
minor improvement
Modified:
jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java
Modified: jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java?rev=1575292&r1=1575291&r2=1575292&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModule.java Fri Mar 7 15:29:23 2014
@@ -103,6 +103,7 @@ public class ExternalLoginModule extends
this.osgiConfig = osgiConfig;
}
+ //--------------------------------------------------------< LoginModule >---
@Override
public void initialize(Subject subject, CallbackHandler callbackHandler, Map<String, ?> ss, Map<String, ?> opts) {
super.initialize(subject, callbackHandler, ss, opts);
@@ -197,16 +198,6 @@ public class ExternalLoginModule extends
return false;
}
- /**
- * @return An immutable set containing only the {@link SimpleCredentials} class.
- */
- @Override
- protected Set<Class> getSupportedCredentials() {
- // TODO: maybe delegate getSupportedCredentials to IDP
- Class scClass = SimpleCredentials.class;
- return Collections.singleton(scClass);
- }
-
@Override
public boolean commit() throws LoginException {
if (externalUser == null || syncHandler == null) {
@@ -247,10 +238,22 @@ public class ExternalLoginModule extends
}
}
+ //------------------------------------------------< AbstractLoginModule >---
+
@Override
protected void clearState() {
super.clearState();
externalUser = null;
credentials = null;
}
+
+ /**
+ * @return An immutable set containing only the {@link SimpleCredentials} class.
+ */
+ @Override
+ protected Set<Class> getSupportedCredentials() {
+ // TODO: maybe delegate getSupportedCredentials to IDP
+ Class scClass = SimpleCredentials.class;
+ return Collections.singleton(scClass);
+ }
}
\ No newline at end of file