You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/21 09:23:26 UTC
[GitHub] [pulsar] momo-jun opened a new pull request, #18152: [improve][doc] Clarify missing tech details
momo-jun opened a new pull request, #18152:
URL: https://github.com/apache/pulsar/pull/18152
### Motivation
This is a WIP to address recently reported issues regarding doc gaps.
### Modifications
1. Clarify the difference between the new S3 offloader and AWS S3 offloader.
2. Clarify both retry letter topic and dead letter topic are implemented by consumers
3. Other minor fixes.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on a diff in pull request #18152: [improve][doc] Clarify missing tech details
Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #18152:
URL: https://github.com/apache/pulsar/pull/18152#discussion_r1005158938
##########
site2/docs/client-libraries-cpp.md:
##########
@@ -394,22 +394,6 @@ Consumer consumer;
client.subscribe("my-topic", "my-sub", conf, consumer);
```
-## Enable authentication in connection URLs
Review Comment:
Dave, thanks for asking. The reasons include:
* Lack of consistency: this section is not available in other clients' docs even though it applies.
* Duplicate: somehow duplicate with the content in the [Connection URL](https://pulsar.apache.org/docs/next/client-libraries-cpp/#connection-urls) section of CPP clients.
* Single-source: the [TLS authentication](https://pulsar.apache.org/docs/next/security-tls-authentication#configure-tls-authentication-in-pulsar-clients) topic has introduced the examples of all clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on a diff in pull request #18152: [improve][doc] Clarify missing tech details
Posted by GitBox <gi...@apache.org>.
dave2wave commented on code in PR #18152:
URL: https://github.com/apache/pulsar/pull/18152#discussion_r1002601008
##########
site2/docs/client-libraries-cpp.md:
##########
@@ -394,22 +394,6 @@ Consumer consumer;
client.subscribe("my-topic", "my-sub", conf, consumer);
```
-## Enable authentication in connection URLs
Review Comment:
Why is this whole section removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun merged pull request #18152: [improve][doc] Clarify missing tech details
Posted by GitBox <gi...@apache.org>.
momo-jun merged PR #18152:
URL: https://github.com/apache/pulsar/pull/18152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org