[GitHub] [helix] qqu0127 commented on a diff in pull request #2180: Reuse zkclient in BestPossibleExternalViewVerifier and fix resource leak

[GitBox <gi...@apache.org>]

qqu0127 commented on code in PR #2180:
URL: https://github.com/apache/helix/pull/2180#discussion_r934120613


##########
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java:
##########
@@ -456,15 +450,17 @@ public String toString() {
        + (_resources != null ? Arrays.toString(_resources.toArray()) : "") + "])";
   }
 
+  // TODO: to clean up, finalize is deprecated in Java 9
   @Override
   public void finalize() {
+    super.finalize();

Review Comment:
   That makes sense, thanks.



##########
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java:
##########
@@ -475,5 +471,10 @@ protected Map<String, ResourceAssignment> computeBestPossibleAssignment(
       return getBestPossibleAssignment(getAssignmentMetadataStore(), currentStateOutput,
           resourceMap.keySet());
     }
+
+    @Override

Review Comment:
   Yeah, it should get from inheritance. I added it for better clarity. I can remove it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org