You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/09/13 06:30:15 UTC

[PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

kou opened a new pull request, #44099:
URL: https://github.com/apache/arrow/pull/44099

   ### Rationale for this change
   
   If we enable C++, Java and Rust, we use the following patterns:
   
   | Producer | Consumer |
   |----------|----------|
   | C++      | C++      |
   | C++      | Java     |
   | C++      | Rust     |
   | Java     | C++      |
   | Java     | Java     |
   | Java     | Rust     |
   | Rust     | C++      |
   | Rust     | Java     |
   | Rust     | Rust     |
   
   In apache/arrow, the following patterns are redundant because they should be done in apache/arrow-rs:
   
   | Producer | Consumer |
   |----------|----------|
   | Rust     | Rust     |
   
   In apache/arror-rs, the following patterns are redundant because they should be done in apache/arrow:
   
   | Producer | Consumer |
   |----------|----------|
   | C++      | C++      |
   | C++      | Java     |
   | Java     | C++      |
   | Java     | Java     |
   
   ### What changes are included in this PR?
   
   Add `--target-language` option. We can specify target languages by this. (We can specify `--target-language` multiple times.) Here are expected usages:
   
   In apache/arrow:
   * `--target-language=cpp`
   * `--target-language=csharp`
   * `--target-language=go`
   * `--target-language=java`
   * `--target-language=js`
   
   In apache/arrow-rs
   * `--target-language=rust`
   
   Here is an example in apache/arrow-rs:
   
   T: Languages specified by `--target-language`
      * rust O: Languages not specified by `--target-language`
      * cpp
      * csharp
      * go
      * java
      * js
      * nanoarrow
   
   Used matrix:
   
   | Producer | Consumer |
   |----------|----------|
   | Rust     | Rust     |
   | Rust     | C++      |
   | Rust     | C#       |
   | Rust     | Go       |
   | Rust     | Java     |
   | Rust     | JS       |
   | Rust     | nanoarrow|
   | C++      | Rust     |
   | C#       | Rust     |
   | Go       | Rust     |
   | Java     | Rust     |
   | JS       | Rust     |
   | nanoarrow| Rust     |
   
   If no `--target-language` is specified, all enabled languages are the target languages. (The same as the current behavior.)
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764596889


##########
dev/archery/archery/cli.py:
##########
@@ -744,6 +744,9 @@ def _set_default(opt, default):
 @click.option('--with-rust', type=bool, default=False,
               help='Include Rust in integration tests',
               envvar="ARCHERY_INTEGRATION_WITH_RUST")
+@click.option('--target-languages', default='',
+              help=('Target languages in this integration tests'),
+              envvar="ARCHERY_INTEGRATION_TARGET_LANGUAGES")

Review Comment:
   Thanks. I'll use it: GH-44158



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44099:
URL: https://github.com/apache/arrow/pull/44099#issuecomment-2348241897

   Hmm. "Rust -> Rust" still exists...:
   
   https://github.com/apache/arrow/actions/runs/10844206629/job/30092647347?pr=44099#step:9:11984
   
   ```text
   Integration: Test: IPC: Rust -> Rust
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44099:
URL: https://github.com/apache/arrow/pull/44099#issuecomment-2348136121

   :warning: GitHub issue #44062 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #44099:
URL: https://github.com/apache/arrow/pull/44099


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764593328


##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
 def run_all_tests(with_cpp=True, with_java=True, with_js=True,
                   with_csharp=True, with_go=True, with_rust=False,
                   with_nanoarrow=False, run_ipc=False, run_flight=False,
-                  run_c_data=False, tempdir=None, **kwargs):
+                  run_c_data=False, tempdir=None, target_languages="",
+                  **kwargs):
     tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+    print(["before", target_languages])
+    target_languages = list(filter(len, target_languages.split(",")))

Review Comment:
   Because `--target-languages=cpp,java` is an input. We need to extract `cpp` and `java` from `cpp,java`.
   
   I know that click supports `--target-language=cpp --target-languages=java` style. But reusing `ci/scripts/integration_arrow.sh` in apache/arrow, apache/arrow-rs, apache/arrow-nanoarrow and apache/arrow-go is difficult with the style. Entirely overwritable `--target-languages=cpp,java` style is easy to reusable.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #44099:
URL: https://github.com/apache/arrow/pull/44099#issuecomment-2350885177

   +1
   
   No "Rust -> Rust":
   
   https://github.com/apache/arrow/actions/runs/10858710101/job/30137035840?pr=44099#step:9:6499
   
   ```text
   Integration: Test: IPC: C++ -> C++
   Integration: Test: IPC: C++ -> Java
   Integration: Test: IPC: C++ -> JS
   Integration: Test: IPC: C++ -> C#
   Integration: Test: IPC: C++ -> Go
   Integration: Test: IPC: Java -> C++
   Integration: Test: IPC: Java -> Java
   Integration: Test: IPC: Java -> JS
   Integration: Test: IPC: Java -> C#
   Integration: Test: IPC: Java -> Go
   Integration: Test: IPC: JS -> C++
   Integration: Test: IPC: JS -> Java
   Integration: Test: IPC: JS -> JS
   Integration: Test: IPC: JS -> C#
   Integration: Test: IPC: JS -> Go
   Integration: Test: IPC: C# -> C++
   Integration: Test: IPC: C# -> Java
   Integration: Test: IPC: C# -> JS
   Integration: Test: IPC: C# -> C#
   Integration: Test: IPC: C# -> Go
   Integration: Test: IPC: Go -> C++
   Integration: Test: IPC: Go -> Java
   Integration: Test: IPC: Go -> JS
   Integration: Test: IPC: Go -> C#
   Integration: Test: IPC: Go -> Go
   Integration: Test: IPC: C++ -> Rust
   Integration: Test: IPC: Java -> Rust
   Integration: Test: IPC: JS -> Rust
   Integration: Test: IPC: C# -> Rust
   Integration: Test: IPC: Go -> Rust
   Integration: Test: IPC: Rust -> C++
   Integration: Test: IPC: Rust -> Java
   Integration: Test: IPC: Rust -> JS
   Integration: Test: IPC: Rust -> C#
   Integration: Test: IPC: Rust -> Go
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1758364222


##########
ci/scripts/integration_arrow.sh:
##########
@@ -63,10 +63,15 @@ time archery integration \
     --run-ipc \
     --run-flight \
     --with-cpp=$([ "$ARROW_INTEGRATION_CPP" == "ON" ] && echo "1" || echo "0") \
+    --target-language=cpp \
     --with-csharp=$([ "$ARROW_INTEGRATION_CSHARP" == "ON" ] && echo "1" || echo "0") \
+    --target-language=csharp \
     --with-go=$([ "$ARROW_INTEGRATION_GO" == "ON" ] && echo "1" || echo "0") \
+    --target-language=go \
     --with-java=$([ "$ARROW_INTEGRATION_JAVA" == "ON" ] && echo "1" || echo "0") \
+    --target-language=java \
     --with-js=$([ "$ARROW_INTEGRATION_JS" == "ON" ] && echo "1" || echo "0") \
+    --target-language=js \

Review Comment:
   This file is used by apache/arrow-rs too.
   So embedding `--target-language` here isn't a good approach.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764309835


##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
 def run_all_tests(with_cpp=True, with_java=True, with_js=True,
                   with_csharp=True, with_go=True, with_rust=False,
                   with_nanoarrow=False, run_ipc=False, run_flight=False,
-                  run_c_data=False, tempdir=None, **kwargs):
+                  run_c_data=False, tempdir=None, target_languages="",
+                  **kwargs):
     tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+    print(["before", target_languages])

Review Comment:
   Yes... I've removed it: https://github.com/apache/arrow/pull/44140



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764538058


##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
 def run_all_tests(with_cpp=True, with_java=True, with_js=True,
                   with_csharp=True, with_go=True, with_rust=False,
                   with_nanoarrow=False, run_ipc=False, run_flight=False,
-                  run_c_data=False, tempdir=None, **kwargs):
+                  run_c_data=False, tempdir=None, target_languages="",
+                  **kwargs):
     tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+    print(["before", target_languages])
+    target_languages = list(filter(len, target_languages.split(",")))

Review Comment:
   Why would you pass `,`? It's ok to make it an error IMHO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764609019


##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
 def run_all_tests(with_cpp=True, with_java=True, with_js=True,
                   with_csharp=True, with_go=True, with_rust=False,
                   with_nanoarrow=False, run_ipc=False, run_flight=False,
-                  run_c_data=False, tempdir=None, **kwargs):
+                  run_c_data=False, tempdir=None, target_languages="",
+                  **kwargs):
     tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+    print(["before", target_languages])
+    target_languages = list(filter(len, target_languages.split(",")))

Review Comment:
   Thanks. I'll use it in #44156.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764600323


##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
 def run_all_tests(with_cpp=True, with_java=True, with_js=True,
                   with_csharp=True, with_go=True, with_rust=False,
                   with_nanoarrow=False, run_ipc=False, run_flight=False,
-                  run_c_data=False, tempdir=None, **kwargs):
+                  run_c_data=False, tempdir=None, target_languages="",
+                  **kwargs):
     tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+    print(["before", target_languages])
+    target_languages = list(filter(len, target_languages.split(",")))

Review Comment:
   Ah, you're talking about the empty string, sorry, I had misread.
   Then I would suggest the much more idiomatic
   ```suggestion
       target_languages = target_languages.split(",") if target_languages else []
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1763141360


##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
 def run_all_tests(with_cpp=True, with_java=True, with_js=True,
                   with_csharp=True, with_go=True, with_rust=False,
                   with_nanoarrow=False, run_ipc=False, run_flight=False,
-                  run_c_data=False, tempdir=None, **kwargs):
+                  run_c_data=False, tempdir=None, target_languages="",
+                  **kwargs):
     tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+    print(["before", target_languages])
+    target_languages = list(filter(len, target_languages.split(",")))

Review Comment:
   Why the `filter` call?



##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
 def run_all_tests(with_cpp=True, with_java=True, with_js=True,
                   with_csharp=True, with_go=True, with_rust=False,
                   with_nanoarrow=False, run_ipc=False, run_flight=False,
-                  run_c_data=False, tempdir=None, **kwargs):
+                  run_c_data=False, tempdir=None, target_languages="",
+                  **kwargs):
     tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+    print(["before", target_languages])

Review Comment:
   You should remove those `print` calls



##########
dev/archery/archery/cli.py:
##########
@@ -744,6 +744,9 @@ def _set_default(opt, default):
 @click.option('--with-rust', type=bool, default=False,
               help='Include Rust in integration tests',
               envvar="ARCHERY_INTEGRATION_WITH_RUST")
+@click.option('--target-languages', default='',
+              help=('Target languages in this integration tests'),
+              envvar="ARCHERY_INTEGRATION_TARGET_LANGUAGES")

Review Comment:
   Uh, can the help string be more explanatory? It's really not possible to understand what this does from the current wording.



##########
dev/archery/archery/cli.py:
##########
@@ -744,6 +744,9 @@ def _set_default(opt, default):
 @click.option('--with-rust', type=bool, default=False,
               help='Include Rust in integration tests',
               envvar="ARCHERY_INTEGRATION_WITH_RUST")
+@click.option('--target-languages', default='',

Review Comment:
   "Languages" is not really right here, as nanoarrow for example is not a language. "Implementations" perhaps?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44099:
URL: https://github.com/apache/arrow/pull/44099#issuecomment-2354795817

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 38b0c79c85e2835df7d54385bf725d5b060bf81e.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/30242765633) has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764310622


##########
dev/archery/archery/integration/runner.py:
##########
@@ -560,31 +583,42 @@ def get_static_json_files():
 def run_all_tests(with_cpp=True, with_java=True, with_js=True,
                   with_csharp=True, with_go=True, with_rust=False,
                   with_nanoarrow=False, run_ipc=False, run_flight=False,
-                  run_c_data=False, tempdir=None, **kwargs):
+                  run_c_data=False, tempdir=None, target_languages="",
+                  **kwargs):
     tempdir = tempdir or tempfile.mkdtemp(prefix='arrow-integration-')
+    print(["before", target_languages])
+    target_languages = list(filter(len, target_languages.split(",")))

Review Comment:
   Because `"".split(",")` returns `[""]` not `[]`.
   (I surprised the Python behavior because `"".split(",")` returns `[]` with Ruby.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764311816


##########
dev/archery/archery/cli.py:
##########
@@ -744,6 +744,9 @@ def _set_default(opt, default):
 @click.option('--with-rust', type=bool, default=False,
               help='Include Rust in integration tests',
               envvar="ARCHERY_INTEGRATION_WITH_RUST")
+@click.option('--target-languages', default='',

Review Comment:
   OK. I'll rename it: GH-44155



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764309594


##########
dev/archery/archery/cli.py:
##########
@@ -744,6 +744,9 @@ def _set_default(opt, default):
 @click.option('--with-rust', type=bool, default=False,
               help='Include Rust in integration tests',
               envvar="ARCHERY_INTEGRATION_WITH_RUST")
+@click.option('--target-languages', default='',
+              help=('Target languages in this integration tests'),
+              envvar="ARCHERY_INTEGRATION_TARGET_LANGUAGES")

Review Comment:
   Sure. But is the help string a suitable location to explain it more with click API?
   In general, `--help` output uses a simple one-line (or a few lines) per option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44062: [Dev][Archery][Integration] Reduce needless test matrix [arrow]

Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on code in PR #44099:
URL: https://github.com/apache/arrow/pull/44099#discussion_r1764541251


##########
dev/archery/archery/cli.py:
##########
@@ -744,6 +744,9 @@ def _set_default(opt, default):
 @click.option('--with-rust', type=bool, default=False,
               help='Include Rust in integration tests',
               envvar="ARCHERY_INTEGRATION_WITH_RUST")
+@click.option('--target-languages', default='',
+              help=('Target languages in this integration tests'),
+              envvar="ARCHERY_INTEGRATION_TARGET_LANGUAGES")

Review Comment:
   Then it can be explained in the command's `help`: https://click.palletsprojects.com/en/8.1.x/api/#click.Command
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org